From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752412AbdHOMBl (ORCPT ); Tue, 15 Aug 2017 08:01:41 -0400 Received: from mout.web.de ([212.227.15.3]:53174 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751224AbdHOMBj (ORCPT ); Tue, 15 Aug 2017 08:01:39 -0400 Subject: [PATCH 3/5] net/9p: Add a jump target in p9_client_walk() From: SF Markus Elfring To: v9fs-developer@lists.sourceforge.net, netdev@vger.kernel.org, "David S. Miller" , Eric Van Hensbergen , Latchesar Ionkov , Ron Minnich Cc: LKML , kernel-janitors@vger.kernel.org References: <22a44d7c-cdb9-e206-4b2c-56e38cbf0de1@users.sourceforge.net> Message-ID: <5b39be44-cbec-9838-77c6-00b99f5fe0a2@users.sourceforge.net> Date: Tue, 15 Aug 2017 14:01:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <22a44d7c-cdb9-e206-4b2c-56e38cbf0de1@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:blqcNzKb4FblCg8EQyk9vjRoyzr9K95uCHUquraIjQ8atd2SZLH vDtLjbbFujT2FqavoGfQ45tOgLZEJ269pgTOp+bKGRNH5STQ5nIXU/Wee21zGLIiH7V8ALV aHg31cFy4yaJogkLudFlgCQXzVctGVd7L7pGkLKq3mT5X26BKMVchhTZdT0Ie58HeVxJ2j8 4RNTD3iz8SAPo/uAWHkbQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:sqEp6OAM4q0=:hWir33dWglpJiKiVzyQ4m7 mMnFYrXIhQFk5NLuOS4uW0QlVJdPFcrUOvRriFXDxSL4AB3s+pOIGlzBp1w+w8WAHNRJhtHIK mLXzQWY4jKEH9DWnaX77MrfCmgIN7e/85ZU02tAE3Zk5/i+fW9z769NkpI9yX70UvDnVFCRjh JIdnPJBksqdbr4N92OZ36HzhRIpHmEIPzIzOPiw5y37IJ3ZSihckSUkgliSao1C0E3zTyngmq qiddasowj+eoO3POE7dIO1uPQyapwlXrDOUhhQXUIdbmvhxWahl5o9Tsrr3wwIUkkM3biR5vI MG4kNOiCGOQ1WleAdvZVmlj6J/jDyfpd/5SoPigEGU8QVlZomr3fUw0yghHVORHETY0SsEQgA T5rGUwtwP8Exf1zINmFyzGxbHC88qKCZJ8sFnLx/awMspubHcJbrrlkTBPF0qPZmFqhQQXwGX PoWBum/pNi4TR3gkKT3r/ugIHTX6RDKnzjwJYKac6F+FJWypdwwjzF+ii64a1l/apBoWqw/iV TiUNvmgEenpCaLbzyUAaL45d0/zqhmC9Oajm13ZNebjbT/LI53U1MeOGnyD9MJ9MFRrNsw2ix 3BoU+Fj7Wk7rsxTMSfeDJ11jzeC/TgT1Nh9n6oinSxzh/3Xq634qbTTxrtUALtouNqaQwbg03 yTaYIabkX9q1Y5p+zcTtxntbhK+VRepnUioirLwXfrTAOD7JJg/n9NGmMpwz0p9F7P3mizRV1 ujv3M22PDxfppeUfG5/55REp6DOYJT7QeTv2lh+NJWzPhc27DSVQZpkl62C1nL1C3+AIuXW8d LERp4mTHVov/9FfguS1S8CZb1PT9BTXprAW3/0GKxywKBrM/hs= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Tue, 15 Aug 2017 10:07:22 +0200 Replace a variable assignment by a goto statement so that an extra check will be avoided at the end of this function. Signed-off-by: Markus Elfring --- net/9p/client.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/net/9p/client.c b/net/9p/client.c index 2ca55d4b0b7d..6c2fc796edfb 100644 --- a/net/9p/client.c +++ b/net/9p/client.c @@ -1237,12 +1237,11 @@ struct p9_fid *p9_client_walk(struct p9_fid *oldfid, uint16_t nwname, clunk_fid: kfree(wqids); p9_client_clunk(fid); - fid = NULL; - + goto exit; error: if (fid && (fid != oldfid)) p9_fid_destroy(fid); - +exit: return ERR_PTR(err); } EXPORT_SYMBOL(p9_client_walk); -- 2.14.0 From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Tue, 15 Aug 2017 12:01:11 +0000 Subject: [PATCH 3/5] net/9p: Add a jump target in p9_client_walk() Message-Id: <5b39be44-cbec-9838-77c6-00b99f5fe0a2@users.sourceforge.net> List-Id: References: <22a44d7c-cdb9-e206-4b2c-56e38cbf0de1@users.sourceforge.net> In-Reply-To: <22a44d7c-cdb9-e206-4b2c-56e38cbf0de1@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: v9fs-developer@lists.sourceforge.net, netdev@vger.kernel.org, "David S. Miller" , Eric Van Hensbergen , Latchesar Ionkov , Ron Minnich Cc: LKML , kernel-janitors@vger.kernel.org From: Markus Elfring Date: Tue, 15 Aug 2017 10:07:22 +0200 Replace a variable assignment by a goto statement so that an extra check will be avoided at the end of this function. Signed-off-by: Markus Elfring --- net/9p/client.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/net/9p/client.c b/net/9p/client.c index 2ca55d4b0b7d..6c2fc796edfb 100644 --- a/net/9p/client.c +++ b/net/9p/client.c @@ -1237,12 +1237,11 @@ struct p9_fid *p9_client_walk(struct p9_fid *oldfid, uint16_t nwname, clunk_fid: kfree(wqids); p9_client_clunk(fid); - fid = NULL; - + goto exit; error: if (fid && (fid != oldfid)) p9_fid_destroy(fid); - +exit: return ERR_PTR(err); } EXPORT_SYMBOL(p9_client_walk); -- 2.14.0