All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Rhodes <drhodes@opensource.cirrus.com>
To: Charles Keepax <ckeepax@opensource.cirrus.com>
Cc: robh@kernel.org, brian.austin@cirrus.com,
	patches@opensource.cirrus.com, alsa-devel@alsa-project.org,
	david.rhodes@cirrus.com, broonie@kernel.org,
	pierre-louis.bossart@linux.intel.com
Subject: Re: [PATCH v6 2/2] ASoC: cs35l41: Add bindings for CS35L41
Date: Tue, 7 Sep 2021 12:38:31 -0500	[thread overview]
Message-ID: <5b39e0aa-09e8-0bcc-2234-87d35aea109e@opensource.cirrus.com> (raw)
In-Reply-To: <20210906094322.GN9223@ediswmail.ad.cirrus.com>

On 9/6/21 4:43 AM, Charles Keepax wrote:
> On Fri, Sep 03, 2021 at 04:26:59PM -0500, David Rhodes wrote:
>> +  cirrus,classh-bst-max-limit:
>> +    description:
>> +      Value set to the BST_CTL_LIM_EN field.
>> +      A value of 1 will limit the Class-H voltage to the value in the
>> +      'boost-ctl-millivolt' property.
>> +      0 = No Class-H limit (default)
>> +      1 = Class-H limited to 'boost-ctl-millivolt' value
>> +    $ref: "/schemas/types.yaml#/definitions/uint32"
>> +    minimum: 0
>> +    maximum: 1
> 
> There is no boost-ctl-millivolt property however. Apart from
> tidying up that loose end I think the series looks ok to me
> though.
> 
> Thanks,
> Charles
> 

Yes, I missed this while moving the boost properties. 
classh-bst-max-limit should be removed since it doesn't work without 
boost-ctl-millivolt. boost-peak-milliamp is more appropriate for 
limiting the boost, and will remain a required property.

Thanks,
David

      reply	other threads:[~2021-09-07 17:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-03 21:26 [PATCH v6 0/2] Cirrus Logic CS35L41 Amplifier David Rhodes
2021-09-03 21:26 ` [PATCH v6 1/2] ASoC: cs35l41: CS35L41 Boosted Smart Amplifier David Rhodes
2021-09-03 21:26 ` [PATCH v6 2/2] ASoC: cs35l41: Add bindings for CS35L41 David Rhodes
2021-09-06  9:43   ` Charles Keepax
2021-09-07 17:38     ` David Rhodes [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5b39e0aa-09e8-0bcc-2234-87d35aea109e@opensource.cirrus.com \
    --to=drhodes@opensource.cirrus.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=brian.austin@cirrus.com \
    --cc=broonie@kernel.org \
    --cc=ckeepax@opensource.cirrus.com \
    --cc=david.rhodes@cirrus.com \
    --cc=patches@opensource.cirrus.com \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.