* [PATCH] test-list-objects: mark file-local symbols as static
@ 2017-10-03 21:51 Ramsay Jones
2017-10-04 13:40 ` Derrick Stolee
0 siblings, 1 reply; 2+ messages in thread
From: Ramsay Jones @ 2017-10-03 21:51 UTC (permalink / raw)
To: dstolee; +Cc: Junio C Hamano, GIT Mailing-list
Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---
Hi Derrick,
If you need to re-roll your 'ds/find-unique-abbrev-optim' branch,
could you please squash this into the relevant patch (commit 3792c78ba0,
"test-list-objects: list a subset of object ids", 01-10-2017).
Thanks!
ATB,
Ramsay Jones
t/helper/test-list-objects.c | 32 ++++++++++++++++----------------
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/t/helper/test-list-objects.c b/t/helper/test-list-objects.c
index 22bc9b4e6..5c5d3c03f 100644
--- a/t/helper/test-list-objects.c
+++ b/t/helper/test-list-objects.c
@@ -6,43 +6,43 @@ struct count {
int select_mod;
};
-int count_loose(const struct object_id *oid,
- const char *path,
- void *data)
+static int count_loose(const struct object_id *oid,
+ const char *path,
+ void *data)
{
((struct count*)data)->total++;
return 0;
}
-int count_packed(const struct object_id *oid,
- struct packed_git *pack,
- uint32_t pos,
- void* data)
+static int count_packed(const struct object_id *oid,
+ struct packed_git *pack,
+ uint32_t pos,
+ void* data)
{
((struct count*)data)->total++;
return 0;
}
-void output(const struct object_id *oid,
- struct count *c)
+static void output(const struct object_id *oid,
+ struct count *c)
{
if (!(c->total % c->select_mod))
printf("%s\n", oid_to_hex(oid));
c->total--;
}
-int output_loose(const struct object_id *oid,
- const char *path,
- void *data)
+static int output_loose(const struct object_id *oid,
+ const char *path,
+ void *data)
{
output(oid, (struct count*)data);
return 0;
}
-int output_packed(const struct object_id *oid,
- struct packed_git *pack,
- uint32_t pos,
- void* data)
+static int output_packed(const struct object_id *oid,
+ struct packed_git *pack,
+ uint32_t pos,
+ void* data)
{
output(oid, (struct count*)data);
return 0;
--
2.14.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] test-list-objects: mark file-local symbols as static
2017-10-03 21:51 [PATCH] test-list-objects: mark file-local symbols as static Ramsay Jones
@ 2017-10-04 13:40 ` Derrick Stolee
0 siblings, 0 replies; 2+ messages in thread
From: Derrick Stolee @ 2017-10-04 13:40 UTC (permalink / raw)
To: Ramsay Jones, dstolee; +Cc: Junio C Hamano, GIT Mailing-list
On 10/3/2017 5:51 PM, Ramsay Jones wrote:
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
>
> Hi Derrick,
>
> If you need to re-roll your 'ds/find-unique-abbrev-optim' branch,
> could you please squash this into the relevant patch (commit 3792c78ba0,
> "test-list-objects: list a subset of object ids", 01-10-2017).
>
> Thanks!
>
> ATB,
> Ramsay Jones
>
> t/helper/test-list-objects.c | 32 ++++++++++++++++----------------
> 1 file changed, 16 insertions(+), 16 deletions(-)
>
> diff --git a/t/helper/test-list-objects.c b/t/helper/test-list-objects.c
> index 22bc9b4e6..5c5d3c03f 100644
> --- a/t/helper/test-list-objects.c
> +++ b/t/helper/test-list-objects.c
> @@ -6,43 +6,43 @@ struct count {
> int select_mod;
> };
>
> -int count_loose(const struct object_id *oid,
> - const char *path,
> - void *data)
> +static int count_loose(const struct object_id *oid,
> + const char *path,
> + void *data)
> {
> ((struct count*)data)->total++;
> return 0;
> }
>
> -int count_packed(const struct object_id *oid,
> - struct packed_git *pack,
> - uint32_t pos,
> - void* data)
> +static int count_packed(const struct object_id *oid,
> + struct packed_git *pack,
> + uint32_t pos,
> + void* data)
> {
> ((struct count*)data)->total++;
> return 0;
> }
>
> -void output(const struct object_id *oid,
> - struct count *c)
> +static void output(const struct object_id *oid,
> + struct count *c)
> {
> if (!(c->total % c->select_mod))
> printf("%s\n", oid_to_hex(oid));
> c->total--;
> }
>
> -int output_loose(const struct object_id *oid,
> - const char *path,
> - void *data)
> +static int output_loose(const struct object_id *oid,
> + const char *path,
> + void *data)
> {
> output(oid, (struct count*)data);
> return 0;
> }
>
> -int output_packed(const struct object_id *oid,
> - struct packed_git *pack,
> - uint32_t pos,
> - void* data)
> +static int output_packed(const struct object_id *oid,
> + struct packed_git *pack,
> + uint32_t pos,
> + void* data)
> {
> output(oid, (struct count*)data);
> return 0;
Thanks, Ramsay. I applied these changes locally. I'll remember "static"
in the future.
Thanks,
-Stolee
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-04 13:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-03 21:51 [PATCH] test-list-objects: mark file-local symbols as static Ramsay Jones
2017-10-04 13:40 ` Derrick Stolee
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.