From: Damien Le Moal <damien.lemoal@opensource.wdc.com>
To: Wenchao Hao <haowenchao@huawei.com>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Zhiqiang Liu <liuzhiqiang26@huawei.com>
Subject: Re: [PATCH v3] ata: libata-scsi: simplify __ata_scsi_queuecmd()
Date: Tue, 11 Jan 2022 08:59:17 +0900 [thread overview]
Message-ID: <5b404e0e-837f-4e97-857f-542bd0b1e48e@opensource.wdc.com> (raw)
In-Reply-To: <20220106001354.2029046-1-haowenchao@huawei.com>
On 1/6/22 09:13, Wenchao Hao wrote:
> This is just a clean code. Since each branch of "if" state would check
> scmd->cmd_len, so move the check of scmd->cmd_len out of "if" state to
> simplify parameters check.
>
> After the check of scmd->cmd_len is out of "if" state, we can remove
> one redundant "if" state.
>
> Remove a redundant variable "rc" by hand.
>
> This patch do not change origin function logic.
>
> Signed-off-by: Wenchao Hao <haowenchao@huawei.com>
Applied to for-5.17 with some changes to the commit message to clarify
the changes.
Thanks.
--
Damien Le Moal
Western Digital Research
prev parent reply other threads:[~2022-01-10 23:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-06 0:13 [PATCH v3] ata: libata-scsi: simplify __ata_scsi_queuecmd() Wenchao Hao
2022-01-10 23:59 ` Damien Le Moal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b404e0e-837f-4e97-857f-542bd0b1e48e@opensource.wdc.com \
--to=damien.lemoal@opensource.wdc.com \
--cc=haowenchao@huawei.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuzhiqiang26@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.