From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Subject: Re: [PATCH 2/4] drm/i915: Handle incomplete Z_FINISH
 for compressed error states
Date: Tue, 2 Oct 2018 14:13:14 +0100
Message-ID: <5b408c9d-a3da-ffa3-55b8-e2a8da856e43@linux.intel.com>
References: <20181001194447.29910-1-chris@chris-wilson.co.uk>
 <20181001194447.29910-2-chris@chris-wilson.co.uk>
 <673d9c33-df35-d403-3e61-fbbc98047ba6@linux.intel.com>
 <153848307796.23109.12963662055734893298@skylake-alporthouse-com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 0F61A89CE2
 for <intel-gfx@lists.freedesktop.org>; Tue,  2 Oct 2018 13:13:16 +0000 (UTC)
In-Reply-To: <153848307796.23109.12963662055734893298@skylake-alporthouse-com>
Content-Language: en-GB
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

Ck9uIDAyLzEwLzIwMTggMTM6MjQsIENocmlzIFdpbHNvbiB3cm90ZToKPiBRdW90aW5nIFR2cnRr
byBVcnN1bGluICgyMDE4LTEwLTAyIDEzOjIwOjA1KQo+Pgo+PiBPbiAwMS8xMC8yMDE4IDIwOjQ0
LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4+PiBUaGUgZmluYWwgY2FsbCB0byB6bGliX2RlZmxhdGUo
Wl9GSU5JU0gpIG1heSByZXF1aXJlIG1vcmUgb3V0cHV0Cj4+PiBzcGFjZSB0byBiZSBhbGxvY2F0
ZWQgYW5kIHNvIG5lZWRzIHRvIHJlLWludm9rZWQuIEZhaWx1cmUgdG8gZG8gc28gaW4KPj4+IHRo
ZSBjdXJyZW50IGNvZGUgbGVhZHMgdG8gaW5jb21wbGV0ZSB6bGliIHN0cmVhbXMgKGFsYmVpdCBp
bnRhY3QgZHVlIHRvCj4+PiB0aGUgdXNlIG9mIFpfU1lOQ19GTFVTSCkgcmVzdWx0aW5nIGluIHRo
ZSBvY2Nhc2lvbmFsIHNob3J0IG9iamVjdAo+Pj4gY2FwdHVyZS4KPj4+Cj4+PiBUZXN0Y2FzZTog
aWd0L2k5MTUtZXJyb3ItY2FwdHVyZS5qcwo+Pj4gRml4ZXM6IDBhOTcwMTVkNDVlZSAoImRybS9p
OTE1OiBDb21wcmVzcyBHUFUgb2JqZWN0cyBpbiBlcnJvciBzdGF0ZSIpCj4+PiBTaWduZWQtb2Zm
LWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPj4+IENjOiBKb29u
YXMgTGFodGluZW4gPGpvb25hcy5sYWh0aW5lbkBsaW51eC5pbnRlbC5jb20+Cj4+PiBDYzogPHN0
YWJsZUB2Z2VyLmtlcm5lbC5vcmc+ICMgdjQuMTArCj4+PiAtLS0KPj4+ICAgIGRyaXZlcnMvZ3B1
L2RybS9pOTE1L2k5MTVfZ3B1X2Vycm9yLmMgfCA2MCArKysrKysrKysrKysrKysrKysrKystLS0t
LS0KPj4+ICAgIDEgZmlsZSBjaGFuZ2VkLCA0NyBpbnNlcnRpb25zKCspLCAxMyBkZWxldGlvbnMo
LSkKPj4+Cj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ncHVfZXJy
b3IuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3B1X2Vycm9yLmMKPj4+IGluZGV4IDNk
NTU1NGYxNGRmZC4uZWQ4YzE2Y2JmYWE0IDEwMDY0NAo+Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJt
L2k5MTUvaTkxNV9ncHVfZXJyb3IuYwo+Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx
NV9ncHVfZXJyb3IuYwo+Pj4gQEAgLTIzNyw2ICsyMzcsNyBAQCBzdGF0aWMgaW50IGNvbXByZXNz
X3BhZ2Uoc3RydWN0IGNvbXByZXNzICpjLAo+Pj4gICAgICAgICAgICAgICAgICAgICAgICAgc3Ry
dWN0IGRybV9pOTE1X2Vycm9yX29iamVjdCAqZHN0KQo+Pj4gICAgewo+Pj4gICAgICAgIHN0cnVj
dCB6X3N0cmVhbV9zICp6c3RyZWFtID0gJmMtPnpzdHJlYW07Cj4+PiArICAgICBpbnQgZmx1c2gg
PSBaX05PX0ZMVVNIOwo+Pj4gICAgCj4+PiAgICAgICAgenN0cmVhbS0+bmV4dF9pbiA9IHNyYzsK
Pj4+ICAgICAgICBpZiAoYy0+dG1wICYmIGk5MTVfbWVtY3B5X2Zyb21fd2MoYy0+dG1wLCBzcmMs
IFBBR0VfU0laRSkpCj4+PiBAQCAtMjU3LDggKzI1OCwxMSBAQCBzdGF0aWMgaW50IGNvbXByZXNz
X3BhZ2Uoc3RydWN0IGNvbXByZXNzICpjLAo+Pj4gICAgICAgICAgICAgICAgICAgICAgICB6c3Ry
ZWFtLT5hdmFpbF9vdXQgPSBQQUdFX1NJWkU7Cj4+PiAgICAgICAgICAgICAgICB9Cj4+Cj4+IExv
b2tzIGxpa2UgdGhlIGJsb2NrIGFib3ZlLCBub3Qgc2hvd24gaW4gdGhpcyBkaWZmLCBjb3VsZCB1
c2UgYSBjaGVjawo+PiBhbmQgYWJvcnQgaWYgdGhlIGRzdC0+cGFnZV9jb3VudCBvdmVyZ3Jvd3Mg
dGhlIHBlc3NpbWlzdGljIGFsbG9jYXRpb24gb2YKPj4gdGhlIGFycmF5Lgo+Pgo+Pj4gICAgCj4+
PiAtICAgICAgICAgICAgIGlmICh6bGliX2RlZmxhdGUoenN0cmVhbSwgWl9TWU5DX0ZMVVNIKSAh
PSBaX09LKQo+Pj4gKyAgICAgICAgICAgICBpZiAoemxpYl9kZWZsYXRlKHpzdHJlYW0sIGZsdXNo
KSAhPSBaX09LKQo+Pgo+PiBTbyB0aGlzIChub3QgYWx3YXlzIGFza2luZyBmb3IgYSBmbHVzaCkg
YWN0dWFsbHkgbm90IG9ubHkgZml4ZXMgdGhlCj4+IGZsdXNoIGF0IHRoZSBlbmQgYnV0IGltcHJv
dmVzIHRoZSBBUEkgdXNhZ2UgYW5kIHBvdGVudGlhbGx5IGNvbXByZXNzaW9uCj4+IHJhdGlvLCBj
b3JyZWN0Pwo+IAo+IFllcy4KPiAgIAo+Pj4gICAgICAgICAgICAgICAgICAgICAgICByZXR1cm4g
LUVJTzsKPj4+ICsKPj4+ICsgICAgICAgICAgICAgaWYgKHpzdHJlYW0tPmF2YWlsX291dCkKPj4+
ICsgICAgICAgICAgICAgICAgICAgICBmbHVzaCA9IFpfU1lOQ19GTFVTSDsKPj4KPj4gSG0uLiBi
dXQgd2h5IHRoaXM/IEl0IHdpbGwgZmx1c2ggb25seSBvY2Nhc2lvbmFsbHksIHdoZW4gb25lIGlu
cHV0IHBhZ2UKPj4gZGlkIG5vdCBmaXQgaW4gdGhlIGF2YWlsYWJsZSBvdXRwdXQgLSBidXQgdGhh
dCB3aWxsIGRlcGVuZCBvbgo+PiBjb21wcmVzc2liaWxpdHkgc28gSSBkb24ndCB0aGluayBpdCBo
YXMgYSBmaXhlZCBwZXJpb2QuIEl0IGlzIG5vdCBmb3IKPj4gaW5zdGFuY2UgZm9yIGV2ZXJ5IDRr
IG9mIGNvbXByZXNzZWQgb3V0cHV0LCBpZiB0aGF0IHdhcyBtYXliZSB0aGUgZ29hbC4KPiAKPiBN
eSB0aGlua2luZyBpcyB0aGF0IGlmIHRoZSB6bGliX2RlZmxhdGUoKSB3YW50cyB0byBkZWZlciB0
byBmaWxsIGl0cwo+IHdpbmRvdyAob3Igd2hhdGV2ZXIpIGJ1dCB3ZSBuZWVkIHRvIGNyb3NzIGEg
cGFnZSBib3VuZGFyeSwgd2UgaGF2ZSB0bwo+IHB1c2ggZXZlcnl0aGluZyBmcm9tIHRoZSBjdXJy
ZW50IHBhZ2UgYmVmb3JlIHdlIGNoYW5nZSB0aGUgUFRFLgoKSG0gYnV0IEkgYW0gbm90IHN1cmUg
dGhpcyBpcyBhY2hpZXZpbmcgdGhhdCwgb3IgdGhhdCBpdCBpcyBuZWVkZWQuIEkgCnJlYWQgdGhl
IGRvY3MgbWFueSB0aW1lcyBhbmQgSSBhbSBub3Qgc3VyZSBob3cgaXQgaXMgc3VwcG9zZWQgdG8g
d29yay4KCkZpcnN0IHRoaW5nIEkgYW0gbm90IHN1cmUgb2YgaXMgd2hldGhlciB3ZSBuZWVkIHRv
IGFzayBmb3IgYW55IGZsdXNoZXMsIApvciBpdCB3b3VsZCBiZSBlbm91Z2ggdG8gbG9vcCB1bnRp
bCBhdmFpbF9pbiA+IDAgfHwgYXZhaWxfb3V0ID09IDAuIApTaW5jZSBkb2NzIHNheSB0aGF0IGlm
IGF2YWlsX291dCA9PSAwLCB6bGliX2RlZmxhdGUgbmVlZHMgdG8gYmUgY2FsbGVkIAphZ2FpbiBp
biB0aGUgc2FtZSBmbHVzaCBtb2RlLgoKQ3VycmVudCBjb2RlIGZhaWxzIHRvIGVuc3VyZSB0aGlz
LiBJdCB3b3VsZCBoYXBwZW4gb24gdGhlIG5leHQgY2FsbCB0byAKY29tcHJlc3NfcGFnZSwgYnV0
IGEpIEkgdGhpbmsgdGhhdCBpcyB1bmNsZWFuIGFuZCBiKSBmbHVzaCBtb2RlIHdpbGwgbm90IApt
YXRjaC4KClNvIEkgdGhpbmsgaXQgd291bGQgYmUgaW50ZXJlc3RpbmcgdG8gdHJ5OgoKZG8gewoJ
Z2V0X3BhZ2VfaWZfbm9fc3BhY2U7Cgl6bGliX2RlZmxhdGUobm9fZmx1c2gpID09IFpfT0sgb3Ig
LUVJTzsKd2hpbGUgKGF2YWlsX2luIHx8ICFhdmFpbF9vdXQpOwoKVGhpcyB3b3VsZCBtYWtlIHN1
cmUgd2hvbGUgaW5wdXQgcGFnZSBpcyBvdXRwdXQgYmVmb3JlIGdvaW5nIHRvIG5leHQgcGFnZS4K
CkJ1dCBteSBjb25maWRlbmNlIGxldmVsIHRoaXMgaXMgY29ycmVjdCBpcyBub3Qgc3VwZXIgaGln
aC4uCgpSZWdhcmRzLAoKVHZydGtvCgo+IAo+Pj4gICAgICAgIH0gd2hpbGUgKHpzdHJlYW0tPmF2
YWlsX2luKTsKPj4+ICAgIAo+Pj4gICAgICAgIC8qIEZhbGxiYWNrIHRvIHVuY29tcHJlc3NlZCBp
ZiB3ZSBpbmNyZWFzZSBzaXplPyAqLwo+Pj4gQEAgLTI2OCwxOSArMjcyLDQzIEBAIHN0YXRpYyBp
bnQgY29tcHJlc3NfcGFnZShzdHJ1Y3QgY29tcHJlc3MgKmMsCj4+PiAgICAgICAgcmV0dXJuIDA7
Cj4+PiAgICB9Cj4+PiAgICAKPj4+IC1zdGF0aWMgdm9pZCBjb21wcmVzc19maW5pKHN0cnVjdCBj
b21wcmVzcyAqYywKPj4+ICtzdGF0aWMgaW50IGNvbXByZXNzX2ZsdXNoKHN0cnVjdCBjb21wcmVz
cyAqYywKPj4+ICAgICAgICAgICAgICAgICAgICAgICAgICBzdHJ1Y3QgZHJtX2k5MTVfZXJyb3Jf
b2JqZWN0ICpkc3QpCj4+PiAgICB7Cj4+PiAgICAgICAgc3RydWN0IHpfc3RyZWFtX3MgKnpzdHJl
YW0gPSAmYy0+enN0cmVhbTsKPj4+ICsgICAgIHVuc2lnbmVkIGxvbmcgcGFnZTsKPj4+ICAgIAo+
Pj4gLSAgICAgaWYgKGRzdCkgewo+Pj4gLSAgICAgICAgICAgICB6bGliX2RlZmxhdGUoenN0cmVh
bSwgWl9GSU5JU0gpOwo+Pj4gLSAgICAgICAgICAgICBkc3QtPnVudXNlZCA9IHpzdHJlYW0tPmF2
YWlsX291dDsKPj4+IC0gICAgIH0KPj4+ICsgICAgIGRvIHsKPj4+ICsgICAgICAgICAgICAgc3dp
dGNoICh6bGliX2RlZmxhdGUoenN0cmVhbSwgWl9GSU5JU0gpKSB7Cj4+PiArICAgICAgICAgICAg
IGNhc2UgWl9PSzogLyogbW9yZSBzcGFjZSByZXF1ZXN0ZWQgKi8KPj4+ICsgICAgICAgICAgICAg
ICAgICAgICBwYWdlID0gX19nZXRfZnJlZV9wYWdlKEdGUF9BVE9NSUMgfCBfX0dGUF9OT1dBUk4p
Owo+Pj4gKyAgICAgICAgICAgICAgICAgICAgIGlmICghcGFnZSkKPj4+ICsgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgIHJldHVybiAtRU5PTUVNOwo+Pj4gKwo+Pj4gKyAgICAgICAgICAgICAg
ICAgICAgIGRzdC0+cGFnZXNbZHN0LT5wYWdlX2NvdW50KytdID0gKHZvaWQgKilwYWdlOwo+Pgo+
PiBJJ2QgcHV0IGluIGEgY2hlY2sgZm9yIHBhZ2VzIGFycmF5IGV4aGF1c3Rpb24gaGVyZSBhcyB3
ZWxsLiBPciBldmVuCj4+IGJldHRlciwgY29tcHJlc3NfcGFnZSBhbmQgY29tcHJlc3NfZmx1c2gg
Y291bGQgc2hhcmUgdGhpcyB3aG9sZSBibG9jay4KPj4KPj4+ICsgICAgICAgICAgICAgICAgICAg
ICB6c3RyZWFtLT5uZXh0X291dCA9ICh2b2lkICopcGFnZTsKPj4+ICsgICAgICAgICAgICAgICAg
ICAgICB6c3RyZWFtLT5hdmFpbF9vdXQgPSBQQUdFX1NJWkU7Cj4+PiArICAgICAgICAgICAgICAg
ICAgICAgYnJlYWs7Cj4+PiArICAgICAgICAgICAgIGNhc2UgWl9TVFJFQU1fRU5EOgo+Pj4gKyAg
ICAgICAgICAgICAgICAgICAgIGdvdG8gZW5kOwo+Pj4gKyAgICAgICAgICAgICBkZWZhdWx0OiAv
KiBhbnkgZXJyb3IgKi8KPj4+ICsgICAgICAgICAgICAgICAgICAgICByZXR1cm4gLUVJTzsKPj4+
ICsgICAgICAgICAgICAgfQo+Pj4gKyAgICAgfSB3aGlsZSAoMSk7Cj4+PiArCj4+PiArZW5kOgo+
Pj4gKyAgICAgbWVtc2V0KHpzdHJlYW0tPm5leHRfb3V0LCAwLCB6c3RyZWFtLT5hdmFpbF9vdXQp
Owo+Pj4gKyAgICAgZHN0LT51bnVzZWQgPSB6c3RyZWFtLT5hdmFpbF9vdXQ7Cj4+PiArICAgICBy
ZXR1cm4gMDsKPj4+ICt9Cj4+PiArCj4+PiArc3RhdGljIHZvaWQgY29tcHJlc3NfZmluaShzdHJ1
Y3QgY29tcHJlc3MgKmMsCj4+PiArICAgICAgICAgICAgICAgICAgICAgICBzdHJ1Y3QgZHJtX2k5
MTVfZXJyb3Jfb2JqZWN0ICpkc3QpCj4+PiArewo+Pj4gKyAgICAgc3RydWN0IHpfc3RyZWFtX3Mg
KnpzdHJlYW0gPSAmYy0+enN0cmVhbTsKPj4+ICAgIAo+Pj4gICAgICAgIHpsaWJfZGVmbGF0ZUVu
ZCh6c3RyZWFtKTsKPj4+ICAgICAgICBrZnJlZSh6c3RyZWFtLT53b3Jrc3BhY2UpOwo+Pj4gLQo+
Pj4gICAgICAgIGlmIChjLT50bXApCj4+PiAgICAgICAgICAgICAgICBmcmVlX3BhZ2UoKHVuc2ln
bmVkIGxvbmcpYy0+dG1wKTsKPj4+ICAgIH0KPj4+IEBAIC0zMTksNiArMzQ3LDEyIEBAIHN0YXRp
YyBpbnQgY29tcHJlc3NfcGFnZShzdHJ1Y3QgY29tcHJlc3MgKmMsCj4+PiAgICAgICAgcmV0dXJu
IDA7Cj4+PiAgICB9Cj4+PiAgICAKPj4+ICtzdGF0aWMgaW50IGNvbXByZXNzX2ZsdXNoKHN0cnVj
dCBjb21wcmVzcyAqYywKPj4+ICsgICAgICAgICAgICAgICAgICAgICAgIHN0cnVjdCBkcm1faTkx
NV9lcnJvcl9vYmplY3QgKmRzdCkKPj4+ICt7Cj4+PiArICAgICByZXR1cm4gMDsKPj4+ICt9Cj4+
PiArCj4+PiAgICBzdGF0aWMgdm9pZCBjb21wcmVzc19maW5pKHN0cnVjdCBjb21wcmVzcyAqYywK
Pj4+ICAgICAgICAgICAgICAgICAgICAgICAgICBzdHJ1Y3QgZHJtX2k5MTVfZXJyb3Jfb2JqZWN0
ICpkc3QpCj4+PiAgICB7Cj4+PiBAQCAtOTUxLDE1ICs5ODUsMTUgQEAgaTkxNV9lcnJvcl9vYmpl
Y3RfY3JlYXRlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICppOTE1LAo+Pj4gICAgICAgICAgICAg
ICAgaWYgKHJldCkKPj4+ICAgICAgICAgICAgICAgICAgICAgICAgZ290byB1bndpbmQ7Cj4+PiAg
ICAgICAgfQo+Pj4gLSAgICAgZ290byBvdXQ7Cj4+PiAgICAKPj4+ICsgICAgIGlmIChjb21wcmVz
c19mbHVzaCgmY29tcHJlc3MsIGRzdCkpIHsKPj4+ICAgIHVud2luZDoKPj4KPj4gQSBiaXQgbmFz
dHksIGp1bXAgaW4gY29uZGl0aW9uYWwgYmxvY2suIENvdWxkIHNldCBhIGJvb2xlYW4gYW5kIGJy
ZWFrCj4+IGZyb20gdGhlIGFib3ZlIGxvb3AuIExpa2UgImlmIChmYWlsZWQgfHwgY29tcHJlc3Nf
Zmx1c2goLi4uKSkiLgo+IAo+IE9yIGp1c3Qgam1wIGhlcmUgZm9yIHNpbXBsaWNpdHkgOi1wCj4g
LUNocmlzCj4gCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
CkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo
dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=