From: Joe Perches <joe@perches.com>
To: David Mosberger-Tang <davidm@egauge.net>,
Ajay Singh <ajay.kathat@microchip.com>
Cc: Claudiu Beznea <claudiu.beznea@microchip.com>,
Kalle Valo <kvalo@codeaurora.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] wilc1000: Fix missing newline in error message
Date: Tue, 07 Dec 2021 16:23:18 -0800 [thread overview]
Message-ID: <5b44cebddcda765942aa118d25740a074137d0f8.camel@perches.com> (raw)
In-Reply-To: <00d44cb3-3b38-7bb6-474f-c819c2403b6a@egauge.net>
On Tue, 2021-12-07 at 15:58 -0700, David Mosberger-Tang wrote:
> On 12/6/21 6:33 PM, Joe Perches wrote:
>
> > On Mon, 2021-12-06 at 23:27 +0000, David Mosberger-Tang wrote:
> > > Add missing newline in pr_err() message.
> > []
> > > diff --git a/drivers/net/wireless/microchip/wilc1000/netdev.c b/drivers/net/wireless/microchip/wilc1000/netdev.c
> > []
> > > @@ -27,7 +27,7 @@ static irqreturn_t isr_uh_routine(int irq, void *user_data)
> > > struct wilc *wilc = user_data;
> > >
> > > if (wilc->close) {
> > > - pr_err("Can't handle UH interrupt");
> > > + pr_err("Can't handle UH interrupt\n");
> > Ideally this would use wiphy_<level>:
> >
> > wiphy_err(wilc->wiphy, "Can't handle UH interrupt\n");
>
> Sure, but that's orthogonal to this bug fix.
Of course.
> I do have a "cleanups"
> branch with various cleanups of this sort. I'll look into fixing pr_*()
> calls in the cleanups branch (there are several of them, unsurprisingly).
netdev_<level> -> wiphy_<level> conversions too where feasible please.
next prev parent reply other threads:[~2021-12-08 0:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-06 23:27 wilc1000: Fix minor typos in error messages David Mosberger-Tang
2021-12-06 23:27 ` [PATCH 1/2] wilc1000: Fix copy-and-paste typo in wilc_set_mac_address David Mosberger-Tang
2021-12-14 18:43 ` Kalle Valo
2021-12-06 23:27 ` [PATCH 2/2] wilc1000: Fix missing newline in error message David Mosberger-Tang
2021-12-07 1:33 ` Joe Perches
2021-12-07 22:58 ` David Mosberger-Tang
2021-12-08 0:23 ` Joe Perches [this message]
2021-12-08 2:19 ` David Mosberger-Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b44cebddcda765942aa118d25740a074137d0f8.camel@perches.com \
--to=joe@perches.com \
--cc=ajay.kathat@microchip.com \
--cc=claudiu.beznea@microchip.com \
--cc=davem@davemloft.net \
--cc=davidm@egauge.net \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.