Re: How are the DC patches tested?

From: Paul Menzel <pmenzel@molgen.mpg.de>
To: Rodrigo Siqueira Jordao <Rodrigo.Siqueira@amd.com>
Cc: Chao-kai Wang <Stylon.Wang@amd.com>,
	Sun Peng Li <Sunpeng.Li@amd.com>,
	Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com>,
	Qingqing Zhuo <Qingqing.Zhuo@amd.com>,
	Roman Li <Roman.Li@amd.com>,
	amd-gfx@lists.freedesktop.org,
	Solomon Chiu <Solomon.Chiu@amd.com>,
	Daniel Wheeler <Daniel.Wheeler@amd.com>,
	Aurabindo Pillai <Aurabindo.Pillai@amd.com>,
	Wayne Lin <Wayne.Lin@amd.com>,
	Harry Wentland <Harry.Wentland@amd.com>,
	Agustin Gutierrez <Agustin.Gutierrez@amd.com>,
	Pavle Kotarac <Pavle.Kotarac@amd.com>
Subject: Re: How are the DC patches tested?
Date: Mon, 9 May 2022 16:28:18 +0200	[thread overview]
Message-ID: <5b4a80eb-a14b-7402-fe96-83af10a64c8b@molgen.mpg.de> (raw)
In-Reply-To: <067c7558-8b07-139a-9eb5-e4fe9ce0cbf0@amd.com>

Dear Rodrigo,

Thank you for the quick response.

Am 09.05.22 um 16:15 schrieb Rodrigo Siqueira Jordao:

> On 2022-05-09 10:00, Paul Menzel wrote:

>> Am 09.05.22 um 15:14 schrieb Wheeler, Daniel:
>>
>> […]
>>
>>> This week this patchset was tested on the following systems:
>>>
>>> Lenovo Thinkpad T14s Gen2 with AMD Ryzen 5 5650U, with the following
>>> display types: eDP 1080p 60hz, 4k 60hz  (via USB-C to DP/HDMI), 1440p
>>> 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and
>>> then DP to DVI/VGA)
>>>
>>> Sapphire Pulse RX5700XT with the following display types: 4k 60hz
>>> (via DP/HDMI), 1440p 144hz (via DP/HDMI), 1680*1050 60hz (via DP to
>>> DVI/VGA)
>>>
>>> Reference AMD RX6800 with the following display types: 4k 60hz  (via
>>> DP/HDMI and USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI and
>>> USB-C to DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA)
>>>
>>> Included testing using a Startech DP 1.4 MST hub at 2x 4k 60hz and
>>> DSC via USB-C to DP DSC Hub with 3x 4k 60hz.
>>>
>>> Tested on Ubuntu 22.04 with Kernel Version 5.16, and ChromeOS
>>
>> I am curious, what this means exactly? You clone the Ubuntu Linux 5.16 
>> kernel source, and then apply your patches on top? (Do they even apply?)
> 
> All of these "promotion" patches are tested by using 
> amd-staging-drm-next. In a few words:
> 
> 1. We get the latest code from amd-staging-drm-next;
> 2. We apply these weekly promotion patches on top of it;
> 3. We compile, run unit tests, and run many manual tests (Daniel does 
> that).
> 
> If everything is alright with Daniel's tests, we feel confident to merge 
> these series on top amd-staging-drm-next (we are basically trying to 
> avoid regressions here).
> 
> Anyway, maybe we can rephrase:
> 
>   Tested on Ubuntu 22.04 with Kernel Version 5.16, and ChromeOS
> 
> to
> 
>   Tested on Ubuntu 22.04 and ChromeOS with amd-staging-drm-next + 
> promotion patches.

Yes, that’d be great. Maybe even reference the commit hash from the 
commit on top of *amd-staging-drm-next*.

(Nit: ChromeOS → Chrome OS)

>> The same for Chrome OS. Do you use Chrome OS Flex [1] with the systems 
>> you listed? If not, what Google Chromebooks/-boxes did you test with? 
>> The Linux kernel version is also tied for a device and Chrome OS 
>> release. Please mention those too.

As written, the used Chrome OS version (and devices) would be helpful too.

>> Is it documented somewhere, what tests you run exactly?
> 
> We run IGT tests, some scripts that validate some specific areas, and 
> Daniel has an extensive set of manual tests.

Kind regards,

Paul