From: "吳昊澄 Ricky" <ricky_wu@realtek.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: "arnd@arndb.de" <arnd@arndb.de>,
"ricky_wu@realtek.corp-partner.google.com"
<ricky_wu@realtek.corp-partner.google.com>,
"sashal@kernel.org" <sashal@kernel.org>,
"levinale@google.com" <levinale@google.com>,
"keitasuzuki.park@sslab.ics.keio.ac.jp"
<keitasuzuki.park@sslab.ics.keio.ac.jp>,
"kdlnx@doth.eu" <kdlnx@doth.eu>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"yueherngl@chromium.org" <yueherngl@chromium.org>
Subject: RE: [PATCH] rtsx: pci: fix device aspm state bug
Date: Thu, 21 Jan 2021 07:59:39 +0000 [thread overview]
Message-ID: <5b54d74ea7324bf4b829772cdbc0a742@realtek.com> (raw)
In-Reply-To: <YAkxIYvpGYQfd/bz@kroah.com>
> -----Original Message-----
> From: Greg KH <gregkh@linuxfoundation.org>
> Sent: Thursday, January 21, 2021 3:46 PM
> To: 吳昊澄 Ricky <ricky_wu@realtek.com>
> Cc: arnd@arndb.de; ricky_wu@realtek.corp-partner.google.com;
> sashal@kernel.org; levinale@google.com; keitasuzuki.park@sslab.ics.keio.ac.jp;
> kdlnx@doth.eu; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] rtsx: pci: fix device aspm state bug
>
> On Thu, Jan 21, 2021 at 03:28:58PM +0800, ricky_wu@realtek.com wrote:
> > From: Ricky Wu <ricky_wu@realtek.corp-partner.google.com>
> >
> > changed rtsx_pci_disable_aspm() to rtsx_disable_aspm() make sure
> > pcr->aspm_enabled to sync with aspm state
>
> Can you make this a bit more descriptive?
>
Changed rtsx_pci_disable_aspm() to rtsx_disable_aspm() make sure
pcr->aspm_enabled to sync with aspm state.
rtsx_pci_disable_aspm() this function disable aspm by setting config space directly
did not change value of pcr->aspm_enabled so changed to use rtsx_disable_aspm().
Give initial value to pcr->aspm_enabled by reading config space setting at init_hw().
>
> >
> > BUG=b:175338107
> > TEST=chromeos-kernel-5_4
>
> What are these lines for?
>
> >
> > Signed-off-by: Ricky Wu <ricky_wu@realtek.corp-partner.google.com>
>
> This email does not match your From: address :(
>
> > Change-Id: I4b146dcdaaf2f2a965381c32780b0b110d751258
>
> Please use checkpatch.pl before sending patches to us :(
>
> And why did you send this twice?
>
> thanks,
>
> greg k-h
>
> ------Please consider the environment before printing this e-mail.
next prev parent reply other threads:[~2021-01-21 8:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 7:28 [PATCH] rtsx: pci: fix device aspm state bug ricky_wu
2021-01-21 7:33 ` 吳昊澄 Ricky
2021-01-21 8:07 ` gregkh
2021-01-21 8:15 ` 吳昊澄 Ricky
2021-01-21 8:27 ` gregkh
2021-01-21 10:07 ` 吳昊澄 Ricky
2021-01-21 7:45 ` Greg KH
2021-01-21 7:59 ` 吳昊澄 Ricky [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-01-21 7:28 ricky_wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b54d74ea7324bf4b829772cdbc0a742@realtek.com \
--to=ricky_wu@realtek.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=kdlnx@doth.eu \
--cc=keitasuzuki.park@sslab.ics.keio.ac.jp \
--cc=levinale@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ricky_wu@realtek.corp-partner.google.com \
--cc=sashal@kernel.org \
--cc=yueherngl@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.