From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grygorii Strashko Date: Mon, 5 Mar 2018 13:38:36 -0600 Subject: [U-Boot] [RFC v4 01/15] dma: move dma_ops to dma-uclass.h In-Reply-To: <20180303085917.8293-2-noltari@gmail.com> References: <20180212163858.25601-1-noltari@gmail.com> <20180303085917.8293-1-noltari@gmail.com> <20180303085917.8293-2-noltari@gmail.com> Message-ID: <5b5dff4c-efd1-bdf4-4e82-f7ac31934e00@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: u-boot@lists.denx.de Hi On 03/03/2018 02:59 AM, Álvaro Fernández Rojas wrote: > Move dma_ops to a separate header file, following other uclass implementations. > While doing so, this patch also improves dma_ops documentation. > > Signed-off-by: Álvaro Fernández Rojas > Reviewed-by: Simon Glass > --- > v4: no changes > v3: Introduce changes reported by Simon Glass: > - Improve dma-uclass.h documentation. > - Switch to live tree API. > > drivers/dma/dma-uclass.c | 3 ++- > include/dma-uclass.h | 39 +++++++++++++++++++++++++++++++++++++++ > include/dma.h | 22 ---------------------- > 3 files changed, 41 insertions(+), 23 deletions(-) > create mode 100644 include/dma-uclass.h > I've sent the same comment for prev patch version also. this patch will break build of existing DMA drivers, as the do not have #include . drivers/dma/ti-edma3.c:563:21: error: variable 'ti_edma3_ops' has initializer but incomplete type static const struct dma_ops ti_edma3_ops = { ^~~~~~~ drivers/dma/ti-edma3.c:564:2: error: unknown field 'transfer' specified in initializer .transfer = ti_edma3_transfer, ^ drivers/dma/ti-edma3.c:564:14: warning: excess elements in struct initializer .transfer = ti_edma3_transfer, ^~~~~~~~~~~~~~~~~ drivers/dma/ti-edma3.c:564:14: note: (near initialization for 'ti_edma3_ops') drivers/dma/ti-edma3.c:563:29: error: storage size of 'ti_edma3_ops' isn't known static const struct dma_ops ti_edma3_ops = { ^~~~~~~~~~~~ make[1]: *** [drivers/dma/ti-edma3.o] Error 1 -- regards, -grygorii