From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-wm0-f66.google.com ([74.125.82.66]:33013 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934176AbcKQRay (ORCPT ); Thu, 17 Nov 2016 12:30:54 -0500 Received: by mail-wm0-f66.google.com with SMTP id u144so23298843wmu.0 for ; Thu, 17 Nov 2016 09:30:53 -0800 (PST) From: Erik Stromdahl Subject: Re: [RFC 04/12] ath10k: htc: refactorization To: Michal Kazior References: <1479141222-8493-1-git-send-email-erik.stromdahl@gmail.com> <1479141222-8493-5-git-send-email-erik.stromdahl@gmail.com> Cc: Kalle Valo , linux-wireless , "ath10k@lists.infradead.org" Message-ID: <5b62d41b-7125-f1ce-b09f-29db7572a748@gmail.com> (sfid-20161117_183102_510839_5E3080F4) Date: Thu, 17 Nov 2016 17:32:17 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 11/15/2016 11:19 AM, Michal Kazior wrote: > On 14 November 2016 at 17:33, Erik Stromdahl wrote: >> Code refactorization: >> >> Moved the code for ep 0 in ath10k_htc_rx_completion_handler >> to ath10k_htc_control_rx_complete. >> >> This eases the implementation of SDIO/mbox significantly since >> the ep_rx_complete cb is invoked directly from the SDIO/mbox >> hif layer. >> >> Since the ath10k_htc_control_rx_complete already is present >> (only containing a warning message) there is no reason for not >> using it (instead of having a special case for ep 0 in >> ath10k_htc_rx_completion_handler). > > This should be squashed with Patch 3 since it's inseparable part of > the same refactorization. > > > Michał > Hmm, I don't really see why this is an inseparable part of the previous patch. As far as I see this patch has nothing to do with patch 3, or am I missing anything? Are you really sure they should be squashed? Erik From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-wm0-x241.google.com ([2a00:1450:400c:c09::241]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1c7Pc9-0000ae-HE for ath10k@lists.infradead.org; Thu, 17 Nov 2016 16:32:42 +0000 Received: by mail-wm0-x241.google.com with SMTP id a20so22858411wme.2 for ; Thu, 17 Nov 2016 08:32:20 -0800 (PST) From: Erik Stromdahl Subject: Re: [RFC 04/12] ath10k: htc: refactorization References: <1479141222-8493-1-git-send-email-erik.stromdahl@gmail.com> <1479141222-8493-5-git-send-email-erik.stromdahl@gmail.com> Message-ID: <5b62d41b-7125-f1ce-b09f-29db7572a748@gmail.com> Date: Thu, 17 Nov 2016 17:32:17 +0100 MIME-Version: 1.0 In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Michal Kazior Cc: Kalle Valo , linux-wireless , "ath10k@lists.infradead.org" CgpPbiAxMS8xNS8yMDE2IDExOjE5IEFNLCBNaWNoYWwgS2F6aW9yIHdyb3RlOgo+IE9uIDE0IE5v dmVtYmVyIDIwMTYgYXQgMTc6MzMsIEVyaWsgU3Ryb21kYWhsIDxlcmlrLnN0cm9tZGFobEBnbWFp bC5jb20+IHdyb3RlOgo+PiBDb2RlIHJlZmFjdG9yaXphdGlvbjoKPj4KPj4gTW92ZWQgdGhlIGNv ZGUgZm9yIGVwIDAgaW4gYXRoMTBrX2h0Y19yeF9jb21wbGV0aW9uX2hhbmRsZXIKPj4gdG8gYXRo MTBrX2h0Y19jb250cm9sX3J4X2NvbXBsZXRlLgo+Pgo+PiBUaGlzIGVhc2VzIHRoZSBpbXBsZW1l bnRhdGlvbiBvZiBTRElPL21ib3ggc2lnbmlmaWNhbnRseSBzaW5jZQo+PiB0aGUgZXBfcnhfY29t cGxldGUgY2IgaXMgaW52b2tlZCBkaXJlY3RseSBmcm9tIHRoZSBTRElPL21ib3gKPj4gaGlmIGxh eWVyLgo+Pgo+PiBTaW5jZSB0aGUgYXRoMTBrX2h0Y19jb250cm9sX3J4X2NvbXBsZXRlIGFscmVh ZHkgaXMgcHJlc2VudAo+PiAob25seSBjb250YWluaW5nIGEgd2FybmluZyBtZXNzYWdlKSB0aGVy ZSBpcyBubyByZWFzb24gZm9yIG5vdAo+PiB1c2luZyBpdCAoaW5zdGVhZCBvZiBoYXZpbmcgYSBz cGVjaWFsIGNhc2UgZm9yIGVwIDAgaW4KPj4gYXRoMTBrX2h0Y19yeF9jb21wbGV0aW9uX2hhbmRs ZXIpLgo+IAo+IFRoaXMgc2hvdWxkIGJlIHNxdWFzaGVkIHdpdGggUGF0Y2ggMyBzaW5jZSBpdCdz IGluc2VwYXJhYmxlIHBhcnQgb2YKPiB0aGUgc2FtZSByZWZhY3Rvcml6YXRpb24uCj4gCj4gCj4g TWljaGHFggo+IAoKCkhtbSwgSSBkb24ndCByZWFsbHkgc2VlIHdoeSB0aGlzIGlzIGFuIGluc2Vw YXJhYmxlIHBhcnQgb2YgdGhlIHByZXZpb3VzCnBhdGNoLgoKQXMgZmFyIGFzIEkgc2VlIHRoaXMg cGF0Y2ggaGFzIG5vdGhpbmcgdG8gZG8gd2l0aCBwYXRjaCAzLCBvciBhbSBJCm1pc3NpbmcgYW55 dGhpbmc/CgpBcmUgeW91IHJlYWxseSBzdXJlIHRoZXkgc2hvdWxkIGJlIHNxdWFzaGVkPwoKRXJp awoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYXRoMTBr IG1haWxpbmcgbGlzdAphdGgxMGtAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5m cmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2F0aDEwawo=