From: Jan Beulich <jbeulich@suse.com>
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: xen-devel@lists.xenproject.org, Wei Liu <wl@xen.org>,
Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [Xen-devel] [PATCH v5 1/2] x86/smp: use a dedicated CPU mask in send_IPI_mask
Date: Fri, 28 Feb 2020 13:10:15 +0100 [thread overview]
Message-ID: <5b683f84-ab8a-9968-4e83-385489d5649f@suse.com> (raw)
In-Reply-To: <20200228120753.38036-2-roger.pau@citrix.com>
On 28.02.2020 13:07, Roger Pau Monne wrote:
> Some callers of send_IPI_mask pass the scratch cpumask as the mask
> parameter of send_IPI_mask, so the scratch cpumask cannot be used by
> the function. The following trace has been obtained with a debug patch
> and shows one of those callers:
>
> (XEN) scratch CPU mask already in use by arch/x86/mm.c#_get_page_type+0x1f9/0x1abf
> (XEN) Xen BUG at smp.c:45
> [...]
> (XEN) Xen call trace:
> (XEN) [<ffff82d0802abb53>] R scratch_cpumask+0xd3/0xf9
> (XEN) [<ffff82d0802abc21>] F send_IPI_mask+0x72/0x1ca
> (XEN) [<ffff82d0802ac13e>] F flush_area_mask+0x10c/0x16c
> (XEN) [<ffff82d080296c56>] F arch/x86/mm.c#_get_page_type+0x3ff/0x1abf
> (XEN) [<ffff82d080298324>] F get_page_type+0xe/0x2c
> (XEN) [<ffff82d08038624f>] F pv_set_gdt+0xa1/0x2aa
> (XEN) [<ffff82d08027dfd6>] F arch_set_info_guest+0x1196/0x16ba
> (XEN) [<ffff82d080207a55>] F default_initialise_vcpu+0xc7/0xd4
> (XEN) [<ffff82d08027e55b>] F arch_initialise_vcpu+0x61/0xcd
> (XEN) [<ffff82d080207e78>] F do_vcpu_op+0x219/0x690
> (XEN) [<ffff82d08038be16>] F pv_hypercall+0x2f6/0x593
> (XEN) [<ffff82d080396432>] F lstar_enter+0x112/0x120
>
> _get_page_type will use the scratch cpumask to call flush_tlb_mask,
> which in turn calls send_IPI_mask.
>
> Fix this by using a dedicated per CPU cpumask in send_IPI_mask.
>
> Fixes: 5500d265a2a8 ('x86/smp: use APIC ALLBUT destination shorthand when possible')
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2020-02-28 12:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-28 12:07 [Xen-devel] [PATCH v5 0/2] x86: scratch cpumask fixes/improvement Roger Pau Monne
2020-02-28 12:07 ` [Xen-devel] [PATCH v5 1/2] x86/smp: use a dedicated CPU mask in send_IPI_mask Roger Pau Monne
2020-02-28 12:10 ` Jan Beulich [this message]
2020-02-28 12:07 ` [Xen-devel] [PATCH v5 2/2] x86: add accessors for scratch cpu mask Roger Pau Monne
2020-02-28 12:42 ` Jan Beulich
[not found] ` <20200311153437.GC24458@Air-de-Roger.citrite.net>
[not found] ` <cd51c415-dfd4-42c4-caf9-2a19ddeb8b3f@suse.com>
[not found] ` <20200311155118.GD24458@Air-de-Roger.citrite.net>
[not found] ` <31a2da09-c82d-157f-3ca2-bbea45d9bcd0@suse.com>
2020-03-12 10:38 ` Roger Pau Monné
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b683f84-ab8a-9968-4e83-385489d5649f@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.