From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6B921FA3742 for ; Thu, 27 Oct 2022 11:09:31 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 74C7D3060; Thu, 27 Oct 2022 13:08:39 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 74C7D3060 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1666868969; bh=VfVKyp1Dxs5WMcZ0NytyalV/nlR49XyBEGLjnKFSn78=; h=Date:Subject:To:References:From:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Te+EoqCcQGJCdy+6HK1Wpe1jV0HH1/pSzqA+DwPGuUhDmErrq2t09/IpE1HvUn0Fr zDLZKZIqjhL0U8gouN5PZTIccdMnQiBxN5F/liflt1hN3P0AaplLgWZEprDpLl36pA VSNU18DCfpWdUqAcI7iQODoYeJlu1RHx3XIqG+5w= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 1764EF8025A; Thu, 27 Oct 2022 13:08:39 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 370D2F8025E; Thu, 27 Oct 2022 13:08:37 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id B0CB5F8016C for ; Thu, 27 Oct 2022 13:08:32 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz B0CB5F8016C Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Q0Y6yvzc" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666868914; x=1698404914; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=VfVKyp1Dxs5WMcZ0NytyalV/nlR49XyBEGLjnKFSn78=; b=Q0Y6yvzcrBMyHMcEaMTzxmFz5S1EIoBwyRSq/8GgFnhKeiiPok/d/tNf kJgKwO5lmx8a/4o4gE0w/HhZn21+hQPqBFOMw8uQcLkNzI3A25gumlprB OtqJPmfjtXdZVhiQGHTBx/4ig4ksI2IqJVlzbelGeiuXgGFRyj9F5FRcb TML+8P+ln+jPBCNTL/X+lYnzTa+h4i8Ow1aJV/9ZpxHKm9sE/W/9bIBNG C0PgezY8oVhhnsxaaR20MNlvltbDLIeaqmzLc+cZVswK1kZxxAcZDvGg9 0508eFstui2eFoOxbr72gucH2X+OboT/oLt/FwFzlN5vMlnH/6PPP/rzG Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10512"; a="291497109" X-IronPort-AV: E=Sophos;i="5.95,217,1661842800"; d="scan'208";a="291497109" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2022 04:08:30 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10512"; a="665642358" X-IronPort-AV: E=Sophos;i="5.95,217,1661842800"; d="scan'208";a="665642358" Received: from aslawinx-mobl.ger.corp.intel.com (HELO [10.99.241.18]) ([10.99.241.18]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2022 04:08:28 -0700 Message-ID: <5b7879f6-a15b-919a-842b-42617934aea3@linux.intel.com> Date: Thu, 27 Oct 2022 13:08:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH v3 3/9] ALSA: hda: Introduce snd_hdac_stream_wait_drsm() Content-Language: en-US To: Takashi Iwai References: <20221027082331.1561740-1-cezary.rojewski@intel.com> <20221027082331.1561740-4-cezary.rojewski@intel.com> <874jvpo9by.wl-tiwai@suse.de> <3977c2b3-ead3-3904-820a-d602aa04c51b@linux.intel.com> <87zgdhmsqa.wl-tiwai@suse.de> From: =?UTF-8?Q?Amadeusz_S=c5=82awi=c5=84ski?= In-Reply-To: <87zgdhmsqa.wl-tiwai@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Cc: Cezary Rojewski , alsa-devel@alsa-project.org, pierre-louis.bossart@linux.intel.com, tiwai@suse.com, hdegoede@redhat.com, broonie@kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 10/27/2022 1:05 PM, Takashi Iwai wrote: > On Thu, 27 Oct 2022 12:29:35 +0200, > Amadeusz Sławiński wrote: >> >> On 10/27/2022 12:21 PM, Takashi Iwai wrote: >>> On Thu, 27 Oct 2022 10:23:25 +0200, >>> Cezary Rojewski wrote: >>>> --- a/sound/hda/hdac_stream.c >>>> +++ b/sound/hda/hdac_stream.c >>>> @@ -821,6 +821,27 @@ void snd_hdac_stream_drsm_enable(struct hdac_bus *bus, >>>> } >>>> EXPORT_SYMBOL_GPL(snd_hdac_stream_drsm_enable); >>>> +/* >>>> + * snd_hdac_stream_wait_drsm - wait for HW to clear RSM for a stream >>>> + * @azx_dev: HD-audio core stream to await RSM for >>>> + * >>>> + * Returns 0 on success and -ETIMEDOUT upon a timeout. >>>> + */ >>>> +int snd_hdac_stream_wait_drsm(struct hdac_stream *azx_dev) >>>> +{ >>>> + struct hdac_bus *bus = azx_dev->bus; >>>> + u32 mask, reg; >>>> + int ret; >>>> + >>>> + mask = 1 << azx_dev->index; >>>> + >>>> + ret = readb_poll_timeout(bus->drsmcap + AZX_REG_DRSM_CTL, reg, !(reg & mask), 250, 2000); >>> >>> Remember that HD-audio bus doesn't always allow readb(). Tegra >>> requires the aligned access, for example. >>> >> >> The readb_poll_timeout macro was updated to take care of that, >> https://lore.kernel.org/all/20221007084856.1638302-1-amadeuszx.slawinski@linux.intel.com/ >> so it should be fine? > > This patch doesn't use that macro... > Ah... right, sorry for confusion, I looked at diff part instead of macro name.