From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1CCFC433EF for ; Wed, 2 Mar 2022 02:09:40 +0000 (UTC) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D74F540696; Wed, 2 Mar 2022 03:09:39 +0100 (CET) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id A6A7340040 for ; Wed, 2 Mar 2022 03:09:38 +0100 (CET) Received: from kwepemi100020.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4K7cwM1BNDzdfms; Wed, 2 Mar 2022 10:08:19 +0800 (CST) Received: from kwepemm600004.china.huawei.com (7.193.23.242) by kwepemi100020.china.huawei.com (7.221.188.48) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.18; Wed, 2 Mar 2022 10:09:36 +0800 Received: from [10.67.103.231] (10.67.103.231) by kwepemm600004.china.huawei.com (7.193.23.242) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Wed, 2 Mar 2022 10:09:35 +0800 Message-ID: <5b829b45-220b-daa2-19e4-3b3fc746d152@huawei.com> Date: Wed, 2 Mar 2022 10:09:30 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH 2/6] net/hns3: fix inconsistent enabled RSS behavior To: Ferruh Yigit , "Min Hu (Connor)" , , , Andrew Rybchenko , Qi Zhang , Ori Kam CC: Olivier Matz , Ajit Khaparde , "jerinj@marvell.com" , Stephen Hemminger , Viacheslav Ovsiienko , huangdaode References: <20220228032146.37407-1-humin29@huawei.com> <20220228032146.37407-3-humin29@huawei.com> From: "lihuisong (C)" In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.231] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemm600004.china.huawei.com (7.193.23.242) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 在 2022/3/1 0:42, Ferruh Yigit 写道: > On 2/28/2022 3:21 AM, Min Hu (Connor) wrote: >> From: Huisong Li >> >> RSS will not be enabled if the RTE_ETH_MQ_RX_RSS_FLAG isn't be set in >> dev_configure phase. However, if this flag isn't set, RSS can be enabled >> through the ethdev ops and rte_flow API. This behavior is contrary to >> each >> other. >> >> Fixes: c37ca66f2b27 ("net/hns3: support RSS") >> Cc: stable@dpdk.org >> >> Signed-off-by: Huisong Li > > > Hi Huisong, Connor, > > Let's get a little more feedback for this patch, cc'ed more people. > > > To enable RSS, multi queue mode should be set to > 'RTE_ETH_MQ_RX_RSS_FLAG'. > > But I wonder if it is required to configure RSS via flow API, I do not know the original purpose of adding the RSS configuration in flow API. However, as far as I know, the hash algorithm can be configured via this API, but not via ethdev ops API. > and if other PMDs check this configuration for flow API? Some PMDs already have similar check in RSS releated ops or rte_flow API. For example, hinic, axbge, bnxt, cnxk, otx2, and ena. > .