From: Jens Axboe <axboe@kernel.dk>
To: Peng Hao <flyingpenghao@gmail.com>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block/elevator: handle possible null pointer
Date: Tue, 21 Dec 2021 08:26:26 -0700 [thread overview]
Message-ID: <5b848910-0972-dfa7-e056-4467e5484a6e@kernel.dk> (raw)
In-Reply-To: <20211221081042.78799-1-flyingpeng@tencent.com>
On 12/21/21 1:10 AM, Peng Hao wrote:
> There is a check for q->tag_set in the front of elevator_get_default,
> and there should be a check here too.
I always get suspicious when I see patches like that. Is the other check
valid? Why does it need to get checked? There's really no meat on the
bone in this commit message.
--
Jens Axboe
prev parent reply other threads:[~2021-12-21 15:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-21 8:10 [PATCH] block/elevator: handle possible null pointer Peng Hao
2021-12-21 15:26 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b848910-0972-dfa7-e056-4467e5484a6e@kernel.dk \
--to=axboe@kernel.dk \
--cc=flyingpenghao@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.