From: Rob Herring <robh@kernel.org>
To: "Raju P.L.S.S.S.N" <rplsssn@codeaurora.org>
Cc: andy.gross@linaro.org, david.brown@linaro.org,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
linux-pm@vger.kernel.org, rnayak@codeaurora.org,
bjorn.andersson@linaro.org, linux-kernel@vger.kernel.org,
lorenzo.pieralisi@arm.com, rafael@kernel.org, drake@endlessm.com,
sboyd@kernel.org, evgreen@chromium.org, dianders@chromium.org,
mka@chromium.org, ilina@codeaurora.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH RFC 2/6] dt-bindings: introduce System PM bindings for Qualcomm SoCs
Date: Tue, 4 Sep 2018 08:14:16 -0500 [thread overview]
Message-ID: <5b8e8a7d.1c69fb81.f8a73.b384@mx.google.com> (raw)
In-Reply-To: <1535141188-29731-3-git-send-email-rplsssn@codeaurora.org>
On Sat, Aug 25, 2018 at 01:36:24AM +0530, Raju P.L.S.S.S.N wrote:
> Add device binding documentation for Qualcomm Technology Inc's System PM
> driver. The driver is used for managing system sleep activities that are
> required when application processor is going to deepest low power mode.
>
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Raju P.L.S.S.S.N <rplsssn@codeaurora.org>
> ---
> .../devicetree/bindings/soc/qcom/system_pm.txt | 28 ++++++++++++++++++++++
> 1 file changed, 28 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/qcom/system_pm.txt
>
> diff --git a/Documentation/devicetree/bindings/soc/qcom/system_pm.txt b/Documentation/devicetree/bindings/soc/qcom/system_pm.txt
> new file mode 100644
> index 0000000..0915760
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/qcom/system_pm.txt
> @@ -0,0 +1,28 @@
> +System PM
> +---------
> +
> +System PM device handles the tasks that need to be performed during application
> +processor deeper low power mode entry for QCOM SoCs which have hardened IP blocks
> +combinedly called as RPMH (Resource Power Manager Hardened) for shared resource
> +management. System PM is a client of APPS_RSC. Flushing the buffered requests to
> +TCSs in RSC and programming the wakeup timer in PDC for timer based wakeup are
> +handled by this device.
> +
> +The bindings for System PM is specified in the RSC section in devicetree.
> +
> +Properties:
> +- compatible:
> + Usage: required
> + Value type: <string>
> + Definition: must be "qcom,system-pm".
h/w devices have some sort of resources and this has nothing. Looks like
you are just using DT to instantiate some sort of virtual driver. Don't
do that.
Rob
next prev parent reply other threads:[~2018-09-04 13:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-24 20:06 [PATCH RFC 0/6] drivers: qcom: enable system low power modes for SDM845 Raju P.L.S.S.S.N
2018-08-24 20:06 ` [PATCH RFC 1/6] drivers: qcom: system_pm: add system PM client for RPMH based SoCs Raju P.L.S.S.S.N
2018-08-24 20:06 ` [PATCH RFC 2/6] dt-bindings: introduce System PM bindings for Qualcomm SoCs Raju P.L.S.S.S.N
2018-09-04 13:14 ` Rob Herring [this message]
2018-08-24 20:06 ` [PATCH RFC 3/6] drivers: qcom: system_pm: Add power management ops Raju P.L.S.S.S.N
2018-08-24 20:06 ` [PATCH RFC 4/6] drivers: qcom: system_pm: program next wakeup to PDC timer Raju P.L.S.S.S.N
2018-08-24 20:06 ` [PATCH RFC 5/6] drivers: qcom: rpmh: force flush new sleep/wake requests during suspend Raju P.L.S.S.S.N
2018-08-24 20:06 ` [PATCH RFC 6/6] drivers: soc: system_pm: Add suspend notifier Raju P.L.S.S.S.N
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b8e8a7d.1c69fb81.f8a73.b384@mx.google.com \
--to=robh@kernel.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=drake@endlessm.com \
--cc=evgreen@chromium.org \
--cc=ilina@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mka@chromium.org \
--cc=rafael@kernel.org \
--cc=rnayak@codeaurora.org \
--cc=rplsssn@codeaurora.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.