From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B547C43334 for ; Tue, 26 Jul 2022 09:54:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238527AbiGZJyd (ORCPT ); Tue, 26 Jul 2022 05:54:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55332 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238509AbiGZJyb (ORCPT ); Tue, 26 Jul 2022 05:54:31 -0400 Received: from relay02.th.seeweb.it (relay02.th.seeweb.it [IPv6:2001:4b7a:2000:18::163]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D5C62F64F for ; Tue, 26 Jul 2022 02:54:29 -0700 (PDT) Received: from [192.168.1.101] (abxj79.neoplus.adsl.tpnet.pl [83.9.3.79]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by m-r1.th.seeweb.it (Postfix) with ESMTPSA id A4639201DF; Tue, 26 Jul 2022 11:54:25 +0200 (CEST) Message-ID: <5b938039-0a73-90e5-47c1-4d976d278273@somainline.org> Date: Tue, 26 Jul 2022 11:54:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v3 2/3] dt-bindings: clock: add SM6375 QCOM global clock bindings Content-Language: en-US To: Krzysztof Kozlowski , ~postmarketos/upstreaming@lists.sr.ht Cc: martin.botka@somainline.org, angelogioacchino.delregno@somainline.org, marijn.suijten@somainline.org, jamipkettunen@somainline.org, Andy Gross , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220723100135.91784-1-konrad.dybcio@somainline.org> <20220723100135.91784-2-konrad.dybcio@somainline.org> <27154a09-d79b-7814-22ec-c84496596abc@linaro.org> <6a33d026-9f30-358e-8498-dbe315fccc5b@somainline.org> From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 26.07.2022 11:52, Krzysztof Kozlowski wrote: > On 23/07/2022 22:56, Konrad Dybcio wrote: >> >> >> On 23.07.2022 19:46, Krzysztof Kozlowski wrote: >>> On 23/07/2022 12:01, Konrad Dybcio wrote: >>>> Add device tree bindings for global clock controller for SM6375 SoCs. >>>> >>>> Signed-off-by: Konrad Dybcio >>>> --- >>>> Changes since v2: >>>> - reference qcom,gcc.yaml >>>> >>>> .../bindings/clock/qcom,sm6375-gcc.yaml | 48 ++++ >>>> include/dt-bindings/clock/qcom,sm6375-gcc.h | 234 ++++++++++++++++++ >>>> 2 files changed, 282 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/clock/qcom,sm6375-gcc.yaml >>>> create mode 100644 include/dt-bindings/clock/qcom,sm6375-gcc.h >>>> >>>> diff --git a/Documentation/devicetree/bindings/clock/qcom,sm6375-gcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm6375-gcc.yaml >>>> new file mode 100644 >>>> index 000000000000..fb1c36888d18 >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/clock/qcom,sm6375-gcc.yaml >>>> @@ -0,0 +1,48 @@ >>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>>> +%YAML 1.2 >>>> +--- >>>> +$id: http://devicetree.org/schemas/clock/qcom,sm6375-gcc.yaml# >>>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>>> + >>>> +title: Qualcomm Global Clock & Reset Controller Binding for SM6375 >>>> + >>>> +maintainers: >>>> + - Konrad Dybcio >>>> + >>>> +description: | >>>> + Qualcomm global clock control module which supports the clocks, resets and >>>> + power domains on SM6375 >>>> + >>>> + See also: >>>> + - dt-bindings/clock/qcom,sm6375-gcc.h >>>> + >>>> +allOf: >>>> + - $ref: qcom,gcc.yaml# >>>> + >>>> +properties: >>>> + compatible: >>>> + const: qcom,sm6375-gcc >>>> + >>>> + clocks: >>>> + items: >>>> + - description: Board XO source >>>> + - description: Board XO Active-Only source >>>> + - description: Sleep clock source >>> >>> What happened to clock-names? >>> >>>> + >>> >>> I would assume these are required for the clock controller... and they >>> were before, so what happened? >> I dropped them in v2, as with switching the .c driver to use the >> index matching, they are no longer used. > > OK, but what about clocks as required? Why aren't these now required? Ohhhh right, I had a false impression that they were set in qcom,gcc.yaml. Will fix it. Konrad > > > Best regards, > Krzysztof