All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>,
	"Jyri Sarha" <jsarha@ti.com>
Cc: praneeth@ti.com, Daniel Vetter <daniel.vetter@ffwll.ch>,
	dri-devel@lists.freedesktop.org, peter.ujfalusi@ti.com,
	laurent.pinchart@ideasonboard.com, sam@ravnborg.org
Subject: Re: [PATCH] drm/tidss: dispc: Rewrite naive plane positioning code
Date: Tue, 11 Feb 2020 11:11:34 +0200	[thread overview]
Message-ID: <5b985430-3659-68be-4834-9cc2de9daf5e@ti.com> (raw)
In-Reply-To: <20200210160336.GT13686@intel.com>

Hi Ville,

On 10/02/2020 18:03, Ville Syrjälä wrote:

> The usual approach we follow in i915 for things that affect more
> than one plane is is to collect that state into the crtc state.
> That way we get to remember it for the planes that are not part
> of the current commit.
> 
> And when we have state that affects more than one crtc that again
> get collected up one level up in what we call global state
> (basically drm_private_obj with less heavy handed locking scheme).

I'm confused. Don't we always have the full state available? Why do you need to store state into 
custom crtc-state?

Here we are interested in the x, y and z positions of all the planes on a crtc. Creating a custom 
state object and duplicating that information there seems a bit silly, as surely that information is 
tracked by DRM?

Or what am I missing here...

  Tomi

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2020-02-11  9:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-07 18:18 [PATCH] drm/tidss: dispc: Rewrite naive plane positioning code Jyri Sarha
2020-02-07 18:26 ` Jyri Sarha
2020-02-07 18:45   ` Ville Syrjälä
2020-02-09 12:50     ` Jyri Sarha
2020-02-10 13:21       ` Ville Syrjälä
2020-02-10 15:44         ` Jyri Sarha
2020-02-10 16:03           ` Ville Syrjälä
2020-02-11  9:11             ` Tomi Valkeinen [this message]
2020-02-11 13:00               ` Ville Syrjälä
2020-02-11 15:40                 ` Daniel Vetter
2020-02-11 15:41                   ` Daniel Vetter
2020-02-12 13:51                     ` Jyri Sarha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5b985430-3659-68be-4834-9cc2de9daf5e@ti.com \
    --to=tomi.valkeinen@ti.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jsarha@ti.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=peter.ujfalusi@ti.com \
    --cc=praneeth@ti.com \
    --cc=sam@ravnborg.org \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.