All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bean Huo <huobean@gmail.com>
To: Asutosh Das <asutoshd@codeaurora.org>
Cc: alim.akhtar@samsung.com, avri.altman@wdc.com, jejb@linux.ibm.com,
	martin.petersen@oracle.com, stanley.chu@mediatek.com,
	beanhuo@micron.com, bvanassche@acm.org, tomas.winkler@intel.com,
	cang@codeaurora.org, linux-scsi@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] scsi: ufs: remove several redundant goto statements
Date: Fri, 14 Aug 2020 11:52:29 +0200	[thread overview]
Message-ID: <5ba762dc8d3879e49b1636413cba795f60ea696a.camel@gmail.com> (raw)
In-Reply-To: <20200813155203.GA25655@asutoshd-linux1.qualcomm.com>

On Thu, 2020-08-13 at 08:52 -0700, Asutosh Das wrote:
> > @@ -8036,7 +8021,6 @@ static int ufshcd_set_dev_pwr_mode(struct
> > ufs_hba *hba,
> >        }
> > 
> >        cmd[4] = pwr_mode << 4;
> > -
> 
> Change LGTM;
> Nit-pick, line removed here by mistake, perhaps?

Hi Asutosh
thanks for your review. I add that empty line back, you can check.

thanks,
Bean


      reply	other threads:[~2020-08-14  9:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-12 14:37 [PATCH v2 0/2] make UFS dev_cmd more readable Bean Huo
2020-08-12 14:37 ` [PATCH v2 1/2] scsi: ufs: change ufshcd_comp_devman_upiu() to ufshcd_compose_devman_upiu() Bean Huo
2020-08-13 15:55   ` Asutosh Das
2020-08-14  9:29     ` Can Guo
2020-08-12 14:37 ` [PATCH v2 2/2] scsi: ufs: remove several redundant goto statements Bean Huo
2020-08-13 15:52   ` Asutosh Das
2020-08-14  9:52     ` Bean Huo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5ba762dc8d3879e49b1636413cba795f60ea696a.camel@gmail.com \
    --to=huobean@gmail.com \
    --cc=alim.akhtar@samsung.com \
    --cc=asutoshd@codeaurora.org \
    --cc=avri.altman@wdc.com \
    --cc=beanhuo@micron.com \
    --cc=bvanassche@acm.org \
    --cc=cang@codeaurora.org \
    --cc=jejb@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=stanley.chu@mediatek.com \
    --cc=tomas.winkler@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.