All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: Maxim Mikityanskiy <maximmi@nvidia.com>,
	Stephen Hemminger <stephen@networkplumber.org>
Cc: Tariq Toukan <tariqt@nvidia.com>,
	Boris Pismenny <borisp@nvidia.com>,
	netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH iproute2-next] ss: Show zerocopy sendfile status of TLS sockets
Date: Tue, 31 May 2022 08:22:30 -0600	[thread overview]
Message-ID: <5bb06a88-ff87-2bcf-b467-a30a5566dc7b@gmail.com> (raw)
In-Reply-To: <f549f350-5d29-88af-f551-08aab261ec38@nvidia.com>

On 5/31/22 1:00 AM, Maxim Mikityanskiy wrote:
> On 2022-05-30 19:24, Stephen Hemminger wrote:
>> On Mon, 30 May 2022 17:14:38 +0300
>> Maxim Mikityanskiy <maximmi@nvidia.com> wrote:
>>
>>> +static void tcp_tls_zc_sendfile(struct rtattr *attr)
>>> +{
>>> +    out(" zerocopy_sendfile: %s", attr ? "active" : "inactive");
>>> +}
>>
>> I would prefer a shorter output just adding "zc_sendfile" if present
>> and nothing
>> if not present. That is how other optns like ecn, ecnseen, etc work.
> 
> I see David merged the patch as is to net-next, despite the comments.
> Should I still make the requested change? If yes, should I submit it as
> a v2 or as a next patch on top of this one?
> 

The patch was merged before the comments. Given that you should be
sending a patch against -next branch that addresses the comments.

  reply	other threads:[~2022-05-31 14:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-30 14:14 [PATCH iproute2-next] ss: Show zerocopy sendfile status of TLS sockets Maxim Mikityanskiy
2022-05-30 16:24 ` Stephen Hemminger
2022-05-31  7:00   ` Maxim Mikityanskiy
2022-05-31 14:22     ` David Ahern [this message]
2022-05-30 18:17 ` Jakub Kicinski
2022-05-31 19:18   ` Jakub Kicinski
2022-05-31 19:20     ` Jakub Kicinski
2022-06-01  8:58     ` Maxim Mikityanskiy
2022-06-01 15:42       ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5bb06a88-ff87-2bcf-b467-a30a5566dc7b@gmail.com \
    --to=dsahern@gmail.com \
    --cc=borisp@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=maximmi@nvidia.com \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    --cc=tariqt@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.