All of lore.kernel.org
 help / color / mirror / Atom feed
From: Philipp Zabel <p.zabel@pengutronix.de>
To: Ezequiel Garcia <ezequiel@collabora.com>,
	linux-media@vger.kernel.org, Hans Verkuil <hverkuil@xs4all.nl>
Cc: kernel@collabora.com,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Steve Longerbeam <slongerbeam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>
Subject: Re: [PATCH v2 3/3] media: imx: Clean capture unregister
Date: Tue, 05 Jan 2021 10:33:20 +0100	[thread overview]
Message-ID: <5bb16cf701768c68d38dad89c6f3c5cbbec9a02a.camel@pengutronix.de> (raw)
In-Reply-To: <20210104203441.168778-3-ezequiel@collabora.com>

On Mon, 2021-01-04 at 17:34 -0300, Ezequiel Garcia wrote:
> No locking is needed to call video_unregister_device(). Drop it.
> 
> Also, drop the superfluous video_is_registered() call, which is
> done by video_unregister_device(), and re-order media_entity_cleanup()
> and video_unregister_device() calls.
> 
> Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>

Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>

regards
Philipp

  reply	other threads:[~2021-01-05  9:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-04 20:34 [PATCH v2 1/3] media: imx: Unregister csc/scaler only if registered Ezequiel Garcia
2021-01-04 20:34 ` [PATCH v2 2/3] media: imx: Fix csc/scaler unregister Ezequiel Garcia
2021-01-04 20:34 ` [PATCH v2 3/3] media: imx: Clean capture unregister Ezequiel Garcia
2021-01-05  9:33   ` Philipp Zabel [this message]
2021-01-05  9:33 ` [PATCH v2 1/3] media: imx: Unregister csc/scaler only if registered Philipp Zabel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5bb16cf701768c68d38dad89c6f3c5cbbec9a02a.camel@pengutronix.de \
    --to=p.zabel@pengutronix.de \
    --cc=ezequiel@collabora.com \
    --cc=hverkuil@xs4all.nl \
    --cc=kernel@collabora.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-imx@nxp.com \
    --cc=linux-media@vger.kernel.org \
    --cc=slongerbeam@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.