All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sinan Kaya <okaya@codeaurora.org>
To: Govindarajulu Varadarajan <gvaradar@cisco.com>,
	benve@cisco.com, bhelgaas@google.com, linux-pci@vger.kernel.org,
	linux-kernel@vger.kernel.org, jlbec@evilplan.org, hch@lst.de,
	mingo@redhat.com, peterz@infradead.org
Subject: Re: [PATCH 1/4] pci: introduce __pci_walk_bus for caller with pci_bus_sem held
Date: Thu, 28 Sep 2017 12:12:19 -0400	[thread overview]
Message-ID: <5bbeefd2-a409-168c-b596-bcaa29a54eb7@codeaurora.org> (raw)
In-Reply-To: <20170927214220.41216-2-gvaradar@cisco.com>

On 9/27/2017 5:42 PM, Govindarajulu Varadarajan wrote:
> +void __pci_walk_bus(struct pci_bus *top, int (*cb)(struct pci_dev *, void *),
> +		    void *userdata);

pci_walk_bus_locked would be a better name as you are assuming that caller is
holding the lock. 

-- 
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.

  reply	other threads:[~2017-09-28 16:12 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-27 21:42 [PATCH 0/4] pci aer: fix deadlock in do_recovery Govindarajulu Varadarajan
2017-09-27 21:42 ` [PATCH 1/4] pci: introduce __pci_walk_bus for caller with pci_bus_sem held Govindarajulu Varadarajan
2017-09-28 16:12   ` Sinan Kaya [this message]
2017-09-28 23:52     ` Govindarajulu Varadarajan
2017-09-27 21:42 ` [PATCH 2/4] pci: code refactor pci_bus_lock/unlock/trylock Govindarajulu Varadarajan
2017-09-27 21:42 ` [PATCH 3/4] pci aer: fix deadlock in do_recovery Govindarajulu Varadarajan
2017-09-28 16:47   ` Sinan Kaya
2017-09-28 23:46     ` Govindarajulu Varadarajan
2017-09-29 13:32       ` Sinan Kaya
2017-09-30  6:00         ` Govindarajulu Varadarajan
2017-09-27 21:42 ` [PATCH 4/4] lockdep: make MAX_LOCK_DEPTH configurable from Kconfig Govindarajulu Varadarajan
2017-09-28  9:26   ` Peter Zijlstra
2017-09-28 23:51     ` Govindarajulu Varadarajan
2017-09-29 16:23       ` Bjorn Helgaas
2017-09-30  6:03         ` Govindarajulu Varadarajan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5bbeefd2-a409-168c-b596-bcaa29a54eb7@codeaurora.org \
    --to=okaya@codeaurora.org \
    --cc=benve@cisco.com \
    --cc=bhelgaas@google.com \
    --cc=gvaradar@cisco.com \
    --cc=hch@lst.de \
    --cc=jlbec@evilplan.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.