From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4772AC433EF for ; Wed, 20 Jul 2022 01:58:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235626AbiGTB6b (ORCPT ); Tue, 19 Jul 2022 21:58:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53124 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238537AbiGTB6a (ORCPT ); Tue, 19 Jul 2022 21:58:30 -0400 Received: from out30-56.freemail.mail.aliyun.com (out30-56.freemail.mail.aliyun.com [115.124.30.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 056D24F18C; Tue, 19 Jul 2022 18:58:28 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R191e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046049;MF=chengyou@linux.alibaba.com;NM=1;PH=DS;RN=8;SR=0;TI=SMTPD_---0VJuk2GC_1658282304; Received: from 30.43.104.155(mailfrom:chengyou@linux.alibaba.com fp:SMTPD_---0VJuk2GC_1658282304) by smtp.aliyun-inc.com; Wed, 20 Jul 2022 09:58:25 +0800 Message-ID: <5bcd437f-92a4-1c04-796c-41559dd2823a@linux.alibaba.com> Date: Wed, 20 Jul 2022 09:58:24 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 1/2] RDMA/erdma: Use the bitmap API to allocate bitmaps Content-Language: en-US To: Christophe JAILLET , Jason Gunthorpe Cc: Kai Shen , Dan Carpenter , Leon Romanovsky , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-rdma@vger.kernel.org References: <2764b6e204b32ef8c198a5efaf6c6bc4119f7665.1657301795.git.christophe.jaillet@wanadoo.fr> <670c57a2-6432-80c9-cdc0-496d836d7bf0@linux.alibaba.com> <20220712090110.GL2338@kadam> <20220719125434.GG5049@ziepe.ca> <20220719130125.GB2316@kadam> <7075158a-64c1-8f69-7de1-9a60ee914f05@wanadoo.fr> From: Cheng Xu In-Reply-To: <7075158a-64c1-8f69-7de1-9a60ee914f05@wanadoo.fr> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On 7/19/22 11:36 PM, Christophe JAILLET wrote: > Le 19/07/2022 à 15:01, Dan Carpenter a écrit : >> On Tue, Jul 19, 2022 at 09:54:34AM -0300, Jason Gunthorpe wrote: >>> On Tue, Jul 12, 2022 at 12:01:10PM +0300, Dan Carpenter wrote: >>> >>>> Best not to use any auto-formatting tools.  They are all bad. >>> >>> Have you tried clang-format? I wouldn't call it bad.. >> >> I prefered Christophe's formatting to clang's.  ;) >> >> regards, >> dan carpenter >> >> > > Hi, > > (some other files in the same directory also have some checkpatch warning/error) I just double checked the checkpatch results, Two type warnings reported: - WARNING: Missing commit description - Add an appropriate one (for patch 0001) - WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? (for almost all patches except 0001/0011) For the first warning, the change is very simple: add erdma's rdma_driver_id definition, I think the commit title can describe all things, and is enough. For the second warning, I think it is OK for new files before MAINTAINERS being updated in patch 0011. Thanks, Cheng Xu