From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1516EC10F0E for ; Fri, 12 Apr 2019 10:32:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CADB92171F for ; Fri, 12 Apr 2019 10:32:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="mkrryVkZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727321AbfDLKcZ (ORCPT ); Fri, 12 Apr 2019 06:32:25 -0400 Received: from lelv0142.ext.ti.com ([198.47.23.249]:48596 "EHLO lelv0142.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726327AbfDLKcZ (ORCPT ); Fri, 12 Apr 2019 06:32:25 -0400 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id x3CAWEAX051748; Fri, 12 Apr 2019 05:32:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1555065134; bh=/xfSaZ1QRl+hHQhdhFBw9Ok1kkvfuJN2/FbjpR69m2w=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=mkrryVkZpE4l27xD5xBLVtI2xG3WQ9SYfDcGP/DCB/QkWsFlZpf7oCaONDNJl88tn wmkJwP61gbNw89UAbcHJKBsnYOEXWBpha0hXentMb9hQ66Kx3RCuKKCHz6bYEULaiQ 2h2rb8zkId/J/Ystb8pcOeL1xmdk3fu3HygemauM= Received: from DLEE115.ent.ti.com (dlee115.ent.ti.com [157.170.170.26]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x3CAWECt070241 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 12 Apr 2019 05:32:14 -0500 Received: from DLEE102.ent.ti.com (157.170.170.32) by DLEE115.ent.ti.com (157.170.170.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Fri, 12 Apr 2019 05:32:14 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE102.ent.ti.com (157.170.170.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Fri, 12 Apr 2019 05:32:14 -0500 Received: from [172.24.190.172] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id x3CAWBFZ056757; Fri, 12 Apr 2019 05:32:12 -0500 Subject: Re: [PATCH v4 6/6] usb: ohci-da8xx: drop the vbus GPIO To: Bartosz Golaszewski , Kevin Hilman , Alan Stern , Greg Kroah-Hartman CC: , , , Bartosz Golaszewski References: <20190411093024.23555-1-brgl@bgdev.pl> <20190411093024.23555-7-brgl@bgdev.pl> From: Sekhar Nori Message-ID: <5bd92c5a-86e4-6779-6035-f9a0b33917e9@ti.com> Date: Fri, 12 Apr 2019 16:02:11 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190411093024.23555-7-brgl@bgdev.pl> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Bartosz, On 11/04/19 3:00 PM, Bartosz Golaszewski wrote: > @@ -209,9 +197,7 @@ static irqreturn_t ohci_da8xx_oc_thread(int irq, void *data) > int ret; > > if (gpiod_get_value_cansleep(da8xx_ohci->oc_gpio)) { > - if (da8xx_ohci->vbus_gpio) { > - gpiod_set_value_cansleep(da8xx_ohci->vbus_gpio, 0); > - } else if (da8xx_ohci->vbus_reg) { > + if (da8xx_ohci->vbus_reg) { > ret = regulator_disable(da8xx_ohci->vbus_reg); > if (ret) > dev_err(dev, You can now reduce a level of indentation here by doing if (gpiod_get_value_cansleep(da8xx_ohci->oc_gpio) && da8xx_ohci->vbus_reg) { ret = regulator_disable(da8xx_ohci->vbus_reg); if (ret) dev_err(dev, "Failed to disable regulator: %d\n", ret); } Thanks Sekhar From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v4,6/6] usb: ohci-da8xx: drop the vbus GPIO From: Sekhar Nori Message-Id: <5bd92c5a-86e4-6779-6035-f9a0b33917e9@ti.com> Date: Fri, 12 Apr 2019 16:02:11 +0530 To: Bartosz Golaszewski , Kevin Hilman , Alan Stern , Greg Kroah-Hartman Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Bartosz Golaszewski List-ID: SGkgQmFydG9zeiwKCk9uIDExLzA0LzE5IDM6MDAgUE0sIEJhcnRvc3ogR29sYXN6ZXdza2kgd3Jv dGU6Cj4gQEAgLTIwOSw5ICsxOTcsNyBAQCBzdGF0aWMgaXJxcmV0dXJuX3Qgb2hjaV9kYTh4eF9v Y190aHJlYWQoaW50IGlycSwgdm9pZCAqZGF0YSkKPiAgCWludCByZXQ7Cj4gIAo+ICAJaWYgKGdw aW9kX2dldF92YWx1ZV9jYW5zbGVlcChkYTh4eF9vaGNpLT5vY19ncGlvKSkgewo+IC0JCWlmIChk YTh4eF9vaGNpLT52YnVzX2dwaW8pIHsKPiAtCQkJZ3Bpb2Rfc2V0X3ZhbHVlX2NhbnNsZWVwKGRh OHh4X29oY2ktPnZidXNfZ3BpbywgMCk7Cj4gLQkJfSBlbHNlIGlmIChkYTh4eF9vaGNpLT52YnVz X3JlZykgewo+ICsJCWlmIChkYTh4eF9vaGNpLT52YnVzX3JlZykgewo+ICAJCQlyZXQgPSByZWd1 bGF0b3JfZGlzYWJsZShkYTh4eF9vaGNpLT52YnVzX3JlZyk7Cj4gIAkJCWlmIChyZXQpCj4gIAkJ CQlkZXZfZXJyKGRldiwKCllvdSBjYW4gbm93IHJlZHVjZSBhIGxldmVsIG9mIGluZGVudGF0aW9u IGhlcmUgYnkgZG9pbmcKCglpZiAoZ3Bpb2RfZ2V0X3ZhbHVlX2NhbnNsZWVwKGRhOHh4X29oY2kt Pm9jX2dwaW8pICYmCgkgICAgZGE4eHhfb2hjaS0+dmJ1c19yZWcpIHsKCQlyZXQgPSByZWd1bGF0 b3JfZGlzYWJsZShkYTh4eF9vaGNpLT52YnVzX3JlZyk7CgkJaWYgKHJldCkKCQkJZGV2X2Vycihk ZXYsICJGYWlsZWQgdG8gZGlzYWJsZSByZWd1bGF0b3I6ICVkXG4iLAoJCQkJcmV0KTsKCX0KClRo YW5rcwpTZWtoYXIK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BC8BC10F14 for ; Fri, 12 Apr 2019 10:32:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 51FC520850 for ; Fri, 12 Apr 2019 10:32:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DFigVyQl"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ti.com header.i=@ti.com header.b="mkrryVkZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 51FC520850 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LyZ2Vci7By/tdn7lbGv+kiqAMGu/8UBz1HYqNn7xo3w=; b=DFigVyQlcz/S+b 4blJQcncsi1GWdpeZbdPwxwudK3G2hOwWxecOakrXsu1x/xzrLfZQNUjC6nCZZ8mfRkg2hyKk5Xk/ LjU4vDNXnpL2GI+B4Y4PQVtN1bDtfNzQV0Y9OxJPBbgfnWDvIkcq5eKZA4Mj+k3NZyButsCr1JUmU KGowLl154LygTy2kGV2UNokJ/d5TLn+AUhVlFy7VWGMP4Jpso3K7IHXa6ERlpPl39hYr4zzvoXBqy Vw+3YrIMXtpP+e8S519sR0k5lXI3skiNICtLrndaFeQUW2h5X7y16oXej1cVA+hR/Z3w9Ou7XYtfi DY2LJnLfGRYLVZs43H1w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEtTt-0002d9-0l; Fri, 12 Apr 2019 10:32:25 +0000 Received: from lelv0142.ext.ti.com ([198.47.23.249]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEtTq-0002cm-6C for linux-arm-kernel@lists.infradead.org; Fri, 12 Apr 2019 10:32:23 +0000 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id x3CAWEAX051748; Fri, 12 Apr 2019 05:32:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1555065134; bh=/xfSaZ1QRl+hHQhdhFBw9Ok1kkvfuJN2/FbjpR69m2w=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=mkrryVkZpE4l27xD5xBLVtI2xG3WQ9SYfDcGP/DCB/QkWsFlZpf7oCaONDNJl88tn wmkJwP61gbNw89UAbcHJKBsnYOEXWBpha0hXentMb9hQ66Kx3RCuKKCHz6bYEULaiQ 2h2rb8zkId/J/Ystb8pcOeL1xmdk3fu3HygemauM= Received: from DLEE115.ent.ti.com (dlee115.ent.ti.com [157.170.170.26]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x3CAWECt070241 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 12 Apr 2019 05:32:14 -0500 Received: from DLEE102.ent.ti.com (157.170.170.32) by DLEE115.ent.ti.com (157.170.170.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Fri, 12 Apr 2019 05:32:14 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE102.ent.ti.com (157.170.170.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Fri, 12 Apr 2019 05:32:14 -0500 Received: from [172.24.190.172] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id x3CAWBFZ056757; Fri, 12 Apr 2019 05:32:12 -0500 Subject: Re: [PATCH v4 6/6] usb: ohci-da8xx: drop the vbus GPIO To: Bartosz Golaszewski , Kevin Hilman , Alan Stern , Greg Kroah-Hartman References: <20190411093024.23555-1-brgl@bgdev.pl> <20190411093024.23555-7-brgl@bgdev.pl> From: Sekhar Nori Message-ID: <5bd92c5a-86e4-6779-6035-f9a0b33917e9@ti.com> Date: Fri, 12 Apr 2019 16:02:11 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190411093024.23555-7-brgl@bgdev.pl> Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190412_033222_310856_E2E58508 X-CRM114-Status: GOOD ( 11.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bartosz Golaszewski , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Bartosz, On 11/04/19 3:00 PM, Bartosz Golaszewski wrote: > @@ -209,9 +197,7 @@ static irqreturn_t ohci_da8xx_oc_thread(int irq, void *data) > int ret; > > if (gpiod_get_value_cansleep(da8xx_ohci->oc_gpio)) { > - if (da8xx_ohci->vbus_gpio) { > - gpiod_set_value_cansleep(da8xx_ohci->vbus_gpio, 0); > - } else if (da8xx_ohci->vbus_reg) { > + if (da8xx_ohci->vbus_reg) { > ret = regulator_disable(da8xx_ohci->vbus_reg); > if (ret) > dev_err(dev, You can now reduce a level of indentation here by doing if (gpiod_get_value_cansleep(da8xx_ohci->oc_gpio) && da8xx_ohci->vbus_reg) { ret = regulator_disable(da8xx_ohci->vbus_reg); if (ret) dev_err(dev, "Failed to disable regulator: %d\n", ret); } Thanks Sekhar _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel