Re: [PATCH V3 1/9] nl80211: allow multiple active scheduled scan requests

From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH V3 1/9] nl80211: allow multiple active scheduled scan requests
Date: Wed, 26 Apr 2017 12:24:53 +0200	[thread overview]
Message-ID: <5bdba644-82db-9df1-bfac-14c707dbdfda@broadcom.com> (raw)
In-Reply-To: <1493197685.2464.15.camel@sipsolutions.net>


On 4/26/2017 11:08 AM, Johannes Berg wrote:
> On Wed, 2017-04-26 at 11:05 +0200, Arend van Spriel wrote:
>> I guess it could be done, but I'm tending towards doing that less
>>> again, I have no strong preference in this case. If it was
>>> something
>>> that seems likely to get abused, perhaps, but here...
>>
>> Ok. As long as drivers don't think they can use the list_head to push
>> it on a private list.
> 
> They'll crash immediately and be disabused of that notion :)
> 
>> The internal use comment does not end up in
>> kerneldoc. So maybe we can improve that? Would work for me.
> 
> It's difficult - though we could replace it with /* private: */ and
> remove those things from kernel-doc entirely.

probably won't work:

	/* internal */
	struct wiphy *wiphy;
	struct net_device *dev;
	unsigned long scan_start;
	struct rcu_head rcu_head;
	u32 owner_nlportid;

	/* keep last */
	struct ieee80211_channel *channels[0];
};

Regards,
Arend