From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96298C07E96 for ; Tue, 6 Jul 2021 12:06:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 79FCE621BA for ; Tue, 6 Jul 2021 12:06:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234923AbhGFMId (ORCPT ); Tue, 6 Jul 2021 08:08:33 -0400 Received: from mga04.intel.com ([192.55.52.120]:46211 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240661AbhGFLrD (ORCPT ); Tue, 6 Jul 2021 07:47:03 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10036"; a="207272505" X-IronPort-AV: E=Sophos;i="5.83,328,1616482800"; d="scan'208";a="207272505" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jul 2021 04:40:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,328,1616482800"; d="scan'208";a="427558916" Received: from mylly.fi.intel.com (HELO [10.237.72.174]) ([10.237.72.174]) by orsmga002.jf.intel.com with ESMTP; 06 Jul 2021 04:40:02 -0700 Subject: Re: [PATCH v12 00/17] Introduce the Counter character device interface To: William Breathitt Gray , jic23@kernel.org Cc: linux-stm32@st-md-mailman.stormreply.com, kernel@pengutronix.de, a.fatoum@pengutronix.de, kamel.bouhara@bootlin.com, gwendal@chromium.org, alexandre.belloni@bootlin.com, david@lechnology.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, syednwaris@gmail.com, patrick.havelange@essensium.com, fabrice.gasnier@st.com, mcoquelin.stm32@gmail.com, alexandre.torgue@st.com, o.rempel@pengutronix.de References: From: Jarkko Nikula Message-ID: <5bdd9ee6-86af-3bcc-43ff-418fd1a2e3e8@linux.intel.com> Date: Tue, 6 Jul 2021 14:40:01 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi On 7/5/21 11:18 AM, William Breathitt Gray wrote: > To summarize the main points of this patchset: there are no changes to > the existing Counter sysfs userspace interface; a Counter character > device interface is introduced that allows Counter events and associated > data to be read() by userspace; the events_configure() and > watch_validate() driver callbacks are introduced to support Counter > events; and IRQ support is added to the 104-QUAD-8 driver, serving as an > example of how to support the new Counter events functionality. > I quickly tested this set on top of linux-next next-20210706 and didn't see any issue with intel-qep.c. However I noticed two mutex issues in patch 15/17. Perhaps visible due the CONFIG_DEBUG_MUTEXES=y etc. I have on. I'll be out of office next few weeks so cannot test if you have a new version meanwhile but wanted to share no show stopper from intel-qep.c and those two mutex warnings. Jarkko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63352C07E96 for ; Tue, 6 Jul 2021 11:55:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E031461363 for ; Tue, 6 Jul 2021 11:55:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E031461363 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JL47y2NWqUAoADfsFSNsIkuVkY+myhVy9UhgOO36Ovo=; b=y+kxC+c07S06UjDZXHIDnxMxTP E6E0+VAQ+Si0+GpHMYKrwTyOrk8iIsFvxg+dHyP5TSnV+eNVxFk/Uu7priElRma7q27cTFbXG8Fe4 YHXZl0CW4cZzYpGvj69Ufp1yUqzas9NlD02K9zz95dMlJ0P/jYjtiL0U2bAMdVT/WObb3DTHy0nPQ g5cT59jwQJdbFe3Ntty7eXFvbf34rKwbXdcYyQPiggbuiiMAKRaFhsBmVZLVoS3yGC4DzliCqvNQB L8PkZWQlzJe9W4YFCIyK5LOHfuOWrfIC82r6MV4UkKtP0UC/sVbrb9icSupFRUDaT3aenrX+rC++n 1ZuDJ22Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m0jc8-00BZV9-64; Tue, 06 Jul 2021 11:51:44 +0000 Received: from mga12.intel.com ([192.55.52.136]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m0jQv-00BSwP-D2 for linux-arm-kernel@lists.infradead.org; Tue, 06 Jul 2021 11:40:10 +0000 X-IronPort-AV: E=McAfee;i="6200,9189,10036"; a="188779194" X-IronPort-AV: E=Sophos;i="5.83,328,1616482800"; d="scan'208";a="188779194" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jul 2021 04:40:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,328,1616482800"; d="scan'208";a="427558916" Received: from mylly.fi.intel.com (HELO [10.237.72.174]) ([10.237.72.174]) by orsmga002.jf.intel.com with ESMTP; 06 Jul 2021 04:40:02 -0700 Subject: Re: [PATCH v12 00/17] Introduce the Counter character device interface To: William Breathitt Gray , jic23@kernel.org Cc: linux-stm32@st-md-mailman.stormreply.com, kernel@pengutronix.de, a.fatoum@pengutronix.de, kamel.bouhara@bootlin.com, gwendal@chromium.org, alexandre.belloni@bootlin.com, david@lechnology.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, syednwaris@gmail.com, patrick.havelange@essensium.com, fabrice.gasnier@st.com, mcoquelin.stm32@gmail.com, alexandre.torgue@st.com, o.rempel@pengutronix.de References: From: Jarkko Nikula Message-ID: <5bdd9ee6-86af-3bcc-43ff-418fd1a2e3e8@linux.intel.com> Date: Tue, 6 Jul 2021 14:40:01 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210706_044009_520030_0B874480 X-CRM114-Status: GOOD ( 15.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi On 7/5/21 11:18 AM, William Breathitt Gray wrote: > To summarize the main points of this patchset: there are no changes to > the existing Counter sysfs userspace interface; a Counter character > device interface is introduced that allows Counter events and associated > data to be read() by userspace; the events_configure() and > watch_validate() driver callbacks are introduced to support Counter > events; and IRQ support is added to the 104-QUAD-8 driver, serving as an > example of how to support the new Counter events functionality. > I quickly tested this set on top of linux-next next-20210706 and didn't see any issue with intel-qep.c. However I noticed two mutex issues in patch 15/17. Perhaps visible due the CONFIG_DEBUG_MUTEXES=y etc. I have on. I'll be out of office next few weeks so cannot test if you have a new version meanwhile but wanted to share no show stopper from intel-qep.c and those two mutex warnings. Jarkko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel