From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kever Yang Date: Mon, 1 Apr 2019 10:46:24 +0800 Subject: [U-Boot] =?utf-8?q?=5BPATCH_2/3=5D_rockchip=3A_use_=27arch-rockch?= =?utf-8?b?aXAnIGFzIGhlYWRlciBmaWxlIHBhdGjjgJDor7fms6jmhI/vvIzpgq7ku7Y=?= =?utf-8?b?55Sxc2pnQGdvb2dsZS5jb23ku6Plj5HjgJE=?= In-Reply-To: References: <20190328030124.29826-1-kever.yang@rock-chips.com> <20190328030124.29826-3-kever.yang@rock-chips.com> Message-ID: <5be54060-8efe-8152-f30f-c3979a033141@rock-chips.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Simon, On 04/01/2019 10:00 AM, Simon Glass wrote: > Hi Kever, > > On Sun, 31 Mar 2019 at 19:03, Kever Yang wrote: >> Hi Simon, >> >> >> On 03/31/2019 05:18 AM, Simon Glass wrote: >>> Hi Kever, >>> >>> On Wed, 27 Mar 2019 at 21:01, Kever Yang wrote: >>>> Rockchip use 'arch-rockchip' instead of arch-$(SOC) as common >>>> header file path, so that we can get the correct path directly. >>> Can you give a few more details on the reason for this change? I >>> cannot see the benefit? >> 1. 'rockchip' is not SOC name but vendor name, we'd better use correct name; >> 2. the build system will include $(SOC)-u-boot.dtsi automatically >> without modify >> $(SOC).dtsi or $(board).dtsi, if the $(SOC) default to 'rockchip', >> we can't use >> this feature. > OK I see. > > So far Rockchip has been designed so that a single U-Boot (proper) can > support multiple SoCs, I don't understand, how can a single U-Boot(proper) support multiple Rockchip SoCs, it sounds awesome which is kernel like. But I thought we need different build with different source for different SoCs now. For $(SOC)-u-boot.dtsi, another way is using $(BOARD)-u-boot.dtsi, but I think in most case, we can have one $(SOC)-u-boot.dtsi instead of many $(BOARD)-u-boot.dtsi for one SoC, so we need this feature. Thinks, - Kever > although in practice we don't use that ability. > So I don't think it is a big problem to drop it. > > Regards, > Simon >