From: Ricardo Martincoski <ricardo.martincoski@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 00/12] default runtime test case for python packages v2
Date: Sat, 10 Nov 2018 00:15:21 -0200 [thread overview]
Message-ID: <5be63f397da7b_2e452ac7f04fdb9c113de@ultri5.mail> (raw)
In-Reply-To: 20181106085656.425efe64@windsurf
Hello Thomas,
On Tue, Nov 06, 2018 at 05:56 AM, Thomas Petazzoni wrote:
> On Mon, 05 Nov 2018 23:57:15 -0200, Ricardo Martincoski wrote:
>
>> > - Use an integer for the Python version variable, rather than a
>> > string, there is really no need for this to be a string I believe ?
>>
>> You are correct. There is no need for a string. I will use an integer.
>
> On the other hand, this python_version = 2/3 is only one line, and it
> saves only one line in the config fragment, BR2_PACKAGE_PYTHON=y or
> BR2_PACKAGE_PYTHON3=y.
>
> So we replace one fairly explicit line:
>
> BR2_PACKAGE_PYTHON=y
>
> by just another line, which requires going to the base class to
> understand what is does:
>
> python_version = 2
>
> I.e, I am wondering if this refactoring is really useful in the end ?
Please let me send a v3, based from v1, doing the minimum to accomplish this
goal:
- add common logic to test python packages with a script in a separate file
instead of inline in the testcase
... and following these ideas:
- use separate class
- use no hacks/tricks
- use explicit code
From this v3 we can decide the direction to follow: whether to drop the series
or do some additional change, either as v4 or as followup patches.
Regards,
Ricardo
next prev parent reply other threads:[~2018-11-10 2:15 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-16 0:42 [Buildroot] [PATCH 0/7] default runtime test case for python packages Ricardo Martincoski
2018-10-16 0:42 ` [Buildroot] [PATCH 1/7] support/testing: create default " Ricardo Martincoski
2018-10-22 7:55 ` Thomas Petazzoni
2018-10-23 3:15 ` Ricardo Martincoski
2018-10-16 0:42 ` [Buildroot] [PATCH 2/7] support/testing: use default test_run for python-autobahn Ricardo Martincoski
2018-10-16 0:42 ` [Buildroot] [PATCH 3/7] support/testing: use default test_run for python-cryptography Ricardo Martincoski
2018-10-16 0:42 ` [Buildroot] [PATCH 4/7] support/testing: use default test_run for python-incremental Ricardo Martincoski
2018-10-16 0:42 ` [Buildroot] [PATCH 5/7] support/testing: use default test_run for python-twisted Ricardo Martincoski
2018-10-16 0:42 ` [Buildroot] [PATCH 6/7] support/testing: use default test_run for python-txaio Ricardo Martincoski
2018-10-16 0:42 ` [Buildroot] [PATCH 7/7] support/testing: use default test_run for python-txtorcon Ricardo Martincoski
2018-11-02 4:12 ` [Buildroot] [PATCH v2 00/12] default runtime test case for python packages v2 Ricardo Martincoski
2018-11-02 4:12 ` [Buildroot] [PATCH v2 01/12] support/testing: use helper class in IPython test Ricardo Martincoski
2018-11-02 4:12 ` [Buildroot] [PATCH v2 02/12] support/testing: use helper class in Python test Ricardo Martincoski
2018-11-02 4:12 ` [Buildroot] [PATCH v2 03/12] support/testing: create intermediate class per Python version Ricardo Martincoski
2018-11-02 4:12 ` [Buildroot] [PATCH v2 04/12] support/testing: create default test case for python packages Ricardo Martincoski
2018-11-02 4:12 ` [Buildroot] [PATCH v2 05/12] support/testing: use TestPythonPackageBase for python-autobahn Ricardo Martincoski
2018-11-02 4:12 ` [Buildroot] [PATCH v2 06/12] support/testing: use TestPythonPackageBase for python-cryptography Ricardo Martincoski
2018-11-02 4:12 ` [Buildroot] [PATCH v2 07/12] support/testing: use TestPythonPackageBase for python-incremental Ricardo Martincoski
2018-11-02 4:12 ` [Buildroot] [PATCH v2 08/12] support/testing: use TestPythonPackageBase for python-twisted Ricardo Martincoski
2018-11-02 4:12 ` [Buildroot] [PATCH v2 09/12] support/testing: use TestPythonPackageBase for python-txaio Ricardo Martincoski
2018-11-02 4:12 ` [Buildroot] [PATCH v2 10/12] support/testing: use TestPythonPackageBase for python-txtorcon Ricardo Martincoski
2018-11-02 4:12 ` [Buildroot] [PATCH v2 11/12] support/testing: rename python* test cases Ricardo Martincoski
2018-11-02 4:12 ` [Buildroot] [PATCH v2 12/12] testing: add python-crossbar tests Ricardo Martincoski
2018-11-04 10:40 ` [Buildroot] [PATCH v2 00/12] default runtime test case for python packages v2 Thomas Petazzoni
2018-11-04 22:42 ` Ricardo Martincoski
2018-11-05 8:15 ` Thomas Petazzoni
2018-11-06 1:57 ` Ricardo Martincoski
2018-11-06 7:56 ` Thomas Petazzoni
2018-11-10 2:15 ` Ricardo Martincoski [this message]
2018-11-10 2:16 ` [Buildroot] [PATCH v3 0/8] default runtime test case for python packages Ricardo Martincoski
2018-11-10 2:16 ` [Buildroot] [PATCH v3 1/8] support/testing: create default " Ricardo Martincoski
2018-11-10 2:16 ` [Buildroot] [PATCH v3 2/8] support/testing: use TestPythonPackageBase for python-autobahn Ricardo Martincoski
2018-11-10 2:16 ` [Buildroot] [PATCH v3 3/8] support/testing: use TestPythonPackageBase for python-cryptography Ricardo Martincoski
2018-11-10 2:16 ` [Buildroot] [PATCH v3 4/8] support/testing: use TestPythonPackageBase for python-incremental Ricardo Martincoski
2018-11-10 2:16 ` [Buildroot] [PATCH v3 5/8] support/testing: use TestPythonPackageBase for python-twisted Ricardo Martincoski
2018-11-10 2:16 ` [Buildroot] [PATCH v3 6/8] support/testing: use TestPythonPackageBase for python-txaio Ricardo Martincoski
2018-11-10 2:16 ` [Buildroot] [PATCH v3 7/8] support/testing: use TestPythonPackageBase for python-txtorcon Ricardo Martincoski
2018-11-10 2:16 ` [Buildroot] [PATCH v3 8/8] testing: add python-crossbar tests Ricardo Martincoski
2018-11-13 19:57 ` [Buildroot] [PATCH v3 0/8] default runtime test case for python packages Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5be63f397da7b_2e452ac7f04fdb9c113de@ultri5.mail \
--to=ricardo.martincoski@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.