From: Patrick DELAUNAY <patrick.delaunay@st.com>
To: u-boot@lists.denx.de
Subject: [PATCH] video: extend stdout video console work-around for 'vga'
Date: Wed, 1 Jul 2020 13:01:43 +0000 [thread overview]
Message-ID: <5beee82b3f0945818070ab28be19c111@SFHDAG6NODE3.st.com> (raw)
In-Reply-To: <20200619155550.05b81533@crub>
Hi Anatolij
> From: U-Boot <u-boot-bounces@lists.denx.de> On Behalf Of Anatolij Gustschin
> Sent: vendredi 19 juin 2020 15:56
>
> On Sat, 23 May 2020 17:11:20 +0200
> Anatolij Gustschin agust at denx.de wrote:
>
> > cfb_console driver use 'vga' console name and we still have board
> > environments defining this name. Re-use existing DM_VIDEO work- around
> > for console name to support 'vga' name in stdout environment.
> >
> > Signed-off-by: Anatolij Gustschin <agust@denx.de>
> > ---
> > arch/arm/mach-tegra/Kconfig | 1 -
> > common/console.c | 7 ++++---
> > drivers/video/Kconfig | 16 +++++++++-------
> > 3 files changed, 13 insertions(+), 11 deletions(-)
>
> Applied to u-boot-video/next, thanks!
This patch breaks the stm32mp15 boot in console_init_r.on the next branch.
The board have with DM_VIDEO activated.
In previous version the workaround was not activated for the board: CONFIG_VIDCONSOLE_AS_LCD=n (default)
PS: the config is activated in few board but still as bolean but defined as sting in Kconfig
configs/peach-pit_defconfig:76:CONFIG_VIDCONSOLE_AS_LCD=y
configs/snow_defconfig:87:CONFIG_VIDCONSOLE_AS_LCD=y
configs/peach-pi_defconfig:77:CONFIG_VIDCONSOLE_AS_LCD=y
configs/spring_defconfig:88:CONFIG_VIDCONSOLE_AS_LCD=y
Now it is a string, the CONFIG is always defined = value is "lcd" or "vga" or ""
And the code in console.c under this compilation flags cause the crash.
I push a patch [1] to fix up it this update:
VIDCONSOLE_AS_LCD => Boolean used in defconfig as previously
VIDCONSOLE_AS_NAME => name the the string to used.... NEW
[1] "video: restore CONFIG_VIDCONSOLE_AS_LCD as Boolean"
Regards
Patrick
next prev parent reply other threads:[~2020-07-01 13:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-22 23:24 [PATCH] tbs2910: migrate to DM_VIDEO Anatolij Gustschin
2020-05-23 7:55 ` Soeren Moch
2020-05-23 15:11 ` [PATCH] video: extend stdout video console work-around for 'vga' Anatolij Gustschin
2020-05-24 15:21 ` Soeren Moch
2020-05-25 2:14 ` Simon Glass
2020-05-26 18:08 ` Tom Rini
2020-06-19 13:55 ` Anatolij Gustschin
2020-07-01 13:01 ` Patrick DELAUNAY [this message]
2020-05-23 15:17 ` [PATCH] tbs2910: migrate to DM_VIDEO Anatolij Gustschin
2020-05-23 15:31 ` Soeren Moch
2020-05-24 15:46 ` Soeren Moch
2020-05-26 20:13 ` Anatolij Gustschin
2020-05-28 7:54 ` Soeren Moch
2020-05-28 8:07 ` Anatolij Gustschin
2020-05-30 16:01 ` Soeren Moch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5beee82b3f0945818070ab28be19c111@SFHDAG6NODE3.st.com \
--to=patrick.delaunay@st.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.