All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: iwd@lists.01.org
Subject: Re: Interface not detected sometimes
Date: Wed, 05 Feb 2020 09:19:37 -0600	[thread overview]
Message-ID: <5bf91f75-9c0a-6d87-761a-774c87f5f69d@gmail.com> (raw)
In-Reply-To: <20200205133515.2820.50222@ml01.vlan13.01.org>

[-- Attachment #1: Type: text/plain, Size: 1397 bytes --]

Hi Hector,

On 2/5/20 7:35 AM, hector(a)ikatu.com wrote:
> Here is a log of a failed initialization where I have set "--interfaces wlan0", no sleep in iwd.service, and I applied your recent commit (8530396fb3179c789430264a01e506a11907f94b manager: Add brcmfmac to the blacklist), (BTW I didn't set any value to the UseDefaultInterface property).

Okay.  The brcmfmac commit shouldn't have any effect if you're using 
--interfaces command line option.  But it won't hurt.

<snip>

> Feb 05 13:24:33 Paris-00100105 iwd[429]: Wiphy: 0, Name: phy0
> Feb 05 13:24:33 Paris-00100105 iwd[429]:         Permanent Address: 10:98:c3:ff:f6:9d
> Feb 05 13:24:33 Paris-00100105 iwd[429]:         Bands: 2.4 GHz 5 GHz
> Feb 05 13:24:33 Paris-00100105 iwd[429]:         Ciphers: CCMP TKIP BIP
> Feb 05 13:24:33 Paris-00100105 iwd[429]:         Supported iftypes: ad-hoc station ap p2p-client p2p-go p2p-device
> Feb 05 13:24:33 Paris-00100105 iwd[429]: ../git/src/manager.c:manager_use_default()
> Feb 05 13:24:33 Paris-00100105 iwd[429]: No default interface for wiphy 0
> Feb 05 13:24:33 Paris-00100105 iwd[429]: ../git/src/manager.c:manager_config_notify() Notification of command New Interface(7)

Okay.  Looks like commit 55f9639ee37c ("manager: Retry the interface 
setup if we get an EBUSY") didn't address the 'use default' path.  Can 
you try the attach patch?

Regards,
-Denis

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-manager-Also-set-retry-when-using-default-interfaces.patch --]
[-- Type: text/x-patch, Size: 656 bytes --]

From 360f66f71cb187d278f4dd75acc1f71e4086f978 Mon Sep 17 00:00:00 2001
From: Denis Kenzior <denkenz@gmail.com>
Date: Wed, 5 Feb 2020 09:14:47 -0600
Subject: [PATCH] manager: Also set retry when using default interfaces

---
 src/manager.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/manager.c b/src/manager.c
index a810ed7813e8..5ca5d610138f 100644
--- a/src/manager.c
+++ b/src/manager.c
@@ -112,6 +112,7 @@ static bool manager_use_default(struct wiphy_setup_state *state)
 	if (!state->default_if_msg) {
 		l_error("No default interface for wiphy %u",
 			(unsigned int) state->id);
+		state->retry = true;
 		return false;
 	}
 
-- 
2.21.0


  reply	other threads:[~2020-02-05 15:19 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-04 14:54 Interface not detected sometimes hector
2020-02-04 14:58 ` hector
2020-02-04 17:06   ` Denis Kenzior
2020-02-04 19:08     ` hector
2020-02-04 20:45       ` hector
2020-02-04 22:14         ` Denis Kenzior
2020-02-05 12:58           ` hector
2020-02-05 15:00             ` Denis Kenzior
2020-02-05 13:35           ` hector
2020-02-05 15:19             ` Denis Kenzior [this message]
2020-02-05 19:28               ` hector
2020-02-06 16:27                 ` Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5bf91f75-9c0a-6d87-761a-774c87f5f69d@gmail.com \
    --to=denkenz@gmail.com \
    --cc=iwd@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.