All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matt Freel <matt.freel@broadcom.com>
To: Jens Axboe <axboe@kernel.dk>, fio@vger.kernel.org
Subject: RE: Proper way to shut down FIO in Linux
Date: Wed, 21 Mar 2018 08:39:44 -0600	[thread overview]
Message-ID: <5c04f55f59338786b9fa5be6f530c64b@mail.gmail.com> (raw)
In-Reply-To: <bb2e6c2d-032d-6a8f-1313-9e255af621ef@kernel.dk>

Thanks.  Making that change makes things work correctly.  There was some
confusion on my part with Python because I wasn't getting the PID of the FIO
process.  Once I figured out why it's working sending sigint to the main
process.

-----Original Message-----
From: Jens Axboe <axboe@kernel.dk>
Sent: Wednesday, March 21, 2018 8:37 AM
To: Matt Freel <matt.freel@broadcom.com>; fio@vger.kernel.org
Subject: Re: Proper way to shut down FIO in Linux

On 3/13/18 12:56 PM, Matt Freel wrote:
> I'm using FIO to run IOs to a number of block devices.  I'm looking
> for the proper way to shut down all the threads that are spawned.
>
> I'm doing the following:
>
> /usr/bin/pkill --signal INT fio
>
> Most of the time this works fine, but I do have cases where some of
> the FIO processes remain open.  Eventually I get a 300s timeout and
> then they're killed.
>
> A couple questions:
>
> 1.	When these threads have to be ungracefully killed, do the results
> still get counted in the output file?
> a.	I'm using JSON output file
> 2.	Is there a better way I should be killing all the threads?

You want to SIGINT the main process, not all the jobs that are running.
If you do that, you would get the same behavior as when you ctrl-c a running
job. The way you are doing it, you are randomly killing job processes. You
want to let the main thread shut things down instead.

--
Jens Axboe


      reply	other threads:[~2018-03-21 14:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-13 18:56 Proper way to shut down FIO in Linux Matt Freel
2018-03-14  6:46 ` Erwan Velu
2018-03-14 15:07   ` Matt Freel
2018-03-17  6:34     ` Sitsofe Wheeler
2018-03-21 14:36 ` Jens Axboe
2018-03-21 14:39   ` Matt Freel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5c04f55f59338786b9fa5be6f530c64b@mail.gmail.com \
    --to=matt.freel@broadcom.com \
    --cc=axboe@kernel.dk \
    --cc=fio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.