From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61705C47082 for ; Thu, 27 May 2021 00:58:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3FF17613C5 for ; Thu, 27 May 2021 00:58:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234024AbhE0A7h (ORCPT ); Wed, 26 May 2021 20:59:37 -0400 Received: from new4-smtp.messagingengine.com ([66.111.4.230]:34641 "EHLO new4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233477AbhE0A7g (ORCPT ); Wed, 26 May 2021 20:59:36 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.nyi.internal (Postfix) with ESMTP id CED4E5804D2; Wed, 26 May 2021 20:58:02 -0400 (EDT) Received: from imap2 ([10.202.2.52]) by compute3.internal (MEProxy); Wed, 26 May 2021 20:58:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h= mime-version:message-id:in-reply-to:references:date:from:to:cc :subject:content-type; s=fm2; bh=F/qifLq8yQh1az5Zwysk7y+47oJDirR vH4OiyQFYYzI=; b=cgLtwK0KLSeyC9oPpsRVpMHVer4QIWQNBhSHlFjKL1JVAon 2JMsBkN+OW5KmdXJoM/tUAOwASMZ/gGXR7+56+VeL82x+hwj5Lg2Kz9+lcqOHRN+ MIwE9aIa7AdpBuOGSZOn9qEFt2GhfgsaDddWdAIrWwqt9N0744+vn/0Ld5x19iQn vEnpIJA5PB9P8bM6P79e7xHEaPKSlWE/bxyKk9s//ldLflEsEkpe1L9PG5neDbFH jKfj21ObIWBxMt9wj22DhJpu4U3PAt3p8tvrN/8+3RfFfrJ5yO42gY7Vkh/Oe0Lp vZKTraMXVXBu5vXzSiIMbATh6rSNw17kLNbu1QQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=F/qifL q8yQh1az5Zwysk7y+47oJDirRvH4OiyQFYYzI=; b=sHDLbR58bET2rrmFXa3/6W prVsteoVnlf8HTsx2daI+12gwLkDqwdkfzQpu4bvtaVYoQXPN84IoS1Asj2fcTWr zkebpu+rS3KhnN4a3YAoBRsIKiB7C9dW+8mhPF9eY6SBRseVsKzF6PyvG7cT6nh/ f/08COzhrFpW2JKzcgEmpM6G1Ll5LbUHUZKvuNTkXrwuGvp5FoCsTUQ7WC16g0sn N9AEu34zEX8rEOXW4Xh0mmoNup9IcLr+jHN5y8DPYxF7wgMd/eAKbQKQ7UxpXwV+ zIePipYyxlf44gdsG73JkwLBdi7ithori8nHA6ZHE4Il2irXvMQAzG4+OICPMRXA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdekgedgfeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvffutgesthdtredtreerjeenucfhrhhomhepfdetnhgu rhgvficulfgvfhhfvghrhidfuceorghnughrvgifsegrjhdrihgurdgruheqnecuggftrf grthhtvghrnhepuddttdekueeggedvtddtueekiedutdfguedutdefieeuteefieelteet vddthfeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh eprghnughrvgifsegrjhdrihgurdgruh X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 5994EA00079; Wed, 26 May 2021 20:58:01 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.5.0-alpha0-468-gdb53729b73-fm-20210517.001-gdb53729b Mime-Version: 1.0 Message-Id: <5c0670b1-269c-4aae-8639-c0866ac90dc9@www.fastmail.com> In-Reply-To: <20210526094609.14068-2-steven_lee@aspeedtech.com> References: <20210526094609.14068-1-steven_lee@aspeedtech.com> <20210526094609.14068-2-steven_lee@aspeedtech.com> Date: Thu, 27 May 2021 10:27:37 +0930 From: "Andrew Jeffery" To: "Steven Lee" , "Linus Walleij" , "Bartosz Golaszewski" , "Rob Herring" , "Joel Stanley" , "open list:GPIO SUBSYSTEM" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , "open list" Cc: "Hongwei Zhang" , "Ryan Chen" , "Billy Tsai" Subject: =?UTF-8?Q?Re:_[PATCH_v1_1/4]_dt-bindings:_aspeed-sgpio:_Convert_txt_bind?= =?UTF-8?Q?ings_to_yaml.?= Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Hi Steven, On Wed, 26 May 2021, at 19:16, Steven Lee wrote: > SGPIO bindings should be converted as yaml format. > In addition to the file conversion, a new property max-ngpios is > added in the yaml file as well. > The new property is required by the enhanced sgpio driver for > making the configuration of the max number of gpio pins more flexible. Please add the new property in a separate patch to the YAML conversion. Having changes to the properties in addition to switching to dt schema makes it harder to catch errors, and it seems Rob's bot has already picked up some. Reviewing the changes as separate patches means its easier to give you a Reviewed-by tag on that patches I'm happy with. Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC1CEC47082 for ; Thu, 27 May 2021 01:00:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A16EA613C5 for ; Thu, 27 May 2021 01:00:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A16EA613C5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=aj.id.au Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Subject:Cc:To:From:Date:References: In-Reply-To:Message-Id:Mime-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FozYqTlefaXHEYlZMHtP/CjruZ0vJ59yYtIZKAxlj4c=; b=atbN5B864nrL9G +xhyMes4fM/Tw8TPe7KCkTOU06ZopfOym2bKZxe18SbX3zpqJ/UGZlqnZpszoQP2OXHkKjxY2Uh11 33Z3HjxVnD9chvV1Eg/AbgOsRpR96vJBFYXIXRzodt33tpoAzQh/akSiZ8i3dOrJTa6xiwywBIMb4 fmS2VLDA/0aRJpwfKiYzW7ePubbqHlyCWtjhzs4g+9e+yDQl59FtGtiAiPIZH+20suTQZUCe5+0ha vWGXmQx6eUVYJQf0obQuieZci4SC6zn7tgPwFbdVSzyDPnuigJfSalnd2V0BmqJ2yc2kB0NpJrHjI yz1R9GIABpWGDngboOEA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lm4Ll-001Jbh-3h; Thu, 27 May 2021 00:58:13 +0000 Received: from new4-smtp.messagingengine.com ([66.111.4.230]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lm4Lf-001JXG-N5 for linux-arm-kernel@lists.infradead.org; Thu, 27 May 2021 00:58:09 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.nyi.internal (Postfix) with ESMTP id CED4E5804D2; Wed, 26 May 2021 20:58:02 -0400 (EDT) Received: from imap2 ([10.202.2.52]) by compute3.internal (MEProxy); Wed, 26 May 2021 20:58:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h= mime-version:message-id:in-reply-to:references:date:from:to:cc :subject:content-type; s=fm2; bh=F/qifLq8yQh1az5Zwysk7y+47oJDirR vH4OiyQFYYzI=; b=cgLtwK0KLSeyC9oPpsRVpMHVer4QIWQNBhSHlFjKL1JVAon 2JMsBkN+OW5KmdXJoM/tUAOwASMZ/gGXR7+56+VeL82x+hwj5Lg2Kz9+lcqOHRN+ MIwE9aIa7AdpBuOGSZOn9qEFt2GhfgsaDddWdAIrWwqt9N0744+vn/0Ld5x19iQn vEnpIJA5PB9P8bM6P79e7xHEaPKSlWE/bxyKk9s//ldLflEsEkpe1L9PG5neDbFH jKfj21ObIWBxMt9wj22DhJpu4U3PAt3p8tvrN/8+3RfFfrJ5yO42gY7Vkh/Oe0Lp vZKTraMXVXBu5vXzSiIMbATh6rSNw17kLNbu1QQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=F/qifL q8yQh1az5Zwysk7y+47oJDirRvH4OiyQFYYzI=; b=sHDLbR58bET2rrmFXa3/6W prVsteoVnlf8HTsx2daI+12gwLkDqwdkfzQpu4bvtaVYoQXPN84IoS1Asj2fcTWr zkebpu+rS3KhnN4a3YAoBRsIKiB7C9dW+8mhPF9eY6SBRseVsKzF6PyvG7cT6nh/ f/08COzhrFpW2JKzcgEmpM6G1Ll5LbUHUZKvuNTkXrwuGvp5FoCsTUQ7WC16g0sn N9AEu34zEX8rEOXW4Xh0mmoNup9IcLr+jHN5y8DPYxF7wgMd/eAKbQKQ7UxpXwV+ zIePipYyxlf44gdsG73JkwLBdi7ithori8nHA6ZHE4Il2irXvMQAzG4+OICPMRXA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdekgedgfeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvffutgesthdtredtreerjeenucfhrhhomhepfdetnhgu rhgvficulfgvfhhfvghrhidfuceorghnughrvgifsegrjhdrihgurdgruheqnecuggftrf grthhtvghrnhepuddttdekueeggedvtddtueekiedutdfguedutdefieeuteefieelteet vddthfeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh eprghnughrvgifsegrjhdrihgurdgruh X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 5994EA00079; Wed, 26 May 2021 20:58:01 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.5.0-alpha0-468-gdb53729b73-fm-20210517.001-gdb53729b Mime-Version: 1.0 Message-Id: <5c0670b1-269c-4aae-8639-c0866ac90dc9@www.fastmail.com> In-Reply-To: <20210526094609.14068-2-steven_lee@aspeedtech.com> References: <20210526094609.14068-1-steven_lee@aspeedtech.com> <20210526094609.14068-2-steven_lee@aspeedtech.com> Date: Thu, 27 May 2021 10:27:37 +0930 From: "Andrew Jeffery" To: "Steven Lee" , "Linus Walleij" , "Bartosz Golaszewski" , "Rob Herring" , "Joel Stanley" , "open list:GPIO SUBSYSTEM" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , "open list" Cc: "Hongwei Zhang" , "Ryan Chen" , "Billy Tsai" Subject: =?UTF-8?Q?Re:_[PATCH_v1_1/4]_dt-bindings:_aspeed-sgpio:_Convert_txt_bind?= =?UTF-8?Q?ings_to_yaml.?= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210526_175807_872422_8296045A X-CRM114-Status: UNSURE ( 9.91 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Steven, On Wed, 26 May 2021, at 19:16, Steven Lee wrote: > SGPIO bindings should be converted as yaml format. > In addition to the file conversion, a new property max-ngpios is > added in the yaml file as well. > The new property is required by the enhanced sgpio driver for > making the configuration of the max number of gpio pins more flexible. Please add the new property in a separate patch to the YAML conversion. Having changes to the properties in addition to switching to dt schema makes it harder to catch errors, and it seems Rob's bot has already picked up some. Reviewing the changes as separate patches means its easier to give you a Reviewed-by tag on that patches I'm happy with. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel