From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932410AbcI1Muo (ORCPT ); Wed, 28 Sep 2016 08:50:44 -0400 Received: from mail-io0-f193.google.com ([209.85.223.193]:33582 "EHLO mail-io0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752399AbcI1Mue (ORCPT ); Wed, 28 Sep 2016 08:50:34 -0400 Subject: Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets To: Cyrill Gorcunov References: <20160928112703.GW1876@uranus.lan> <20160928.080701.1194277590163223525.davem@davemloft.net> <60b2e075-e852-f0c2-c188-631f547791d5@mojatatu.com> <20160928.081646.1634500099795129398.davem@davemloft.net> <70b51ac5-a7d1-8b52-90c4-7f80ec8ad4d5@mojatatu.com> <20160928124520.GZ1876@uranus.lan> Cc: David Miller , eric.dumazet@gmail.com, dsa@cumulusnetworks.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net, avagin@openvz.org, stephen@networkplumber.org From: Jamal Hadi Salim Message-ID: <5c1cff4e-25bc-5356-a8f8-f5fa44b2a439@mojatatu.com> Date: Wed, 28 Sep 2016 08:50:31 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20160928124520.GZ1876@uranus.lan> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16-09-28 08:45 AM, Cyrill Gorcunov wrote: >> Note: inet_diag somewhere has a netlink structure that >> has a hole. I pointed it out to Eric D. and he said we cant >> add it now because it would break ABI. > > Naming holes generated by a compiler for alignment sake should > not break abi (because alignments are abi by self), but I may > be missing something in context of where the structure you're > talking about is present. And what about non-x86 archs? They > might have different members alignment requirements. > struct tcp_info. Sorry - i didnt mean to drag this for long; but the more i think about it, the union is a pragmatic approach. cheers, jamal