From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B09AC28CC5 for ; Wed, 5 Jun 2019 21:08:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 50C1E2075B for ; Wed, 5 Jun 2019 21:08:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726716AbfFEVIP (ORCPT ); Wed, 5 Jun 2019 17:08:15 -0400 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:36131 "EHLO relay2-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726464AbfFEVIP (ORCPT ); Wed, 5 Jun 2019 17:08:15 -0400 X-Originating-IP: 93.29.109.196 Received: from collins (196.109.29.93.rev.sfr.net [93.29.109.196]) (Authenticated sender: paul.kocialkowski@bootlin.com) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 9B30F40003; Wed, 5 Jun 2019 21:08:07 +0000 (UTC) Message-ID: <5c2217a4e80eaaa6a8eefd8752ce9a86933d0a80.camel@bootlin.com> Subject: Re: [PATCH 5/7] media: cedrus: Don't set chroma size for scale & rotation From: Paul Kocialkowski To: Jernej Skrabec , maxime.ripard@bootlin.com Cc: wens@csie.org, mchehab@kernel.org, gregkh@linuxfoundation.org, linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Date: Wed, 05 Jun 2019 23:08:07 +0200 In-Reply-To: <20190530211516.1891-6-jernej.skrabec@siol.net> References: <20190530211516.1891-1-jernej.skrabec@siol.net> <20190530211516.1891-6-jernej.skrabec@siol.net> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.32.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Le jeudi 30 mai 2019 à 23:15 +0200, Jernej Skrabec a écrit : > Scale and rotation are currently not implemented, so it makes no sense to > set chroma size for it. > > Signed-off-by: Jernej Skrabec Acked-by: Paul Kocialkowski Cheers, Paul > --- > drivers/staging/media/sunxi/cedrus/cedrus_hw.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/staging/media/sunxi/cedrus/cedrus_hw.c b/drivers/staging/media/sunxi/cedrus/cedrus_hw.c > index 9c5819def186..9de20ae47916 100644 > --- a/drivers/staging/media/sunxi/cedrus/cedrus_hw.c > +++ b/drivers/staging/media/sunxi/cedrus/cedrus_hw.c > @@ -79,9 +79,6 @@ void cedrus_dst_format_set(struct cedrus_dev *dev, > reg = VE_PRIMARY_OUT_FMT_NV12; > cedrus_write(dev, VE_PRIMARY_OUT_FMT, reg); > > - reg = VE_CHROMA_BUF_LEN_SDRT(chroma_size / 2); > - cedrus_write(dev, VE_CHROMA_BUF_LEN, reg); > - > reg = chroma_size / 2; > cedrus_write(dev, VE_PRIMARY_CHROMA_BUF_LEN, reg); > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 758FFC28CC5 for ; Wed, 5 Jun 2019 21:08:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4A8E220866 for ; Wed, 5 Jun 2019 21:08:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="odldu3Uo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4A8E220866 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jKRw+eu4gY7VXbIdz5iqhEg1SyOBFi77nHEMzISkyaU=; b=odldu3Uo2719FN YVLvVEP9fiDtYkGqELKkCmGxlDjQD2WESmczQgRxVEsKoSu8wh3MJ4zvNIe+4sD8L6M6ACKukr1yp hVYAIfWXCX98mbbxT/Js1CWxlGVypul/JrQRUC+HT/6gW6mEvXcCCHCOujVulAEGwlSV0Bn17eF3t 1h7Wv+GZOqTgFP0Ti5U/kLZHMG/0YDayUrzebwM0E2eh7tLnAXbA83KHaHJgHb3bBAKVjNWZxL+K4 sCcNl0fvqdZTbzkLP48a3mRyPB03+i3abGaY3bS9DTC4mqp2CPYFMC1lJoyAFNBh1+z2SKl/u6PY3 4BSA7l6GpNLGb2utsRjg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hYd93-0002Au-N8; Wed, 05 Jun 2019 21:08:29 +0000 Received: from relay2-d.mail.gandi.net ([217.70.183.194]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hYd90-0002AP-9z for linux-arm-kernel@lists.infradead.org; Wed, 05 Jun 2019 21:08:27 +0000 X-Originating-IP: 93.29.109.196 Received: from collins (196.109.29.93.rev.sfr.net [93.29.109.196]) (Authenticated sender: paul.kocialkowski@bootlin.com) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 9B30F40003; Wed, 5 Jun 2019 21:08:07 +0000 (UTC) Message-ID: <5c2217a4e80eaaa6a8eefd8752ce9a86933d0a80.camel@bootlin.com> Subject: Re: [PATCH 5/7] media: cedrus: Don't set chroma size for scale & rotation From: Paul Kocialkowski To: Jernej Skrabec , maxime.ripard@bootlin.com Date: Wed, 05 Jun 2019 23:08:07 +0200 In-Reply-To: <20190530211516.1891-6-jernej.skrabec@siol.net> References: <20190530211516.1891-1-jernej.skrabec@siol.net> <20190530211516.1891-6-jernej.skrabec@siol.net> User-Agent: Evolution 3.32.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190605_140826_501123_96A4A454 X-CRM114-Status: GOOD ( 10.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, wens@csie.org, mchehab@kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGksCgpMZSBqZXVkaSAzMCBtYWkgMjAxOSDDoCAyMzoxNSArMDIwMCwgSmVybmVqIFNrcmFiZWMg YSDDqWNyaXQgOgo+IFNjYWxlIGFuZCByb3RhdGlvbiBhcmUgY3VycmVudGx5IG5vdCBpbXBsZW1l bnRlZCwgc28gaXQgbWFrZXMgbm8gc2Vuc2UgdG8KPiBzZXQgY2hyb21hIHNpemUgZm9yIGl0Lgo+ IAo+IFNpZ25lZC1vZmYtYnk6IEplcm5laiBTa3JhYmVjIDxqZXJuZWouc2tyYWJlY0BzaW9sLm5l dD4KCkFja2VkLWJ5OiBQYXVsIEtvY2lhbGtvd3NraSA8cGF1bC5rb2NpYWxrb3dza2lAYm9vdGxp bi5jb20+CkNoZWVycywKClBhdWwKCj4gLS0tCj4gIGRyaXZlcnMvc3RhZ2luZy9tZWRpYS9zdW54 aS9jZWRydXMvY2VkcnVzX2h3LmMgfCAzIC0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMyBkZWxldGlv bnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9zdGFnaW5nL21lZGlhL3N1bnhpL2NlZHJ1 cy9jZWRydXNfaHcuYyBiL2RyaXZlcnMvc3RhZ2luZy9tZWRpYS9zdW54aS9jZWRydXMvY2VkcnVz X2h3LmMKPiBpbmRleCA5YzU4MTlkZWYxODYuLjlkZTIwYWU0NzkxNiAxMDA2NDQKPiAtLS0gYS9k cml2ZXJzL3N0YWdpbmcvbWVkaWEvc3VueGkvY2VkcnVzL2NlZHJ1c19ody5jCj4gKysrIGIvZHJp dmVycy9zdGFnaW5nL21lZGlhL3N1bnhpL2NlZHJ1cy9jZWRydXNfaHcuYwo+IEBAIC03OSw5ICs3 OSw2IEBAIHZvaWQgY2VkcnVzX2RzdF9mb3JtYXRfc2V0KHN0cnVjdCBjZWRydXNfZGV2ICpkZXYs Cj4gIAkJcmVnID0gVkVfUFJJTUFSWV9PVVRfRk1UX05WMTI7Cj4gIAkJY2VkcnVzX3dyaXRlKGRl diwgVkVfUFJJTUFSWV9PVVRfRk1ULCByZWcpOwo+ICAKPiAtCQlyZWcgPSBWRV9DSFJPTUFfQlVG X0xFTl9TRFJUKGNocm9tYV9zaXplIC8gMik7Cj4gLQkJY2VkcnVzX3dyaXRlKGRldiwgVkVfQ0hS T01BX0JVRl9MRU4sIHJlZyk7Cj4gLQo+ICAJCXJlZyA9IGNocm9tYV9zaXplIC8gMjsKPiAgCQlj ZWRydXNfd3JpdGUoZGV2LCBWRV9QUklNQVJZX0NIUk9NQV9CVUZfTEVOLCByZWcpOwo+ICAKCgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0t a2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcK aHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2Vy bmVsCg==