From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 654C9C43381 for ; Sun, 24 Feb 2019 16:52:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 366C5205C9 for ; Sun, 24 Feb 2019 16:52:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728493AbfBXQv7 (ORCPT ); Sun, 24 Feb 2019 11:51:59 -0500 Received: from mx2.suse.de ([195.135.220.15]:54304 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728179AbfBXQv7 (ORCPT ); Sun, 24 Feb 2019 11:51:59 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 5B0A8ADC6; Sun, 24 Feb 2019 16:51:56 +0000 (UTC) Subject: Re: [PATCH 1/4] maxbotix,mb12x2.txt: add dt doc for maxbotix,mb12x2 To: Andreas Klinger References: <20190224162208.esbrzartgfqxptsw@arbad> Cc: arnd@arndb.de, davem@davemloft.net, devicetree@vger.kernel.org, gregkh@linuxfoundation.org, jic23@kernel.org, johan@kernel.org, khilman@baylibre.com, knaack.h@gmx.de, lars@metafoo.de, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, mark.rutland@arm.com, martin.blumenstingl@googlemail.com, mchehab+samsung@kernel.org, m.othacehe@gmail.com, nicolas.ferre@microchip.com, pmeerw@pmeerw.net, robh+dt@kernel.org, robh@kernel.org, songqiang1304521@gmail.com, treding@nvidia.com From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Openpgp: preference=signencrypt Organization: SUSE Linux GmbH Message-ID: <5c2efbb1-e243-a272-5106-9cd279d1c973@suse.de> Date: Sun, 24 Feb 2019 17:51:53 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 MIME-Version: 1.0 In-Reply-To: <20190224162208.esbrzartgfqxptsw@arbad> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andreas, Am 24.02.19 um 17:22 schrieb Andreas Klinger: > add dt doc for maxbotix,mb12x2 and also a new vendor prefix maxbotix Please don't mix the two. The subject prefix should be "dt-bindings:". Please compare git log. And please avoid putting the whole world in To rather than CC. > > Signed-off-by: Andreas Klinger > --- > .../bindings/iio/proximity/maxbotix,mb12x2.txt | 22 ++++++++++++++++++++++ > .../devicetree/bindings/vendor-prefixes.txt | 1 + > 2 files changed, 23 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/proximity/maxbotix,mb12x2.txt > > diff --git a/Documentation/devicetree/bindings/iio/proximity/maxbotix,mb12x2.txt b/Documentation/devicetree/bindings/iio/proximity/maxbotix,mb12x2.txt > new file mode 100644 > index 000000000000..29f7fc09cfdc > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/proximity/maxbotix,mb12x2.txt > @@ -0,0 +1,22 @@ You're aware that a conversion from txt to YAML was under way? > +* MaxSonar-I2CXL ultrasonic distance sensor of type mb12x2 using the i2c > + interface for ranging > + > +Required properties: > + - compatible: Should be "maxbotix,mb12x2" Is that really the model name with x? No wildcards as compatible please. > + > + - reg: i2c address of the device > + > +Optional properties: > + - status-gpios: Definition of the status gpio (input) which is used > + to announce the preceding reading request has > + finished and that data is available. If no status > + gpio is specified the device driver falls back to > + wait a certain amount of time (15 ms) until data > + can be retrieved. That sounds like an implementation detail that should not be part of the binding? It at least needs to be reworded. > + > +Example: > +mb@70 { Please use a generic node name - maybe proximity? Check other examples. > + compatible = "maxbotix,mb12x2"; > + reg = <0x70>; > + status-gpios = <&gpio2 2 GPIO_ACTIVE_HIGH>; > +}; > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt > index 389508584f48..added54a1108 100644 > --- a/Documentation/devicetree/bindings/vendor-prefixes.txt > +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt > @@ -225,6 +225,7 @@ lsi LSI Corp. (LSI Logic) > lwn Liebherr-Werk Nenzing GmbH > macnica Macnica Americas > marvell Marvell Technology Group Ltd. > +maxbotix MaxBotix Inc. > maxim Maxim Integrated Products > mbvl Mobiveil Inc. > mcube mCube This part looks fine and could get my Reviewed-by if you split it off as "dt-bindings: Add vendor prefix for MaxBotix" and add a sentence about the company in its commit message. You might want to CC the vendor, if you're not contracted by them. Regards, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg)