From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD912C433DF for ; Wed, 12 Aug 2020 10:25:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 86A342076B for ; Wed, 12 Aug 2020 10:25:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="M7fjpYUr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727038AbgHLKZu (ORCPT ); Wed, 12 Aug 2020 06:25:50 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:22776 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726595AbgHLKZt (ORCPT ); Wed, 12 Aug 2020 06:25:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1597227947; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=o7xZf6bRAQ1fAn5OtHzaQRhzaOM4m+C5MJxnLgV/A0w=; b=M7fjpYUr3yQGphKPvkT7YdheDLTF++Jce/ljt5I1reGFgZ8Es9fvBqj76z53tLXbgZMmfl vsYOEXQ1P4trLS6gg5ICPab870FadsW0lz75KHbEqTJE34VmNkHmN2uWChHOnjpvAxJLQX 1S76AfEsMMpfh7UcWkIpZcJNiCEX6uI= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-295-JqgksIIUMcurcbMs6RXipA-1; Wed, 12 Aug 2020 06:25:45 -0400 X-MC-Unique: JqgksIIUMcurcbMs6RXipA-1 Received: by mail-wr1-f72.google.com with SMTP id m7so727047wrb.20 for ; Wed, 12 Aug 2020 03:25:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=o7xZf6bRAQ1fAn5OtHzaQRhzaOM4m+C5MJxnLgV/A0w=; b=J0xGjwddk/V/Hwzz1BJzC6ZZ1gy5EeIgsVuxx9XkQ24fUESnbRUDg2tozwgGbmIpCf BMlBOjS0vgfCMrQNGXC02VAPQCepcOLOZwV5QTyczSC2A4cP0aJHfDV7oDY3Zy7GbSCZ vCJAMel4HRMnmeL0ChH3HRgdECuJLtSjo9qdpaHFjmCK4SkfpwSGFf4G8TfYsc+aNzJV i3VyqGTALC9eqD9d97VhCEAhxitM1JNSPG2jq7JBT0HVXWkwORvaZ1UJQy+ukgX6o8fT fgn7VKVKDXpWWslc9sHO6T2q9mHWe1Lgu1NgyODDT/4YB6GcKCaSos3mVE1QWzwF1o07 /vMQ== X-Gm-Message-State: AOAM533ROiAgtEj8qPF66BVOl1xYoWseMRscqqk6GTlPF/8UTZIr4hdM CeZLHw7bXlI7FzVPzYBj6KQ55BJL27wFAN/uyp+998osO8MYdJ9thvxejzLlRdP3i8bVsd08gnP NfN+IkS/8x2xjPcSX1c/MQIuU X-Received: by 2002:adf:c64d:: with SMTP id u13mr3988971wrg.114.1597227944529; Wed, 12 Aug 2020 03:25:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyVDh+Aq9bZWdTR8hkH8hhARMdwQlEpkxgYel5SlF6fjQlpnIdFxMi09Uh4ydaLsX5ip7iBcA== X-Received: by 2002:adf:c64d:: with SMTP id u13mr3988958wrg.114.1597227944318; Wed, 12 Aug 2020 03:25:44 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:744e:cb44:4103:26d3? ([2001:b07:6468:f312:744e:cb44:4103:26d3]) by smtp.gmail.com with ESMTPSA id d21sm3171340wmd.41.2020.08.12.03.25.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Aug 2020 03:25:43 -0700 (PDT) Subject: Re: [PATCH] KVM: x86/pmu: Add '.exclude_hv = 1' for guest perf_event To: Like Xu , Peter Zijlstra Cc: Yao , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200812050722.25824-1-like.xu@linux.intel.com> From: Paolo Bonzini Message-ID: <5c41978e-8341-a179-b724-9aa6e7e8a073@redhat.com> Date: Wed, 12 Aug 2020 12:25:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <20200812050722.25824-1-like.xu@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/08/20 07:07, Like Xu wrote: > To emulate PMC counter for guest, KVM would create an > event on the host with 'exclude_guest=0, exclude_hv=0' > which simply makes no sense and is utterly broken. > > To keep perf semantics consistent, any event created by > pmc_reprogram_counter() should both set exclude_hv and > exclude_host in the KVM context. > > Message-ID: <20200811084548.GW3982@worktop.programming.kicks-ass.net> > Signed-off-by: Like Xu > --- > arch/x86/kvm/pmu.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/x86/kvm/pmu.c b/arch/x86/kvm/pmu.c > index 67741d2a0308..6a30763a10d7 100644 > --- a/arch/x86/kvm/pmu.c > +++ b/arch/x86/kvm/pmu.c > @@ -108,6 +108,7 @@ static void pmc_reprogram_counter(struct kvm_pmc *pmc, u32 type, > .exclude_host = 1, > .exclude_user = exclude_user, > .exclude_kernel = exclude_kernel, > + .exclude_hv = 1, > .config = config, > }; > > x86 does not have a hypervisor privilege level, so it never uses exclude_hv; exclude_host already excludes all root mode activity for both ring0 and ring3. Paolo