All of lore.kernel.org
 help / color / mirror / Atom feed
From: Juergen Gross <jgross@suse.com>
To: staskins@amazon.com
Cc: jakub.kicinski@netronome.com, hpa@zytor.com, mcroce@redhat.com,
	tglx@linutronix.de, ggarcia@abra.uab.cat, daniel@iogearbox.net,
	x86@kernel.org, mingo@redhat.com, xen-devel@lists.xenproject.org,
	axboe@kernel.dk, konrad.wilk@oracle.com, amir.jer.levy@intel.com,
	paul.durrant@citrix.com, stefanha@redhat.com,
	dsa@cumulusnetworks.com, boris.ostrovsky@oracle.com,
	linux-block@vger.kernel.org, wei.liu2@citrix.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	davem@davemloft.net, dwmw@amazon.co.uk, roger.pau@citrix.com
Subject: Re: [PATCH 2/3] xen netback: add fault injection facility
Date: Fri, 20 Apr 2018 15:00:28 +0200	[thread overview]
Message-ID: <5c4e4f3d-03ce-b517-d451-3229c0d542c0@suse.com> (raw)
In-Reply-To: <909fd3b2-19e8-8c13-6ede-cfd6051c6f1d@amazon.com>

On 20/04/18 14:52, staskins@amazon.com wrote:
> On 04/20/18 13:25, Juergen Gross wrote:
>> On 20/04/18 12:47, Stanislav Kinsburskii wrote:
>>> +    for (fi = 0; fi < XENVIF_FI_MAX; fi++) {
>>> +        vfi->faults[fi] = xen_fi_dir_add(vfi->dir,
>>> +                xenvif_fi_names[fi]);
>> How does this work? xenvif_fi_names[] is an empty array and this is the
>> only reference to it. Who is allocating the memory for that array?
> 
> Well, it works in the way one adds a var to enum (which is used as a key
> later) and a corresponding string into the array (which is used as a
> name for the fault directory in sysfs).

Then you should size the array via XENVIF_FI_MAX.


Juergen

  parent reply	other threads:[~2018-04-20 13:00 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-20 10:47 [PATCH 0/3] Introduce Xen fault injection facility Stanislav Kinsburskii
2018-04-20 10:47 ` Stanislav Kinsburskii
2018-04-20 10:47 ` [PATCH 1/3] xen: add generic " Stanislav Kinsburskii
2018-04-20 10:47   ` Stanislav Kinsburskii
2018-04-20 10:59   ` Juergen Gross
2018-04-20 10:59   ` Juergen Gross
2018-04-20 12:45     ` staskins
2018-04-20 12:45       ` staskins
2018-04-20 12:45     ` staskins
2018-04-20 10:47 ` Stanislav Kinsburskii
2018-04-20 10:47 ` [PATCH 2/3] xen netback: add " Stanislav Kinsburskii
2018-04-20 10:47 ` Stanislav Kinsburskii
2018-04-20 10:47   ` Stanislav Kinsburskii
2018-04-20 11:25   ` Juergen Gross
2018-04-20 11:25   ` Juergen Gross
2018-04-20 12:52     ` staskins
2018-04-20 12:52     ` staskins
2018-04-20 12:52       ` staskins
2018-04-20 13:00       ` Juergen Gross
2018-04-20 13:00       ` Juergen Gross [this message]
2018-04-20 13:02         ` staskins
2018-04-20 13:02         ` staskins
2018-04-20 13:02           ` staskins
2018-04-23  9:58   ` Wei Liu
2018-04-23  9:58   ` Wei Liu
2018-04-20 10:47 ` [PATCH 3/3] xen blkback: " Stanislav Kinsburskii
2018-04-20 10:47 ` Stanislav Kinsburskii
2018-04-20 10:47   ` Stanislav Kinsburskii
2018-04-20 11:28   ` Juergen Gross
2018-04-20 12:53     ` staskins
2018-04-20 12:53       ` staskins
2018-04-20 12:53     ` staskins
2018-04-20 11:28   ` Juergen Gross
2018-04-22 15:41   ` kbuild test robot
2018-04-22 15:41   ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5c4e4f3d-03ce-b517-d451-3229c0d542c0@suse.com \
    --to=jgross@suse.com \
    --cc=amir.jer.levy@intel.com \
    --cc=axboe@kernel.dk \
    --cc=boris.ostrovsky@oracle.com \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=dsa@cumulusnetworks.com \
    --cc=dwmw@amazon.co.uk \
    --cc=ggarcia@abra.uab.cat \
    --cc=hpa@zytor.com \
    --cc=jakub.kicinski@netronome.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mcroce@redhat.com \
    --cc=mingo@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=paul.durrant@citrix.com \
    --cc=roger.pau@citrix.com \
    --cc=staskins@amazon.com \
    --cc=stefanha@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=wei.liu2@citrix.com \
    --cc=x86@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.