All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jacob Kroon" <jacob.kroon@gmail.com>
To: Changqing Li <changqing.li@windriver.com>,
	openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH] xinit: add rxvt in RDEPENDS
Date: Mon, 22 Jun 2020 06:40:38 +0200	[thread overview]
Message-ID: <5c541bf2-f2ee-f792-3371-99d577d3f8cb@gmail.com> (raw)
In-Reply-To: <20200622015153.3877288-1-changqing.li@windriver.com>

On 6/22/20 3:51 AM, Changqing Li wrote:
> From: Changqing Li <changqing.li@windriver.com>
> 
> fix below error:
> /etc/X11/xinit/xinitrc: line 55: exec: xterm: not found
> 
> by default, xinit will generate /etc/X11/xinit/xinitrc,
> and have below config in it:
> XTERM -geometry 80x50+494+51 &
> XTERM -geometry 80x20+494-0 &
> exec XTERM -geometry 80x66+0+0 -name login
> 
> the default XTERM is xterm, but xterm is in meta-oe,
> use rxvt instead
> 
> Signed-off-by: Changqing Li <changqing.li@windriver.com>
> ---
>   meta/recipes-graphics/xorg-app/xinit_1.4.1.bb | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-graphics/xorg-app/xinit_1.4.1.bb b/meta/recipes-graphics/xorg-app/xinit_1.4.1.bb
> index c9e28d9bba..2f2ba3af71 100644
> --- a/meta/recipes-graphics/xorg-app/xinit_1.4.1.bb
> +++ b/meta/recipes-graphics/xorg-app/xinit_1.4.1.bb
> @@ -19,4 +19,7 @@ SRC_URI[sha256sum] = "de9b8f617b68a70f6caf87da01fcf0ebd2b75690cdcba9c921d0ef54fa
>   
>   EXTRA_OECONF = "ac_cv_path_MCOOKIE=${bindir}/mcookie"
>   
> -RDEPENDS_${PN} += "util-linux-mcookie"
> +PACKAGECONFIG ??= "xterm"
> +PACKAGECONFIG[xterm] = "--with-xterm=rxvt,,,"
> +

Maybe "rxvt" would be a more suitable name for the PACKAGECONFIG ?

Jacob

  reply	other threads:[~2020-06-22  4:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-22  1:51 [PATCH] xinit: add rxvt in RDEPENDS Changqing Li
2020-06-22  4:40 ` Jacob Kroon [this message]
2020-06-22  7:28   ` [OE-core] " Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5c541bf2-f2ee-f792-3371-99d577d3f8cb@gmail.com \
    --to=jacob.kroon@gmail.com \
    --cc=changqing.li@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.