From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65C63C43461 for ; Thu, 10 Sep 2020 10:29:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 20274206BE for ; Thu, 10 Sep 2020 10:29:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="LxFSj6Ls" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730760AbgIJK3i (ORCPT ); Thu, 10 Sep 2020 06:29:38 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:31671 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726725AbgIJK3e (ORCPT ); Thu, 10 Sep 2020 06:29:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1599733772; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=r+LkQBoRDw9SZhPCxjEbsY2U2Q+IYMEJJtXIh9WrTFE=; b=LxFSj6LsN/bvdxuk3dNZi4eK8EPszIPZv/97Oqsfzjfje0bbUdGOoPx7ZslKoMHCDljm8K IeYCeBgaha0kpGc0UOq8rVRD9x84p+PXjRGDZAXFvVaHo+/FkZwaQO74TLGnla4tjt0cgz TcmkdqdXhtzyb0CPHMsmNhhxbGY9mcw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-203-FELPoc0tPVmlrp_IvtWaJQ-1; Thu, 10 Sep 2020 06:29:29 -0400 X-MC-Unique: FELPoc0tPVmlrp_IvtWaJQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8A23F80EDA1; Thu, 10 Sep 2020 10:29:27 +0000 (UTC) Received: from [10.36.113.88] (ovpn-113-88.ams2.redhat.com [10.36.113.88]) by smtp.corp.redhat.com (Postfix) with ESMTP id D701B5C1CF; Thu, 10 Sep 2020 10:29:24 +0000 (UTC) Subject: Re: [RFC 5/5] mm, page_alloc: disable pcplists during page isolation To: Vlastimil Babka , Michal Hocko Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Pavel Tatashin , Oscar Salvador , Joonsoo Kim References: <20200907163628.26495-1-vbabka@suse.cz> <20200907163628.26495-6-vbabka@suse.cz> <20200909113647.GG7348@dhcp22.suse.cz> From: David Hildenbrand Autocrypt: addr=david@redhat.com; prefer-encrypt=mutual; keydata= mQINBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABtCREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT6JAlgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63W5Ag0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAGJAjwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat GmbH Message-ID: <5c5753b4-8cb9-fa02-a0fa-d5ca22731cbb@redhat.com> Date: Thu, 10 Sep 2020 12:29:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09.09.20 13:55, Vlastimil Babka wrote: > On 9/9/20 1:36 PM, Michal Hocko wrote: >> On Wed 09-09-20 12:48:54, Vlastimil Babka wrote: >>> Here's a version that will apply on top of next-20200908. The first 4 patches need no change. >>> >>> ----8<---- >>> >From 8febc17272b8e8b378e2e5ea5e76b2616f029c5b Mon Sep 17 00:00:00 2001 >>> From: Vlastimil Babka >>> Date: Mon, 7 Sep 2020 17:20:39 +0200 >>> Subject: [PATCH] mm, page_alloc: disable pcplists during page isolation >>> >>> Page isolation can race with process freeing pages to pcplists in a way that >>> a page from isolated pageblock can end up on pcplist. This can be fixed by >>> repeated draining of pcplists, as done by patch "mm/memory_hotplug: drain >>> per-cpu pages again during memory offline" in [1]. >>> >>> David and Michal would prefer that this race was closed in a way that callers >>> of page isolation don't need to care about drain. David suggested disabling >>> pcplists usage completely during page isolation, instead of repeatedly draining >>> them. >>> >>> To achieve this without adding special cases in alloc/free fastpath, we can use >>> the same 'trick' as boot pagesets - when pcp->high is 0, any pcplist addition >>> will be immediately flushed. >>> >>> The race can thus be closed by setting pcp->high to 0 and draining pcplists >>> once in start_isolate_page_range(). The draining will serialize after processes >>> that already disabled interrupts and read the old value of pcp->high in >>> free_unref_page_commit(), and processes that have not yet disabled interrupts, >>> will observe pcp->high == 0 when they are rescheduled, and skip pcplists. >>> This guarantees no stray pages on pcplists in zones where isolation happens. >>> >>> We can use the variable zone->nr_isolate_pageblock (protected by zone->lock) >>> to detect transitions from 0 to 1 (to change pcp->high to 0 and issue drain) >>> and from 1 to 0 (to restore original pcp->high and batch values cached in >>> struct zone). We have to avoid external updates to high and batch by taking >>> pcp_batch_high_lock. To allow multiple isolations in parallel, change this >>> lock from mutex to rwsem. >>> >>> For callers that pair start_isolate_page_range() with >>> undo_isolated_page_range() properly, this is transparent. Currently that's >>> alloc_contig_range(). __offline_pages() doesn't call undo_isolated_page_range() >>> in the succes case, so it has to be carful to handle restoring pcp->high and batch >>> and unlocking pcp_batch_high_lock. >> >> I was hoping that it would be possible to have this completely hidden >> inside start_isolate_page_range code path. > > I hoped so too, but we can't know the moment when all processes that were in the > critical part of freeing pages to pcplists have moved on (they might have been > rescheduled). > We could change free_unref_page() to disable IRQs sooner, before > free_unref_page_prepare(), or at least the get_pfnblock_migratetype() part. Then > after the single drain, we should be safe, AFAICS? At least moving it before getting the migratetype should not be that severe? > RT guys might not be happy though, but it's much simpler than this patch. I > still like some of the cleanups in 1-4 though tbh :) It would certainly make this patch much simpler. Do you have a prototype lying around? -- Thanks, David / dhildenb