From: "Jürgen Groß" <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>,
George Dunlap <george.dunlap@citrix.com>
Cc: "Stefano Stabellini" <sstabellini@kernel.org>,
"Julien Grall" <julien@xen.org>, "Wei Liu" <wl@xen.org>,
"Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Paul Durrant" <paul@xen.org>,
"Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>,
xen-devel@lists.xenproject.org,
"Ian Jackson" <ian.jackson@citrix.com>
Subject: Re: [Xen-devel] [PATCH for-4.13 2/2] Rationalize max_grant_frames and max_maptrack_frames handling
Date: Wed, 27 Nov 2019 10:38:14 +0100 [thread overview]
Message-ID: <5c591298-1321-614c-73a7-364df1ef6d89@suse.com> (raw)
In-Reply-To: <230ff6db-0cf8-b10e-b1b2-4cac12e2b01d@suse.com>
On 27.11.19 10:25, Jan Beulich wrote:
> On 27.11.2019 05:32, Jürgen Groß wrote:
>> On 26.11.19 18:17, George Dunlap wrote:
>>> --- a/tools/libxl/libxl.h
>>> +++ b/tools/libxl/libxl.h
>>> @@ -364,8 +364,8 @@
>>> */
>>> #define LIBXL_HAVE_BUILDINFO_GRANT_LIMITS 1
>>>
>>> -#define LIBXL_MAX_GRANT_FRAMES_DEFAULT 32
>>> -#define LIBXL_MAX_MAPTRACK_FRAMES_DEFAULT 1024
>>> +#define LIBXL_MAX_GRANT_FRAMES_DEFAULT 0
>>> +#define LIBXL_MAX_MAPTRACK_FRAMES_DEFAULT 0
>>
>> I'd rather use -1 for the "not specified" value. This allows to set e.g.
>> the maptrack frames to 0 for non-driver domains.
>
> Yes. But it in turn wouldn't allow taking 0 to mean "default" in the
> hypervisor.
That is a logical consequence, yes.
Juergen
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-11-27 9:38 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-26 17:17 [Xen-devel] [PATCH for-4.13 1/2] python/xc.c: Remove trailing whitespace George Dunlap
2019-11-26 17:17 ` [Xen-devel] [PATCH for-4.13 2/2] Rationalize max_grant_frames and max_maptrack_frames handling George Dunlap
2019-11-26 17:30 ` George Dunlap
2019-11-27 4:34 ` Jürgen Groß
2019-11-27 12:07 ` George Dunlap
2019-11-27 12:15 ` Jürgen Groß
2019-11-26 17:32 ` Durrant, Paul
2019-11-26 17:36 ` Ian Jackson
2019-11-27 8:42 ` Durrant, Paul
2019-11-27 11:10 ` Ian Jackson
2019-11-27 11:13 ` Durrant, Paul
2019-11-27 22:32 ` Hans van Kranenburg
2019-11-28 5:57 ` Jürgen Groß
2019-11-28 14:54 ` George Dunlap
2019-11-28 15:33 ` Hans van Kranenburg
2019-11-28 15:43 ` Jürgen Groß
2019-11-27 4:32 ` Jürgen Groß
2019-11-27 9:25 ` Jan Beulich
2019-11-27 9:38 ` Jürgen Groß [this message]
2019-11-27 10:40 ` George Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c591298-1321-614c-73a7-364df1ef6d89@suse.com \
--to=jgross@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=ian.jackson@citrix.com \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=konrad.wilk@oracle.com \
--cc=marmarek@invisiblethingslab.com \
--cc=paul@xen.org \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.