From: Anand Jain <anand.jain@oracle.com>
To: Johannes Thumshirn <johannes.thumshirn@wdc.com>,
David Sterba <dsterba@suse.com>
Cc: linux-btrfs@vger.kernel.org, Naohiro Aota <naohiro.aota@wdc.com>,
Damien Le Moal <damien.lemoal@wdc.com>
Subject: Re: [PATCH v3] btrfs: zoned: revert "btrfs: zoned: fail mount if the device does not support zone append"
Date: Fri, 2 Jul 2021 23:33:35 +0800 [thread overview]
Message-ID: <5c688f92-e07d-a1d7-685f-f58979ef87bc@oracle.com> (raw)
In-Reply-To: <2069666c4c5f68fafe0cfefdbc880fa6b4969217.1625225912.git.johannes.thumshirn@wdc.com>
On 2/7/21 7:38 pm, Johannes Thumshirn wrote:
> Now that commit f34ee1dce642 ("dm crypt: Fix zoned block device support")
> is merged in master, the device-mapper code can fully emulate zone append.
> So there's no need for this check anymore.
>
> This reverts commit 1d68128c107a ("btrfs: zoned: fail mount if the device
> does not support zone append").
>
> Cc: Naohiro Aota <naohiro.aota@wdc.com>
> Cc: Damien Le Moal <damien.lemoal@wdc.com>
> Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Reviewed-by: Anand Jain <anand.jain@oracle.com>
So now zone_info::max_zone_append_size should get removed as part of the
other patch - [PATCH v2] btrfs: zoned: remove fs_info->max_zone_append_size
Thanks, Anand
> ---
> fs/btrfs/zoned.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/fs/btrfs/zoned.c b/fs/btrfs/zoned.c
> index 297c0b1c0634..e4087a2364a2 100644
> --- a/fs/btrfs/zoned.c
> +++ b/fs/btrfs/zoned.c
> @@ -354,13 +354,6 @@ int btrfs_get_dev_zone_info(struct btrfs_device *device)
> if (!IS_ALIGNED(nr_sectors, zone_sectors))
> zone_info->nr_zones++;
>
> - if (bdev_is_zoned(bdev) && zone_info->max_zone_append_size == 0) {
> - btrfs_err(fs_info, "zoned: device %pg does not support zone append",
> - bdev);
> - ret = -EINVAL;
> - goto out;
> - }
> -
> zone_info->seq_zones = bitmap_zalloc(zone_info->nr_zones, GFP_KERNEL);
> if (!zone_info->seq_zones) {
> ret = -ENOMEM;
>
prev parent reply other threads:[~2021-07-02 15:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-02 11:38 [PATCH v3] btrfs: zoned: revert "btrfs: zoned: fail mount if the device does not support zone append" Johannes Thumshirn
2021-07-02 12:50 ` Neal Gompa
2021-07-02 13:11 ` David Sterba
2021-07-02 15:33 ` Anand Jain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c688f92-e07d-a1d7-685f-f58979ef87bc@oracle.com \
--to=anand.jain@oracle.com \
--cc=damien.lemoal@wdc.com \
--cc=dsterba@suse.com \
--cc=johannes.thumshirn@wdc.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=naohiro.aota@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.