All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-arm@nongnu.org
Subject: Re: [PATCH v5 09/22] target/arm: prepare for multiple dynamic XMLs
Date: Wed, 15 Jan 2020 12:21:50 -1000	[thread overview]
Message-ID: <5c6987f3-0c6d-22d4-af11-773741f6613a@linaro.org> (raw)
In-Reply-To: <20200114150953.27659-10-alex.bennee@linaro.org>

On 1/14/20 5:09 AM, Alex Bennée wrote:
> We will want to generate similar dynamic XML for gdbstub support of
> SVE registers (the upstream doesn't use XML). To that end lightly
> rename a few things to make the distinction.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>  target/arm/cpu.h     | 20 +++++++++++++-------
>  target/arm/gdbstub.c | 30 +++++++++++++++---------------
>  target/arm/helper.c  |  4 ++--
>  3 files changed, 30 insertions(+), 24 deletions(-)

It seems to me, that if vg were present in the xml, and honored by gdb, that
the xml for the rest of the registers *could* describe the maximum register
width as opposed to the current register width.  At which point this wouldn't
need to be dynamic at all -- merely have a comment next to ARM_MAX_VQ that
changes must be reflected in the gdb xml file too.  Which I expect to never happen.

But again, this is how gdb works today, so
Acked-by: Richard Henderson <richard.henderson@linaro.org>


r~


  reply	other threads:[~2020-01-15 22:22 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-14 15:09 [PATCH v5 00/22] gdbstub refactor and SVE support (+check-tcg tweaks) Alex Bennée
2020-01-14 15:09 ` [PATCH v5 01/22] gdbstub: make GDBState static and have common init function Alex Bennée
2020-01-14 15:09 ` [PATCH v5 02/22] gdbstub: stop passing GDBState * around and use global Alex Bennée
2020-01-16 10:05   ` Damien Hedde
2020-01-16 15:07   ` Philippe Mathieu-Daudé
2020-01-14 15:09 ` [PATCH v5 03/22] gdbstub: move str_buf to GDBState and use GString Alex Bennée
2020-01-14 15:09 ` [PATCH v5 04/22] gdbstub: move mem_buf to GDBState and use GByteArray Alex Bennée
2020-01-14 15:09 ` [PATCH v5 05/22] gdbstub: add helper for 128 bit registers Alex Bennée
2020-01-14 15:09 ` [PATCH v5 06/22] target/arm: use gdb_get_reg helpers Alex Bennée
2020-01-14 15:09 ` [PATCH v5 07/22] target/m68k: " Alex Bennée
2020-01-14 15:09 ` [PATCH v5 08/22] gdbstub: extend GByteArray to read register helpers Alex Bennée
2020-01-14 15:09   ` Alex Bennée
2020-01-15  5:53   ` David Gibson
2020-01-15  5:53     ` David Gibson
2020-01-16  9:58   ` Damien Hedde
2020-01-16  9:58     ` Damien Hedde
2020-01-14 15:09 ` [PATCH v5 09/22] target/arm: prepare for multiple dynamic XMLs Alex Bennée
2020-01-15 22:21   ` Richard Henderson [this message]
2020-01-14 15:09 ` [PATCH v5 10/22] target/arm: explicitly encode regnum in our XML Alex Bennée
2020-01-14 15:09 ` [PATCH v5 11/22] target/arm: default SVE length to 64 bytes for linux-user Alex Bennée
2020-01-14 15:09 ` [PATCH v5 12/22] target/arm: generate xml description of our SVE registers Alex Bennée
2020-01-15 22:16   ` Richard Henderson
2020-01-14 15:09 ` [PATCH v5 13/22] tests/tcg: add a configure compiler check for ARMv8.1 and SVE Alex Bennée
2020-01-15 22:24   ` Richard Henderson
2020-01-14 15:09 ` [PATCH v5 14/22] target/arm: don't bother with id_aa64pfr0_read for USER_ONLY Alex Bennée
2020-01-14 15:09 ` [PATCH v5 15/22] tests/tcg/aarch64: userspace system register test Alex Bennée
2020-01-15 22:30   ` Richard Henderson
2020-01-14 15:09 ` [PATCH v5 16/22] configure: allow user to specify what gdb to use Alex Bennée
2020-01-15 22:31   ` Richard Henderson
2020-01-14 15:09 ` [PATCH v5 17/22] tests/guest-debug: add a simple test runner Alex Bennée
2020-01-15 22:40   ` Richard Henderson
2020-01-15 22:43   ` Richard Henderson
2020-01-14 15:09 ` [PATCH v5 18/22] tests/tcg/aarch64: add a gdbstub testcase for SVE registers Alex Bennée
2020-01-15 22:54   ` Richard Henderson
2020-01-16  7:36     ` Alex Bennée
2020-01-14 15:09 ` [PATCH v5 19/22] tests/tcg/aarch64: add SVE iotcl test Alex Bennée
2020-01-15 22:46   ` Richard Henderson
2020-01-14 15:09 ` [PATCH v5 20/22] tests/tcg/aarch64: add test-sve-ioctl guest-debug test Alex Bennée
2020-01-15 23:07   ` Richard Henderson
2020-02-04 21:45     ` Alex Bennée
2020-02-05 10:19       ` Richard Henderson
2020-02-05 11:49         ` Andrew Jones
2020-01-14 15:09 ` [PATCH v5 21/22] gdbstub: change GDBState.last_packet to GByteArray Alex Bennée
2020-01-15 23:10   ` Richard Henderson
2020-01-14 15:09 ` [PATCH v5 22/22] gdbstub: do not split gdb_monitor_write payload Alex Bennée
2020-01-15 23:11   ` Richard Henderson
2020-01-14 18:57 ` [PATCH v5 00/22] gdbstub refactor and SVE support (+check-tcg tweaks) no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5c6987f3-0c6d-22d4-af11-773741f6613a@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=alex.bennee@linaro.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.