From mboxrd@z Thu Jan  1 00:00:00 1970
From: Heinrich Schuchardt <xypron.glpk@gmx.de>
Date: Sat, 7 Dec 2019 21:51:22 +0100
Subject: [U-Boot] [PATCH v3 14/16] lib: crypto: add x509 parser
In-Reply-To: <20191206215006.GP9549@bill-the-cat>
References: <20191113004502.29986-1-takahiro.akashi@linaro.org>
 <20191113004502.29986-15-takahiro.akashi@linaro.org>
 <20191206215006.GP9549@bill-the-cat>
Message-ID: <5c7450c4-43c6-0083-f43b-bfa19c918cfb@gmx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
To: u-boot@lists.denx.de

On 12/6/19 10:50 PM, Tom Rini wrote:
> On Wed, Nov 13, 2019 at 09:45:00AM +0900, AKASHI Takahiro wrote:
>
>> Imported from linux kernel v5.3:
>>   x509.asn1 without changes
>>   x509_akid.asn1 without changes
>>   x509_parser.h without changes
>>   x509_cert_parser.c with changes marked as __UBOOT__
>>   x509_public_key.c with changes marked as __UBOOT__
>>
>> Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
>
> Applied to u-boot/master, thanks!
>
Hello Tom,

this patch causes a build error for rpi_0_w_defconfig with
CONFIG_X509_CERTIFICATE_PARSER=y:

In file included from include/linux/time.h:4,
                  from lib/crypto/x509_parser.h:8,
                  from lib/crypto/x509_cert_parser.c:20:
include/rtc.h:197:26: error: unknown type name ‘uchar’; did you mean
‘unchar’?
  void rtc_write8(int reg, uchar val);
                           ^~~~~
                           unchar
make[4]: *** [scripts/Makefile.build:279: lib/crypto/x509_cert_parser.o]
Error 1

The error is caused by:

include/linux/types.h:88:typedef unsigned char          unchar;

I have prepared a patch but will first run it through Gitlab:

https://gitlab.denx.de/u-boot/custodians/u-boot-efi/commit/f574992867cf40f48a381f88c1ac15a47dbe1baf

@Takahiro:
I am wondering why this did not show up in your tests. Did Tom miss a patch?

Best regards

Heinrich