From: Jan Beulich <jbeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: "Roger Pau Monné" <roger.pau@citrix.com>,
"Ian Jackson" <iwj@xenproject.org>,
Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] xenstore: Fix all builds
Date: Tue, 2 Feb 2021 09:49:07 +0100 [thread overview]
Message-ID: <5c957319-e0cd-4d9f-505b-cceb1a83bb00@suse.com> (raw)
In-Reply-To: <20210201233513.30923-1-andrew.cooper3@citrix.com>
On 02.02.2021 00:35, Andrew Cooper wrote:
> This diff is easier viewed through `cat -A`
>
> diff --git a/tools/xenstore/include/xenstore_state.h b/tools/xenstore/include/xenstore_state.h$
> index 1bd443f61a..f7e4da2b2c 100644$
> --- a/tools/xenstore/include/xenstore_state.h$
> +++ b/tools/xenstore/include/xenstore_state.h$
> @@ -21,7 +21,7 @@$
> #ifndef XENSTORE_STATE_H$
> #define XENSTORE_STATE_H$
> $
> -#if defined(__FreeBSD__) ||M-BM- defined(__NetBSD__)$
> +#if defined(__FreeBSD__) || defined(__NetBSD__)$
> #include <sys/endian.h>$
> #else$
> #include <endian.h>$
>
> A non-breaking space isn't a valid C preprocessor token.
>
> Fixes: ffbb8aa282de ("xenstore: fix build on {Net/Free}BSD")
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
I wonder why you didn't throw this in right away, without
waiting for any acks.
Jan
next prev parent reply other threads:[~2021-02-02 8:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-01 23:35 [PATCH] xenstore: Fix all builds Andrew Cooper
2021-02-02 8:49 ` Jan Beulich [this message]
2021-02-02 9:19 ` Roger Pau Monné
2021-02-02 11:21 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c957319-e0cd-4d9f-505b-cceb1a83bb00@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=iwj@xenproject.org \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.