From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Lars-Peter Clausen <lars@metafoo.de>,
Krzysztof Kozlowski <krzk@kernel.org>
Cc: Sangbeom Kim <sbkim73@samsung.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
linux-samsung-soc@vger.kernel.org
Subject: Re: [RFT v2 2/5] ASoC: samsung: smdk_wm8580: Remove old platforms and drop mach-types usage
Date: Mon, 21 Nov 2016 12:21:17 +0100 [thread overview]
Message-ID: <5ca5b9a5-2355-2c9b-f0a9-bbc1375aa044@samsung.com> (raw)
In-Reply-To: <713e7f53-16b2-a510-e99e-77e785f8a7c1@metafoo.de>
On 11/21/2016 11:34 AM, Lars-Peter Clausen wrote:
> On 11/21/2016 11:30 AM, Sylwester Nawrocki wrote:
>> > On 11/20/2016 08:24 PM, Krzysztof Kozlowski wrote:
>>> >>
>>> >> Not tested. The driver did not override .platform_name which looks
>>> >> suspicious to me. However I did not want to add changes which could have
>>> >> some visible impact on output code.
>> >
>> > The patch looks good to me. However the existing smdk64xx sound support
>> > less so. I don't have smdk6410 set up for testing yet, possibly I get
>> > around that next week.
>> > Indeed it's strange .platform_name is not also "samsung-i2s.2".
>
> I think that is a fallout from commit a08485d8fdf6f ("ASoC: Samsung: Do not
> register samsung audio dma device as pdev"). Given nobody noticed this in
> the last 4 years maybe its time to drop this machine driver as well.
Yeah, looks like since that commit things are broken. Even though nobody
seems to be interested I'm inclined to not removing this machine driver
just yet, otherwise there will not be any board in mainline I could test
s3c64xx IP block related code changes. I'll try to find time to make this
working again.
--
Thanks,
Sylwester
WARNING: multiple messages have this Message-ID (diff)
From: s.nawrocki@samsung.com (Sylwester Nawrocki)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFT v2 2/5] ASoC: samsung: smdk_wm8580: Remove old platforms and drop mach-types usage
Date: Mon, 21 Nov 2016 12:21:17 +0100 [thread overview]
Message-ID: <5ca5b9a5-2355-2c9b-f0a9-bbc1375aa044@samsung.com> (raw)
In-Reply-To: <713e7f53-16b2-a510-e99e-77e785f8a7c1@metafoo.de>
On 11/21/2016 11:34 AM, Lars-Peter Clausen wrote:
> On 11/21/2016 11:30 AM, Sylwester Nawrocki wrote:
>> > On 11/20/2016 08:24 PM, Krzysztof Kozlowski wrote:
>>> >>
>>> >> Not tested. The driver did not override .platform_name which looks
>>> >> suspicious to me. However I did not want to add changes which could have
>>> >> some visible impact on output code.
>> >
>> > The patch looks good to me. However the existing smdk64xx sound support
>> > less so. I don't have smdk6410 set up for testing yet, possibly I get
>> > around that next week.
>> > Indeed it's strange .platform_name is not also "samsung-i2s.2".
>
> I think that is a fallout from commit a08485d8fdf6f ("ASoC: Samsung: Do not
> register samsung audio dma device as pdev"). Given nobody noticed this in
> the last 4 years maybe its time to drop this machine driver as well.
Yeah, looks like since that commit things are broken. Even though nobody
seems to be interested I'm inclined to not removing this machine driver
just yet, otherwise there will not be any board in mainline I could test
s3c64xx IP block related code changes. I'll try to find time to make this
working again.
--
Thanks,
Sylwester
next prev parent reply other threads:[~2016-11-21 11:21 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-20 19:24 [RFT v2 0/5] ASoC: samsung: Minor cleanup for old machines Krzysztof Kozlowski
2016-11-20 19:24 ` Krzysztof Kozlowski
2016-11-20 19:24 ` [PATCH v2 1/5] ASoC: samsung: Remove non-existing MACH dependencies Krzysztof Kozlowski
2016-11-20 19:24 ` Krzysztof Kozlowski
2016-11-20 19:24 ` [RFT v2 2/5] ASoC: samsung: smdk_wm8580: Remove old platforms and drop mach-types usage Krzysztof Kozlowski
2016-11-20 19:24 ` Krzysztof Kozlowski
2016-11-21 10:30 ` Sylwester Nawrocki
2016-11-21 10:30 ` Sylwester Nawrocki
2016-11-21 10:34 ` Lars-Peter Clausen
2016-11-21 10:34 ` Lars-Peter Clausen
2016-11-21 11:21 ` Sylwester Nawrocki [this message]
2016-11-21 11:21 ` Sylwester Nawrocki
2016-11-22 17:26 ` Applied "ASoC: samsung: smdk_wm8580: Remove old platforms and drop mach-types usage" to the asoc tree Mark Brown
2016-11-22 17:26 ` Mark Brown
2016-11-22 17:26 ` Mark Brown
2016-11-20 19:24 ` [PATCH v2 3/5] ASoC: samsung: Enable COMPILE_TEST for SmartQ and WM8580 Krzysztof Kozlowski
2016-11-20 19:24 ` Krzysztof Kozlowski
2016-11-20 19:24 ` [PATCH v2 4/5] ASoC: samsung: Enable COMPILE_TEST for entire Samsung ASoc Krzysztof Kozlowski
2016-11-20 19:24 ` Krzysztof Kozlowski
2016-11-20 19:24 ` [PATCH v2 5/5] ARM: s5pv210_defconfig: Remove old MACHs Krzysztof Kozlowski
2016-11-20 19:24 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ca5b9a5-2355-2c9b-f0a9-bbc1375aa044@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=krzk@kernel.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=perex@perex.cz \
--cc=sbkim73@samsung.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.