Re: [Qemu-devel] [PATCH v2 1/2] s390x/ais: enable ais when migration is available

From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Yi Min Zhao <zyimin@linux.vnet.ibm.com>,
	Cornelia Huck <cohuck@redhat.com>
Cc: Halil Pasic <pasic@linux.vnet.ibm.com>,
	David Hildenbrand <david@redhat.com>,
	qemu-devel <qemu-devel@nongnu.org>,
	Alexander Graf <agraf@suse.de>,
	"Jason J . Herne" <jjherne@linux.vnet.ibm.com>,
	Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH v2 1/2] s390x/ais: enable ais when migration is available
Date: Wed, 27 Sep 2017 09:02:48 +0200	[thread overview]
Message-ID: <5caeb93d-b436-d8c0-2706-fd3476b54ad0@de.ibm.com> (raw)
In-Reply-To: <7134b571-41dd-97c8-85b8-fb623babb016@linux.vnet.ibm.com>

On 09/27/2017 07:45 AM, Yi Min Zhao wrote:
> 
> 
> 在 2017/9/26 下午9:36, Christian Borntraeger 写道:
>> @@ -557,6 +557,12 @@ static void kvm_s390_flic_realize(DeviceState *dev, Error **errp)
>>       test_attr.group = KVM_DEV_FLIC_CLEAR_IO_IRQ;
>>       flic_state->clear_io_supported = !ioctl(flic_state->fd,
>>                                               KVM_HAS_DEVICE_ATTR, test_attr);
>> +    /* try enable the AIS facility */
>> +    test_attr.group = KVM_DEV_FLIC_AISM_ALL;
>> +    if (!ioctl(flic_state->fd, KVM_HAS_DEVICE_ATTR, test_attr)) {
>> +            kvm_vm_enable_cap(kvm_state, KVM_CAP_S390_AIS, 0);

yes, will fix.

> Is there an indention error?
> Except this, the code LGTM.
>> +    }
>> +
>>       return;
> 