From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E734CC636CC for ; Mon, 20 Feb 2023 08:44:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229604AbjBTIoy (ORCPT ); Mon, 20 Feb 2023 03:44:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58348 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231289AbjBTIot (ORCPT ); Mon, 20 Feb 2023 03:44:49 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 551E5C663 for ; Mon, 20 Feb 2023 00:44:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676882641; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2bIx447q7zOccwg9isjOzlMuhknxYljdkPuPhMeel7o=; b=Ocz3BL2Bi4nexqwzHsPjM28IP4BZ6seUMW7u/+WyrK9dzOXy9wYDQH2AcBwFQadPQSY6Z9 ezJkit7Lc1xN8ZDF492FLKCIr1V2GKj8ai6wL9HOU3Aqs8tMV4+0SHLeI2GyFqmvDbA/lz QL6vURZ0+R0eh7gnfpRuNyagfFtUuac= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-30-L-ZauuqdNDyu-TjD_F3nAg-1; Mon, 20 Feb 2023 03:43:59 -0500 X-MC-Unique: L-ZauuqdNDyu-TjD_F3nAg-1 Received: by mail-ed1-f71.google.com with SMTP id g24-20020a056402321800b004ace77022ebso932275eda.8 for ; Mon, 20 Feb 2023 00:43:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2bIx447q7zOccwg9isjOzlMuhknxYljdkPuPhMeel7o=; b=CnK78X2ELs5zKWRy1jN2zg3xMBXfKkhFte1SIEBKFtbqUrfHhJmU9+vwR12Ogd9aS0 rvtzI5lJ8kzZmIjA47Ix4gHBaEGW9DIWvVz9qLA1qUY57RMeMJh26dRd/5LzsWcVQJW2 J9tm5Vqq/asU8Pdsx8lNBGvgyfRX6fIdWPJKMaYa4QwtISvx+xYN6hLDt+ChJGM7rIBb bGbHnLQ1JbOjTN1vxDHhoL2bdHXtSM4SHRtgHOUrgtXL8leodEeSUPy7iP1XylMWMv4F V2Tklxn3IVVu2I9wdx9uV7pl6EgWjukSxfbNBlpsH9OKw7wjgQVxJw6tcZCxRBzZXZdM Er+w== X-Gm-Message-State: AO0yUKX8tj2SoBdJf/nSVgd/jUhUQ6FZJnJg3+OfuApKvZW6TDkGBQzC QbOonFWVDrUeU3KC3IdDe0ejHvA0f+Gx+pMV/y77KQ4mL0HT6Ssne5pcghkW4JtViOqPrga9fOc PLx6UwfkdDcc0U/dwonFYG1lQ/28= X-Received: by 2002:a17:906:f6c4:b0:8b1:20f4:44a3 with SMTP id jo4-20020a170906f6c400b008b120f444a3mr7979741ejb.7.1676882638562; Mon, 20 Feb 2023 00:43:58 -0800 (PST) X-Google-Smtp-Source: AK7set+58GGsB5PqX1g9IAc8g9ygEgGVI/hQd4d0eNE8503gRE129xA2uYyWHH8ochtavL3PvBJfDQ== X-Received: by 2002:a17:906:f6c4:b0:8b1:20f4:44a3 with SMTP id jo4-20020a170906f6c400b008b120f444a3mr7979726ejb.7.1676882638289; Mon, 20 Feb 2023 00:43:58 -0800 (PST) Received: from [10.40.98.142] ([78.108.130.194]) by smtp.gmail.com with ESMTPSA id hb22-20020a170906b89600b008b14d3978adsm5440924ejb.189.2023.02.20.00.43.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Feb 2023 00:43:57 -0800 (PST) Message-ID: <5cc2d613-d4fd-84e7-9791-963d69a66869@redhat.com> Date: Mon, 20 Feb 2023 09:43:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: API for setting colors of RGB backlit keyboard zones (was [PATCH V3] platform/x86: hp-wmi: Support omen backlight control wmi-acpi methods) Content-Language: en-US To: Rishit Bansal , Pavel Machek Cc: Mark Gross , linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, Linux LED Subsystem , Dan Murphy References: <20230131235027.36304-1-rishitbansal0@gmail.com> <9b761996-d522-b0f8-6472-10e40e09e036@redhat.com> <65a11a89-e780-6d60-a40e-cd3245780762@gmail.com> <02c96cfe-ab10-513f-fc36-f474dd227656@gmail.com> <544484b9-c0ac-2fd0-1f41-8fa94cb94d4b@redhat.com> <3c48e204-780c-f78c-8219-267e297dc1e3@gmail.com> From: Hans de Goede In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org Hi, On 2/19/23 19:46, Rishit Bansal wrote: > > > On 19/02/23 18:50, Hans de Goede wrote: >> Hi, >> >> On 2/18/23 12:48, Pavel Machek wrote: >>> Hi! >>> >>> >>>>> I do agree with you that we need to avoid kbd_backlight in the name to avoid causing existing upower code to have weird interactions with this (it supports / assumes there is only 1 kbd_backlight LED class device). >>>>> >>>>> So lets go with just these 4: >>>>> >>>>> /sys/class/leds/hp_omen::kbd_zoned_backlight-1/ >>>>> /sys/class/leds/hp_omen::kbd_zoned_backlight-2/ >>>>> /sys/class/leds/hp_omen::kbd_zoned_backlight-3/ >>>>> /sys/class/leds/hp_omen::kbd_zoned_backlight-4/ >>>>> >>>>> Using the _zoned_ between kbd and baclight to avoid confusing the existing upower code. Then once this has landed we can look into extending upower support for this. >>>>> >>>>> Note the requested documentation patch should probably also explain that the _zoned_ was done deliberately to make current upower code ignore the devices. >>>>> >>> >>>> >>>> This makes sense, I agree that the global LED file will cause more confusion >>>> and hacks in the code. I'll start working on the  _zoned_ naming scheme with >>>> 4 files + documentation changes and make a patch for this soon! >>>> >>> >>> /sys/class/leds/:rgb:kbd_zoned_backlight-4/ is better than what was >>> suggested above. >> >> Ah yes using rgb for the color part of the name makes sense. >> >>> But we already use _1 suffix to deduplicate the, so >>> I'm not sure this is best naming. >> >> >> >> I guess we could try to actually name the zones, something like >> (no idea if this are indeed the 4 zones): >> >> :rgb:kbd_zoned_backlight-main >> :rgb:kbd_zoned_backlight-wasd >> :rgb:kbd_zoned_backlight-cursor >> :rgb:kbd_zoned_backlight-numpad >> >> Rishit any comments on this or improvements to it. > > Here is an image of how the 4 zones on the keyboard look like (https://imgur.com/a/iQdRWCM). I think we can call them "left", "middle", "right", and "wasd": > > :rgb:kbd_zoned_backlight-left > :rgb:kbd_zoned_backlight-middle > :rgb:kbd_zoned_backlight-right > :rgb:kbd_zoned_backlight-wasd Sounds good to me, lets go for this. Please add these names to the requested documentation update. Regards, Hans