From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56012) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aywWy-0001Vw-FX for qemu-devel@nongnu.org; Sat, 07 May 2016 03:20:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aywWt-00010c-Mo for qemu-devel@nongnu.org; Sat, 07 May 2016 03:20:03 -0400 Received: from mout.kundenserver.de ([217.72.192.73]:62937) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aywWt-00010W-B0 for qemu-devel@nongnu.org; Sat, 07 May 2016 03:19:59 -0400 References: <1462392752-17703-1-git-send-email-laurent@vivier.eu> <1462392752-17703-12-git-send-email-laurent@vivier.eu> <112be92e-e89e-f873-dbba-9dacca42ad6d@twiddle.net> From: Laurent Vivier Message-ID: <5cc42d87-ffed-9fca-28cb-9843d73739b9@vivier.eu> Date: Sat, 7 May 2016 09:19:46 +0200 MIME-Version: 1.0 In-Reply-To: <112be92e-e89e-f873-dbba-9dacca42ad6d@twiddle.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 11/52] target-m68k: allow to update flags with operation on words and bytes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson , qemu-devel@nongnu.org Cc: gerg@uclinux.org, schwab@linux-m68k.org, agraf@suse.de Le 06/05/2016 à 18:45, Richard Henderson a écrit : > On 05/04/2016 10:11 AM, Laurent Vivier wrote: >> Signed-off-by: Laurent Vivier >> --- >> target-m68k/cpu.h | 14 ++++- >> target-m68k/helper.c | 139 >> ++++++++++++++++++++++++++++++++++-------------- >> target-m68k/translate.c | 82 ++++++++++++++-------------- >> 3 files changed, 151 insertions(+), 84 deletions(-) > > I wonder if this shouldn't just be dropped, or squished into some of the > other flags-related patches? That said, While I was debugging this series it was very helpful to have this patch separated to bisect where it is broken (as it was in this one). So I think it is good to have this one separated from the others. > Reviewed-by: Richard Henderson Thanks, Laurent