From: Joshua Henderson <joshua.henderson@microchip.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3] qt5base: Qt KMS support does not depend on opengl
Date: Tue, 30 Oct 2018 14:41:33 -0700 [thread overview]
Message-ID: <5cdf69ae-4180-921e-146c-7f90f432b1b7@microchip.com> (raw)
In-Reply-To: <2357aab6-f2e6-54d4-0e37-63955864e94e@mind.be>
Arnout,
On 10/21/2018 04:18 PM, Arnout Vandecappelle wrote:
>
> On 13/02/2018 16:46, Joshua Henderson wrote:
>> Qt KMS support should not explicitly depend on the availability of opengl.
>> Don't explicitly disable KMS if opengl is not available and fallback to
>> detecting if libdrm is available before disabling kms.
>>
>> The scenario where this is necessary involves using the Qt linuxfb backend
>> "dumb buffer" support via the DRM API. This is new in Qt 5.9 [1] and only
>> requires KMS, but not opengl.
>
> ?This sounds like we should handle the Qt 5.6 case specially.
>
> ?However, on Qt 5.6, it builds fine with the -kms option, it just ends up not
> being used. That means we have a redundant dependency on libdrm, but that
> doesn't matter that much. Handling the Qt 5.6 case differently would make the
> code quite a bit more complicated.
>
> ?Therefore, I explained the above in the commit log an applied to master, thanks.
>
> ?Sorry it took so long.
No problem. Thanks Arnout.
Josh
prev parent reply other threads:[~2018-10-30 21:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-13 16:46 [Buildroot] [PATCH v3] qt5base: Qt KMS support does not depend on opengl Joshua Henderson
2018-03-15 16:45 ` Joshua Henderson
2018-10-21 23:18 ` Arnout Vandecappelle
2018-10-24 15:54 ` Peter Korsgaard
2018-10-30 21:41 ` Joshua Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5cdf69ae-4180-921e-146c-7f90f432b1b7@microchip.com \
--to=joshua.henderson@microchip.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.