From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E43523FC4 for ; Thu, 26 Aug 2021 00:20:59 +0000 (UTC) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id CAE0D580CEF; Wed, 25 Aug 2021 20:20:58 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 25 Aug 2021 20:20:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sholland.org; h= to:cc:references:from:subject:message-id:date:mime-version :in-reply-to:content-type:content-transfer-encoding; s=fm3; bh=5 ujsR+nWOM34qVhCf5iPx4BoztRKl0Ef/LKi3phS+UI=; b=cBa9ZeCTqXipij9Qf L+kzwosi2cv1djoF6kzDSrCZ030qkVzOB2pEdiBiTRcCsq2mdpCES4fSY7ivS4Eg tg7eOEQEMPbt5mZHHSRyaMPh12vCd/scNQ0LZaCWNV4gWgjdEju8qcrA9v0SU6w2 W0BcIzF3txTM6xNCNCjqrSnpRkrg32speLWFa3+NUZjXusf5769X5lQxUoxy2VOA /IATrEJuBTX7zEa3JY2pF6ko1gvGlOwSbZy5/H21Kkz5QKmxHN92NX7yyjPSwj9C I70BvUW1SOKX60m5SbC3k5TMw/TCKfg6FlBylws7S9uz9gNGu+kXTJhvZ26jdhwl Jf6Zg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=5ujsR+nWOM34qVhCf5iPx4BoztRKl0Ef/LKi3phS+ UI=; b=Q1tYLPCHfF/cdUS1nRjZFN0jAYRwejRNYXLaW6uYu2pEIoaFCZYkOU2DR qvCx03Zm1YtPixX6zEexSA9G5XvMARuf0VLWdOqZCTZQ885eqlX2LGOZAO6y4w51 KyheuycgwFmA7kvHJWsU8xcm2XJaR5APWSYfHdJGttjij+gtIx/IsZmJg5vzlnEN hN7/prKy2RzW1gBBM43XkPtuCepSR2Q2IS8Mdq416gkja6ZUe/AaapPG3ZlGLwFa nN+8YwkcZgkSJS8JuiqK8/IlaYFX+HMxcZMQfyBZzRIlP4hPCGlp92DLm9/tgD0B W7aNNQ8HN0nfJcRUxJxnDD8349faQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddruddutddgfedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepvfhfhffukffffgggjggtgfesthekredttdefjeenucfhrhhomhepufgrmhhu vghlucfjohhllhgrnhguuceoshgrmhhuvghlsehshhholhhlrghnugdrohhrgheqnecugg ftrfgrthhtvghrnhepvddttdejieduudfgffevteekffegffeguddtgfefkeduvedukeff hedtfeevuedvnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepshgrmhhuvghlsehshhholhhlrghnugdrohhrgh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 25 Aug 2021 20:20:55 -0400 (EDT) To: =?UTF-8?Q?Jernej_=c5=a0krabec?= , Maxime Ripard Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Icenowy Zheng , Rob Herring , Chen-Yu Tsai , Ulf Hansson , Linus Walleij , Alexandre Belloni , Andre Przywara References: <20210802062212.73220-1-icenowy@sipeed.com> <20210802062212.73220-11-icenowy@sipeed.com> <99a74950-fdc0-ecfe-e5f0-ba4a7d8751f0@sholland.org> <5432230.1UTMcGJKg4@jernej-laptop> From: Samuel Holland Subject: Re: [PATCH 10/17] clk: sunxi=ng: add support for R329 R-CCU Message-ID: <5d0489ac-0693-f1f0-17d5-bfe9ca5df0ff@sholland.org> Date: Wed, 25 Aug 2021 19:20:54 -0500 User-Agent: Mozilla/5.0 (X11; Linux ppc64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <5432230.1UTMcGJKg4@jernej-laptop> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 8/19/21 11:34 PM, Jernej Škrabec wrote: >>> +static void __init sun50i_r329_r_ccu_setup(struct device_node *node) >>> +{ >>> + void __iomem *reg; >>> + u32 val; >>> + int i; >>> + >>> + reg = of_io_request_and_map(node, 0, of_node_full_name(node)); >>> + if (IS_ERR(reg)) { >>> + pr_err("%pOF: Could not map clock registers\n", node); >>> + return; >>> + } >>> + >>> + /* Enable the lock bits and the output enable bits on all PLLs */ >>> + for (i = 0; i < ARRAY_SIZE(pll_regs); i++) { >>> + val = readl(reg + pll_regs[i]); >>> + val |= BIT(29) | BIT(27); >>> + writel(val, reg + pll_regs[i]); >>> + } >>> + >>> + /* >>> + * Force the I/O dividers of PLL-AUDIO1 to reset default value >>> + * >>> + * See the comment before pll-audio1 definition for the reason. >>> + */ >>> + >>> + val = readl(reg + SUN50I_R329_PLL_AUDIO1_REG); >>> + val &= ~BIT(1); >>> + val |= BIT(0); >>> + writel(val, reg + SUN50I_R329_PLL_AUDIO1_REG); >>> + >>> + i = sunxi_ccu_probe(node, reg, &sun50i_r329_r_ccu_desc); >>> + if (i) >>> + pr_err("%pOF: probing clocks fails: %d\n", node, i); >>> +} >>> + >>> +CLK_OF_DECLARE(sun50i_r329_r_ccu, "allwinner,sun50i-r329-r-ccu", >>> + sun50i_r329_r_ccu_setup); >> >> Please make this a platform driver. There is no particular reason why it >> needs to be an early OF clock provider. > > Why? It's good to have it as early clock provider. It has no dependencies and > other drivers that depends on it, like IR, can be deferred, if this is loaded > later. Another reason is so the driver can be built as a module. Each of these CCU drivers has 30k-70k of data in it (lots of pointers, plus lots of relocations). So it saves some RAM to only load the ones you need, especially if that is none of them. Regards, Samuel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44EA6C432BE for ; Thu, 26 Aug 2021 00:24:03 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 04AB661053 for ; Thu, 26 Aug 2021 00:24:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 04AB661053 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sholland.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:Subject:From:References:Cc:To:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=vJDgPOTt6LINsAV/90A665W8lYHaklS/q+2K5HKgMGM=; b=ithtvDKaiAHgnc6VYX6EC79VY8 Z+CjUemOlAPj3XYKw3EGmPlEoyw/jnPWHAc5iCBIdc15Om0hyBzcA4XDZm8bfud2s/zMb8RVQo4hP pKdXHzDX2z0eytuCdLuOkHtDMwegl4hk3TR/4VL7/+Z0xNbH+zINXsiG/DI0F6NQFa2F3GB00ZCq3 V8t0GOXvFqZyKYSmexEKmx1oDFuYRoAitP5OXTKNZsmOqsU9mB2NCyvqN0qgp2qbvPUAK6ATDhEZo wDK4maqg5Q7jBgE04Hyg6hIuA+FStqg/6swJ8UuAUwzCUIHWolBdP6WqeJrVVid1y+kc47WaM1xQD gEBvR/Sg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mJ38q-008m6h-7E; Thu, 26 Aug 2021 00:21:12 +0000 Received: from new3-smtp.messagingengine.com ([66.111.4.229]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mJ38j-008m5z-25 for linux-arm-kernel@lists.infradead.org; Thu, 26 Aug 2021 00:21:09 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id CAE0D580CEF; Wed, 25 Aug 2021 20:20:58 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 25 Aug 2021 20:20:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sholland.org; h= to:cc:references:from:subject:message-id:date:mime-version :in-reply-to:content-type:content-transfer-encoding; s=fm3; bh=5 ujsR+nWOM34qVhCf5iPx4BoztRKl0Ef/LKi3phS+UI=; b=cBa9ZeCTqXipij9Qf L+kzwosi2cv1djoF6kzDSrCZ030qkVzOB2pEdiBiTRcCsq2mdpCES4fSY7ivS4Eg tg7eOEQEMPbt5mZHHSRyaMPh12vCd/scNQ0LZaCWNV4gWgjdEju8qcrA9v0SU6w2 W0BcIzF3txTM6xNCNCjqrSnpRkrg32speLWFa3+NUZjXusf5769X5lQxUoxy2VOA /IATrEJuBTX7zEa3JY2pF6ko1gvGlOwSbZy5/H21Kkz5QKmxHN92NX7yyjPSwj9C I70BvUW1SOKX60m5SbC3k5TMw/TCKfg6FlBylws7S9uz9gNGu+kXTJhvZ26jdhwl Jf6Zg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=5ujsR+nWOM34qVhCf5iPx4BoztRKl0Ef/LKi3phS+ UI=; b=Q1tYLPCHfF/cdUS1nRjZFN0jAYRwejRNYXLaW6uYu2pEIoaFCZYkOU2DR qvCx03Zm1YtPixX6zEexSA9G5XvMARuf0VLWdOqZCTZQ885eqlX2LGOZAO6y4w51 KyheuycgwFmA7kvHJWsU8xcm2XJaR5APWSYfHdJGttjij+gtIx/IsZmJg5vzlnEN hN7/prKy2RzW1gBBM43XkPtuCepSR2Q2IS8Mdq416gkja6ZUe/AaapPG3ZlGLwFa nN+8YwkcZgkSJS8JuiqK8/IlaYFX+HMxcZMQfyBZzRIlP4hPCGlp92DLm9/tgD0B W7aNNQ8HN0nfJcRUxJxnDD8349faQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddruddutddgfedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepvfhfhffukffffgggjggtgfesthekredttdefjeenucfhrhhomhepufgrmhhu vghlucfjohhllhgrnhguuceoshgrmhhuvghlsehshhholhhlrghnugdrohhrgheqnecugg ftrfgrthhtvghrnhepvddttdejieduudfgffevteekffegffeguddtgfefkeduvedukeff hedtfeevuedvnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepshgrmhhuvghlsehshhholhhlrghnugdrohhrgh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 25 Aug 2021 20:20:55 -0400 (EDT) To: =?UTF-8?Q?Jernej_=c5=a0krabec?= , Maxime Ripard Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Icenowy Zheng , Rob Herring , Chen-Yu Tsai , Ulf Hansson , Linus Walleij , Alexandre Belloni , Andre Przywara References: <20210802062212.73220-1-icenowy@sipeed.com> <20210802062212.73220-11-icenowy@sipeed.com> <99a74950-fdc0-ecfe-e5f0-ba4a7d8751f0@sholland.org> <5432230.1UTMcGJKg4@jernej-laptop> From: Samuel Holland Subject: Re: [PATCH 10/17] clk: sunxi=ng: add support for R329 R-CCU Message-ID: <5d0489ac-0693-f1f0-17d5-bfe9ca5df0ff@sholland.org> Date: Wed, 25 Aug 2021 19:20:54 -0500 User-Agent: Mozilla/5.0 (X11; Linux ppc64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: <5432230.1UTMcGJKg4@jernej-laptop> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210825_172105_239481_525C29DB X-CRM114-Status: GOOD ( 19.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gOC8xOS8yMSAxMTozNCBQTSwgSmVybmVqIMWga3JhYmVjIHdyb3RlOgo+Pj4gK3N0YXRpYyB2 b2lkIF9faW5pdCBzdW41MGlfcjMyOV9yX2NjdV9zZXR1cChzdHJ1Y3QgZGV2aWNlX25vZGUgKm5v ZGUpCj4+PiArewo+Pj4gKwl2b2lkIF9faW9tZW0gKnJlZzsKPj4+ICsJdTMyIHZhbDsKPj4+ICsJ aW50IGk7Cj4+PiArCj4+PiArCXJlZyA9IG9mX2lvX3JlcXVlc3RfYW5kX21hcChub2RlLCAwLCBv Zl9ub2RlX2Z1bGxfbmFtZShub2RlKSk7Cj4+PiArCWlmIChJU19FUlIocmVnKSkgewo+Pj4gKwkJ cHJfZXJyKCIlcE9GOiBDb3VsZCBub3QgbWFwIGNsb2NrIHJlZ2lzdGVyc1xuIiwgbm9kZSk7Cj4+ PiArCQlyZXR1cm47Cj4+PiArCX0KPj4+ICsKPj4+ICsJLyogRW5hYmxlIHRoZSBsb2NrIGJpdHMg YW5kIHRoZSBvdXRwdXQgZW5hYmxlIGJpdHMgb24gYWxsIFBMTHMgKi8KPj4+ICsJZm9yIChpID0g MDsgaSA8IEFSUkFZX1NJWkUocGxsX3JlZ3MpOyBpKyspIHsKPj4+ICsJCXZhbCA9IHJlYWRsKHJl ZyArIHBsbF9yZWdzW2ldKTsKPj4+ICsJCXZhbCB8PSBCSVQoMjkpIHwgQklUKDI3KTsKPj4+ICsJ CXdyaXRlbCh2YWwsIHJlZyArIHBsbF9yZWdzW2ldKTsKPj4+ICsJfQo+Pj4gKwo+Pj4gKwkvKgo+ Pj4gKwkgKiBGb3JjZSB0aGUgSS9PIGRpdmlkZXJzIG9mIFBMTC1BVURJTzEgdG8gcmVzZXQgZGVm YXVsdCB2YWx1ZQo+Pj4gKwkgKgo+Pj4gKwkgKiBTZWUgdGhlIGNvbW1lbnQgYmVmb3JlIHBsbC1h dWRpbzEgZGVmaW5pdGlvbiBmb3IgdGhlIHJlYXNvbi4KPj4+ICsJICovCj4+PiArCj4+PiArCXZh bCA9IHJlYWRsKHJlZyArIFNVTjUwSV9SMzI5X1BMTF9BVURJTzFfUkVHKTsKPj4+ICsJdmFsICY9 IH5CSVQoMSk7Cj4+PiArCXZhbCB8PSBCSVQoMCk7Cj4+PiArCXdyaXRlbCh2YWwsIHJlZyArIFNV TjUwSV9SMzI5X1BMTF9BVURJTzFfUkVHKTsKPj4+ICsKPj4+ICsJaSA9IHN1bnhpX2NjdV9wcm9i ZShub2RlLCByZWcsICZzdW41MGlfcjMyOV9yX2NjdV9kZXNjKTsKPj4+ICsJaWYgKGkpCj4+PiAr CQlwcl9lcnIoIiVwT0Y6IHByb2JpbmcgY2xvY2tzIGZhaWxzOiAlZFxuIiwgbm9kZSwgaSk7Cj4+ PiArfQo+Pj4gKwo+Pj4gK0NMS19PRl9ERUNMQVJFKHN1bjUwaV9yMzI5X3JfY2N1LCAiYWxsd2lu bmVyLHN1bjUwaS1yMzI5LXItY2N1IiwKPj4+ICsJICAgICAgIHN1bjUwaV9yMzI5X3JfY2N1X3Nl dHVwKTsKPj4KPj4gUGxlYXNlIG1ha2UgdGhpcyBhIHBsYXRmb3JtIGRyaXZlci4gVGhlcmUgaXMg bm8gcGFydGljdWxhciByZWFzb24gd2h5IGl0Cj4+IG5lZWRzIHRvIGJlIGFuIGVhcmx5IE9GIGNs b2NrIHByb3ZpZGVyLgo+IAo+IFdoeT8gSXQncyBnb29kIHRvIGhhdmUgaXQgYXMgZWFybHkgY2xv Y2sgcHJvdmlkZXIuIEl0IGhhcyBubyBkZXBlbmRlbmNpZXMgYW5kIAo+IG90aGVyIGRyaXZlcnMg dGhhdCBkZXBlbmRzIG9uIGl0LCBsaWtlIElSLCBjYW4gYmUgZGVmZXJyZWQsIGlmIHRoaXMgaXMg bG9hZGVkIAo+IGxhdGVyLgoKQW5vdGhlciByZWFzb24gaXMgc28gdGhlIGRyaXZlciBjYW4gYmUg YnVpbHQgYXMgYSBtb2R1bGUuIEVhY2ggb2YgdGhlc2UKQ0NVIGRyaXZlcnMgaGFzIDMway03MGsg b2YgZGF0YSBpbiBpdCAobG90cyBvZiBwb2ludGVycywgcGx1cyBsb3RzIG9mCnJlbG9jYXRpb25z KS4gU28gaXQgc2F2ZXMgc29tZSBSQU0gdG8gb25seSBsb2FkIHRoZSBvbmVzIHlvdSBuZWVkLApl c3BlY2lhbGx5IGlmIHRoYXQgaXMgbm9uZSBvZiB0aGVtLgoKUmVnYXJkcywKU2FtdWVsCgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2Vy bmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0 cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVs Cg==