From: Andrzej Hajda <andrzej.hajda@gmail.com>
To: Stephen Boyd <swboyd@chromium.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org,
"Arnd Bergmann" <arnd@arndb.de>,
"Benjamin Gaignard" <benjamin.gaignard@linaro.org>,
"Chen Feng" <puck.chen@hisilicon.com>,
"Chen-Yu Tsai" <wens@csie.org>,
"Christian Gmeiner" <christian.gmeiner@gmail.com>,
"Chun-Kuang Hu" <chunkuang.hu@kernel.org>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
"Emma Anholt" <emma@anholt.net>,
"Heiko Stübner" <heiko@sntech.de>,
"Inki Dae" <inki.dae@samsung.com>,
"James Qian Wang" <james.qian.wang@arm.com>,
"Jaroslav Kysela" <perex@perex.cz>,
"Joerg Roedel" <joro@8bytes.org>,
"John Stultz" <john.stultz@linaro.org>,
"Joonyoung Shim" <jy0922.shim@samsung.com>,
"Jyri Sarha" <jyri.sarha@iki.fi>,
"Kai Vehmanen" <kai.vehmanen@linux.intel.com>,
"Kyungmin Park" <kyungmin.park@samsung.com>,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
linux-fbdev@vger.kernel.org, linux-omap@vger.kernel.org,
linux-pm@vger.kernel.org, "Liviu Dudau" <liviu.dudau@arm.com>,
"Lucas Stach" <l.stach@pengutronix.de>,
"Mark Brown" <broonie@kernel.org>,
"Maxime Ripard" <mripard@kernel.org>,
"Neil Armstrong" <narmstrong@baylibre.com>,
"Paul Cercueil" <paul@crapouillou.net>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Rob Clark" <robdclark@gmail.com>,
"Russell King" <linux@armlinux.org.uk>,
"Russell King" <linux+etnaviv@armlinux.org.uk>,
"Russell King" <rmk+kernel@arm.linux.org.uk>,
"Sandy Huang" <hjc@rock-chips.com>,
"Saravana Kannan" <saravanak@google.com>,
"Sebastian Reichel" <sre@kernel.org>,
"Seung-Woo Kim" <sw0312.kim@samsung.com>,
"Takashi Iwai" <tiwai@suse.com>,
"Tian Tao" <tiantao6@hisilicon.com>,
"Tomas Winkler" <tomas.winkler@intel.com>,
"Tomi Valkeinen" <tomba@kernel.org>,
"Will Deacon" <will@kernel.org>,
"Xinliang Liu" <xinliang.liu@linaro.org>,
"Xinwei Kong" <kong.kongxinwei@hisilicon.com>,
"Yong Wu" <yong.wu@mediatek.com>
Subject: Re: [PATCH v2 00/34] component: Make into an aggregate bus
Date: Thu, 7 Oct 2021 12:16:27 +0200 [thread overview]
Message-ID: <5d3f4343-da38-04b4-fdb9-cb2dd4983db2@gmail.com> (raw)
In-Reply-To: <20211006193819.2654854-1-swboyd@chromium.org>
Hi Stephen,
On 06.10.2021 21:37, Stephen Boyd wrote:
> This series is from discussion we had on reordering the device lists for
> drm shutdown paths[1]. I've introduced an 'aggregate' bus that we put
> the aggregate device onto and then we probe the aggregate device once
> all the components are probed and call component_add(). The probe/remove
> hooks are where the bind/unbind calls go, and then a shutdown hook is
> added that can be used to shutdown the drm display pipeline at the right
> time.
>
> This works for me on my sc7180 board. I no longer get a warning from i2c
> at shutdown that we're trying to make an i2c transaction after the i2c
> bus has been shutdown. There's more work to do on the msm drm driver to
> extract component device resources like clks, regulators, etc. out of
> the component bind function into the driver probe but I wanted to move
> everything over now in other component drivers before tackling that
> problem.
As I understand you have DSI host with i2c-controlled DSI bridge. And
there is an issue that bridge is shutdown before msmdrm. Your solution
is to 'adjust' device order on pm list.
I had similar issue and solved it locally by adding notification from
DSI bridge to DSI host that is has to be removed: mipi_dsi_detach, this
notification escalates in DSI host to component_del and this allow to
react properly.
Advantages:
- it is local (only involves DSI host and DSI device),
- it does not depend on PM internals,
- it can be used in other scenarios as well - unbinding DSI device driver
Disadvantage:
- It is DSI specific (but this is your case), I have advertised some
time ago more general approach [1][2].
[1]: https://static.sched.com/hosted_files/osseu18/0f/deferred_problem.pdf
[2]: https://lwn.net/Articles/625454/
Regards
Andrzej
next prev parent reply other threads:[~2021-10-07 10:16 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-06 19:37 [PATCH v2 00/34] component: Make into an aggregate bus Stephen Boyd
2021-10-06 19:37 ` [PATCH v2 01/34] component: Introduce struct aggregate_device Stephen Boyd
2021-10-07 1:17 ` Laurent Pinchart
2021-10-07 18:36 ` Stephen Boyd
2021-10-13 12:22 ` Daniel Vetter
2021-10-13 19:49 ` Stephen Boyd
2021-10-06 19:37 ` [PATCH v2 02/34] component: Introduce the aggregate bus_type Stephen Boyd
2021-10-06 22:42 ` kernel test robot
2021-10-06 22:42 ` kernel test robot
2021-10-07 3:07 ` Saravana Kannan
2021-10-07 18:40 ` Stephen Boyd
2021-10-07 20:11 ` Stephen Boyd
2021-10-08 1:10 ` Saravana Kannan
2021-10-08 1:24 ` Stephen Boyd
2021-10-08 1:32 ` Saravana Kannan
2021-10-08 1:37 ` Stephen Boyd
2021-10-07 5:37 ` Greg Kroah-Hartman
2021-10-07 20:42 ` Stephen Boyd
2021-10-14 13:27 ` Daniel Vetter
2021-10-06 19:37 ` [PATCH v2 03/34] component: Move struct aggregate_device out to header file Stephen Boyd
2021-10-06 19:37 ` [PATCH v2 04/34] drm/msm: Migrate to aggregate driver Stephen Boyd
2021-10-06 19:37 ` [PATCH v2 05/34] component: Add {bind,unbind}_component() ops that take aggregate device Stephen Boyd
2021-10-06 19:37 ` [PATCH v2 05/34] component: Add {bind, unbind}_component() " Stephen Boyd
2021-10-06 19:37 ` [PATCH v2 06/34] drm/of: Add a drm_of_aggregate_probe() API Stephen Boyd
2021-10-06 22:28 ` kernel test robot
2021-10-06 22:28 ` kernel test robot
2021-10-06 22:36 ` kernel test robot
2021-10-06 22:36 ` kernel test robot
2021-10-06 19:37 ` [PATCH v2 07/34] drm/komeda: Migrate to aggregate driver Stephen Boyd
2021-10-06 19:37 ` [PATCH v2 08/34] drm/arm/hdlcd: " Stephen Boyd
2021-10-06 19:37 ` [PATCH v2 09/34] drm/malidp: " Stephen Boyd
2021-10-06 19:37 ` [PATCH v2 10/34] drm/armada: " Stephen Boyd
2021-10-06 19:37 ` [PATCH v2 11/34] drm/etnaviv: " Stephen Boyd
2021-10-06 19:37 ` [PATCH v2 12/34] drm/kirin: " Stephen Boyd
2021-10-06 19:37 ` [PATCH v2 13/34] drm/exynos: " Stephen Boyd
2021-10-06 19:37 ` [PATCH v2 14/34] drm/imx: " Stephen Boyd
2021-10-06 19:38 ` [PATCH v2 15/34] drm/ingenic: " Stephen Boyd
2021-10-07 21:29 ` Paul Cercueil
2021-10-06 19:38 ` [PATCH v2 16/34] drm/mcde: " Stephen Boyd
2021-10-06 19:38 ` [PATCH v2 17/34] drm/mediatek: " Stephen Boyd
2021-10-06 19:38 ` [PATCH v2 18/34] drm/meson: " Stephen Boyd
2021-10-06 19:38 ` [PATCH v2 19/34] drm/omap: " Stephen Boyd
2021-10-06 19:38 ` [PATCH v2 20/34] drm/rockchip: " Stephen Boyd
2021-10-06 19:38 ` [PATCH v2 21/34] drm/sti: " Stephen Boyd
2021-10-06 19:38 ` [PATCH v2 22/34] drm/sun4i: " Stephen Boyd
2021-10-06 19:38 ` [PATCH v2 23/34] drm/tilcdc: " Stephen Boyd
2021-10-06 19:38 ` [PATCH v2 24/34] drm/vc4: " Stephen Boyd
2021-10-06 19:38 ` [PATCH v2 25/34] drm/zte: " Stephen Boyd
2021-10-06 19:38 ` [PATCH v2 26/34] iommu/mtk: " Stephen Boyd
2021-10-06 19:38 ` [PATCH v2 27/34] mei: " Stephen Boyd
2021-10-06 19:38 ` [PATCH v2 28/34] power: supply: ab8500: " Stephen Boyd
2021-10-13 16:24 ` Sebastian Reichel
2021-10-06 19:38 ` [PATCH v2 29/34] fbdev: omap2: " Stephen Boyd
2021-10-06 19:38 ` [PATCH v2 30/34] sound: hdac: " Stephen Boyd
2021-10-06 19:38 ` [PATCH v2 31/34] ASoC: codecs: wcd938x: " Stephen Boyd
2021-10-07 12:35 ` Mark Brown
2021-10-06 19:38 ` [PATCH v2 32/34] component: Get rid of drm_of_component_probe() Stephen Boyd
2021-10-06 19:38 ` [PATCH v2 33/34] component: Remove component_master_ops and friends Stephen Boyd
2021-10-06 23:19 ` kernel test robot
2021-10-06 23:19 ` kernel test robot
2021-10-06 19:38 ` [PATCH v2 34/34] component: Remove all references to 'master' Stephen Boyd
2021-10-07 10:16 ` Andrzej Hajda [this message]
2021-10-07 20:46 ` [PATCH v2 00/34] component: Make into an aggregate bus Stephen Boyd
2021-10-13 12:14 ` Daniel Vetter
2021-10-07 11:22 ` Andy Shevchenko
2021-10-07 12:33 ` Andrzej Hajda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d3f4343-da38-04b4-fdb9-cb2dd4983db2@gmail.com \
--to=andrzej.hajda@gmail.com \
--cc=arnd@arndb.de \
--cc=benjamin.gaignard@linaro.org \
--cc=broonie@kernel.org \
--cc=christian.gmeiner@gmail.com \
--cc=chunkuang.hu@kernel.org \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=emma@anholt.net \
--cc=freedreno@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=inki.dae@samsung.com \
--cc=james.qian.wang@arm.com \
--cc=john.stultz@linaro.org \
--cc=joro@8bytes.org \
--cc=jy0922.shim@samsung.com \
--cc=jyri.sarha@iki.fi \
--cc=kai.vehmanen@linux.intel.com \
--cc=kong.kongxinwei@hisilicon.com \
--cc=kyungmin.park@samsung.com \
--cc=l.stach@pengutronix.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux+etnaviv@armlinux.org.uk \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=liviu.dudau@arm.com \
--cc=mripard@kernel.org \
--cc=narmstrong@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=paul@crapouillou.net \
--cc=perex@perex.cz \
--cc=puck.chen@hisilicon.com \
--cc=rafael@kernel.org \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=robdclark@gmail.com \
--cc=saravanak@google.com \
--cc=sre@kernel.org \
--cc=sw0312.kim@samsung.com \
--cc=swboyd@chromium.org \
--cc=tiantao6@hisilicon.com \
--cc=tiwai@suse.com \
--cc=tomas.winkler@intel.com \
--cc=tomba@kernel.org \
--cc=wens@csie.org \
--cc=will@kernel.org \
--cc=xinliang.liu@linaro.org \
--cc=yong.wu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.